New CVS 1.12.9 format changes break some PCVS parsing

New CVS 1.12.9 format changes break some PCVS parsing

[Adam Elliott]

--text follows this line--
This bug report will be sent to the Free Software Foundation, not to 
your local site managers!
Please write in English, because the Emacs maintainers do not have 
translators to read other languages for them.

Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing 
list, and to the gnu.emacs.bug news group.

In GNU Emacs 21.3.1 (i386-mingw-nt5.1.2600)
  of 2004-03-10 on NYAUMO
configured using `configure --with-gcc (3.2)'
Important settings:
   value of $LC_ALL: nil
   value of $LC_COLLATE: nil
   value of $LC_CTYPE: nil
   value of $LC_MESSAGES: nil
   value of $LC_MONETARY: nil
   value of $LC_NUMERIC: nil
   value of $LC_TIME: nil
   value of $LANG: en_CA
   locale-coding-system: iso-latin-1
   default-enable-multibyte-characters: t

Please describe exactly what actions triggered the bug and the precise 
symptoms of the bug:


CVS was upgraded at my site (to 1.12.9) and the format of some of the 
messages returned have changed, breaking PCVS parsing.  The symptom is 
that messages previously interpreted by PCVS as important and displayed 
in special formats (e.g. changing file state, putting version number 
beside, etc.) now fail the various regexps since the format change. 
Thus they are displayed as non-specific informative messages and the 
special behaviour is not being triggered.

All required changes to fix are probably in pcvs-parse.el.

What I've found so far:

* message returned immediately after a new file is added

Old message: use 'cvs commit' to add this file permanently
New message: use `cvs commit' to add this file permanently
(note orientation of opening quote)

   - easy to fix; change regexp

* message returned when committing files

Old message (commit):
cvs commit: Examining .
Checking in dummy;
/dev/tmep/tmep/dummy,v  <--  dummy
new revision: 1.3; previous revision: 1.2
done

New message (commit):
cvs commit: Examining .
/dev/tmep/tmep/dummy,v  <--  dummy
new revision: 1.3; previous revision: 1.2

   - introductory line ("Checking in") gone
   - "done" gone
   - comparable for removals ("Removing" and "done" gone)
   - note that arrow line DOES NOT contain full path which introductory 
line did
     - causes problems when displaying the line after CVS operation 
completes: not "sorted" properly in tree (sorted to the root always 
because path information is not present)
     - not sure how to fix; parse and trim left side of arrow line?

* there may be others; change/release log for CVS is not specific as to 
which messages have changed although I'm sure source diffs would be 
useful here

Versions:

Emacs 21.3.1 for NT on WinXP
CVS 1.12.9 compiled from source under Cygwin (on WinXP)
  - problem exhibited with local repository as well as with remote 
repository via SSH

Problem is platform-independent as best I can tell as it results from a 
deliberate change by the CVS developers.

Adam