unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Adam Porter <adam@alphapapa.net>
To: Juri Linkov <juri@linkov.net>
Cc: 56874@debbugs.gnu.org
Subject: bug#56874: 28.1.50; tab-bar-format-align-right should probably use string-width
Date: Fri, 5 Aug 2022 15:32:35 -0500	[thread overview]
Message-ID: <40b946ca-71eb-0904-f1b1-773e5134bc4f@alphapapa.net> (raw)
In-Reply-To: <86pmhjbzmw.fsf@mail.linkov.net>

Hi Juri,

On 8/1/22 13:13, Juri Linkov wrote:

> Please check Emacs 29 where tab-bar-format-align-right
> contains a better improvement:
> 
>    (string-pixel-width (propertize rest 'face 'tab-bar))
> 
> Does this work in your case as well?

I don't have an Emacs 29 build readily accessible, but I see that Emacs 
28 has the function `shr-string-pixel-width', which I'm guessing is 
similar.  So I tried using that function, and it is an improvement, but 
not quite correct: rather than wrapping onto a new line, the string 
appears on the same line as the rest of the tab-bar, but it is not 
right-aligned as it should be.

If it would help you reproduce the problem to test whether Emacs 29 
already has a fix, all that seems to be necessary is to set the tab-bar 
face to, e.g. ":height 1.2", and add a string of some length (e.g. about 
20) to the global-mode-string, and see whether it wraps onto a new line 
and whether it's right-aligned.  If it seems correct on Emacs 29, then 
I'd guess it's already solved.

Thanks,
Adam





  reply	other threads:[~2022-08-05 20:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-01 16:49 bug#56874: 28.1.50; tab-bar-format-align-right should probably use string-width Adam Porter
2022-08-01 18:13 ` Juri Linkov
2022-08-05 20:32   ` Adam Porter [this message]
2022-08-08 17:11     ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40b946ca-71eb-0904-f1b1-773e5134bc4f@alphapapa.net \
    --to=adam@alphapapa.net \
    --cc=56874@debbugs.gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).