From: Drew Adams <drew.adams@oracle.com>
To: Drew Adams <drew.adams@oracle.com>,
Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 14925@debbugs.gnu.org
Subject: bug#14925: 24.3.50; `image-dired.el' code (minor)
Date: Thu, 25 Jul 2013 22:31:06 -0700 (PDT) [thread overview]
Message-ID: <40a97f39-de0b-41a5-a0af-54bc37e66083@default> (raw)
In-Reply-To: <f87df0f9-60a1-43b4-8435-3d740bbe488d@default>
> > > 1. `image-dired-dired-file-marked-p' uses regexp "^ .*$", which I think
> > > is the same as "^ " (which is simpler).
> >
> > It's similar, except for (match-end 0) and the position of point after
> > re-search-forward. I haven't looked at the code to see if the
> > difference matters.
>
> It does not; the match data and the position of point are not used.
> (The `-p' suffix provides a clue.) There is currently only one occurrence
> of `image-dired-dired-file-marked-p':
>
> (if (image-dired-dired-file-marked-p)
> (dired-unmark 1)
> (dired-mark 1))
It also uses `save-excursion' and `looking-at', not `re-search-forward'.
However, as it is in principle just a predicate it should probably also
use `looking-at-p', not `looking-at'.
next prev parent reply other threads:[~2013-07-26 5:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-21 19:37 bug#14925: 24.3.50; `image-dired.el' code (minor) Drew Adams
2013-07-21 19:54 ` Drew Adams
2013-07-25 19:13 ` Stefan Monnier
2013-07-26 1:02 ` Drew Adams
2013-07-26 5:31 ` Drew Adams [this message]
2021-09-06 10:12 ` Lars Ingebrigtsen
2021-09-06 21:49 ` bug#14925: [External] : " Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40a97f39-de0b-41a5-a0af-54bc37e66083@default \
--to=drew.adams@oracle.com \
--cc=14925@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).