From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alexander Shukaev Newsgroups: gmane.emacs.bugs Subject: bug#25189: Use `current-global-map' in `comint-insert-input' Date: Wed, 25 Dec 2019 10:59:56 +0100 Message-ID: <40a05d64-0907-6b83-6961-dd4a2c510d31@Alexander.Shukaev.name> References: <7a0f388c-3678-cf59-5da6-11c532f4fcdd@Alexander.Shukaev.name> <875znnk96a.fsf@mouse.gnus.org> <45ae521c-6f37-292e-c169-9ed591cb0504@Alexander.Shukaev.name> <87k16l6689.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="64854"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 25189@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 25 11:01:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ik3Td-000GlL-4b for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Dec 2019 11:01:13 +0100 Original-Received: from localhost ([::1]:45202 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ik3Tb-0004qK-8G for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Dec 2019 05:01:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57268) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ik3TT-0004ow-Co for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2019 05:01:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ik3TS-00081q-Br for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2019 05:01:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47335) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ik3TS-00081d-8w for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2019 05:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ik3TS-0000nW-76 for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2019 05:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alexander Shukaev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Dec 2019 10:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix Original-Received: via spool by 25189-submit@debbugs.gnu.org id=B25189.15772680032921 (code B ref 25189); Wed, 25 Dec 2019 10:01:02 +0000 Original-Received: (at 25189) by debbugs.gnu.org; 25 Dec 2019 10:00:03 +0000 Original-Received: from localhost ([127.0.0.1]:53308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ik3SU-0000ks-Am for submit@debbugs.gnu.org; Wed, 25 Dec 2019 05:00:02 -0500 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:49535) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ik3SS-0000kG-Dj for 25189@debbugs.gnu.org; Wed, 25 Dec 2019 05:00:01 -0500 X-Originating-IP: 178.4.8.44 Original-Received: from [192.168.3.109] (dslb-178-004-008-044.178.004.pools.vodafone-ip.de [178.4.8.44]) (Authenticated sender: forum@alexander.shukaev.name) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 3ACD140002; Wed, 25 Dec 2019 09:59:57 +0000 (UTC) In-Reply-To: <87k16l6689.fsf@gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173740 Archived-At: On 12/24/19 5:25 PM, Lars Ingebrigtsen wrote: > Alexander Shukaev writes: > >> On 7/27/19 1:29 PM, Lars Ingebrigtsen wrote: >>> Alexander Shukaev writes: >>> >>>> I think according to Emacs documentation it's more correct to change the >>>> >>>> (lookup-key global-map (vector last-key)) >>>> >>>> form to the >>>> >>>> (lookup-key (current-global-map) (vector last-key)) >>>> >>>> form. >>> (I'm going through older Emacs bug reports that have received no >>> response.) >>> Looking at the manual section in "Controlling Active Maps", there >>> doesn't seem to be anything to discourage using `global-map' directly >>> there. I've grepped through the sources, though, and `global-map' is >>> used all over the place (while `current-global-map' is used less). >>> So this doesn't seem like something to be fixed, and I'm closing >>> this >>> bug report. >>> >> >> I believe you want to read the docstring of `global-map' for that point. > > It would help if you could point to where you think Emacs says this. > > This is the doc string of global-map: > > global-map is a variable defined in ‘subr.el’. > Its value is shown below. > > This variable may be risky if used as a file-local variable. > Probably introduced at or before Emacs version 21.1. > > Documentation: > Default global keymap mapping Emacs keyboard input into commands. > The value is a keymap that is usually (but not necessarily) Emacs’s > global map. > > In particular, > The value is a keymap that is usually (but not necessarily) Emacs’s > global map. So it's not necessarily the current global keymap. Hence, applying `define-key' (or any other mutating function to it), may not take any effect and do what is expected. It is safer to always use `current-global-map'. At least that is my understanding why there are special functions like `current-global-map' for accessing and `use-global-map' for assignment.