From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: james@jojojames.com Newsgroups: gmane.emacs.bugs Subject: bug#32392: 26.1; wdired and derived dired modes Date: Sun, 14 Jul 2019 20:39:50 -0700 Message-ID: <40C0B550-0D3A-40EA-9112-B51A19B0F7D1@jojojames.com> References: <875zo6zllj.fsf@mouse.gnus.org> Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="256927"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 32392@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 15 05:40:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hmrqS-0014h9-6Z for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Jul 2019 05:40:10 +0200 Original-Received: from localhost ([::1]:35028 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmrqR-0007R8-59 for geb-bug-gnu-emacs@m.gmane.org; Sun, 14 Jul 2019 23:40:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42285) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmrqN-0007Qp-ES for bug-gnu-emacs@gnu.org; Sun, 14 Jul 2019 23:40:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hmrqM-0006nI-FB for bug-gnu-emacs@gnu.org; Sun, 14 Jul 2019 23:40:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37410) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hmrqM-0006nE-9K for bug-gnu-emacs@gnu.org; Sun, 14 Jul 2019 23:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hmrqM-0000o5-3U for bug-gnu-emacs@gnu.org; Sun, 14 Jul 2019 23:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: james@jojojames.com Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Jul 2019 03:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32392 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 32392-submit@debbugs.gnu.org id=B32392.15631619993087 (code B ref 32392); Mon, 15 Jul 2019 03:40:01 +0000 Original-Received: (at 32392) by debbugs.gnu.org; 15 Jul 2019 03:39:59 +0000 Original-Received: from localhost ([127.0.0.1]:46231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmrqJ-0000nj-92 for submit@debbugs.gnu.org; Sun, 14 Jul 2019 23:39:59 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:44679) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmrqF-0000nV-OU for 32392@debbugs.gnu.org; Sun, 14 Jul 2019 23:39:57 -0400 Original-Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 1B9C622185; Sun, 14 Jul 2019 23:39:50 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Sun, 14 Jul 2019 23:39:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jojojames.com; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=fm3; bh=k jx9W+YsXGv7p+KabPkfaamcRSUXk/bFUX2RzRATxws=; b=IkV3py4D8wWGKl//9 amxby0PVpJbTms8+hOIbARcW/QJ10JKiIfUxW48+Z+MdCN24bgPCSA0jmz3P8Ip6 nFw3X6HcRd3UYHJ07Xkf7uprn/UMlI3EYZX2WY5NMiXcvVfDZxKTGBIBjbId3IrV ytEWEruC9JhHHfT98GqRalT2kOSNHwVOoY1z5IenngK0k5Nf6VZMSs7Wlth1US0+ gn6L726bvgxPUzvdvg2jNq/SVtkzyyUB9pv7UtbIOskX82xy8AvPKxCcil4v1tbQ 4bP+YDMfV+WcfQEVUR6l+q5u71yO/8mEp/ejp8Q0vSbFo57T2yne2B/vFFqZsd+T bbuEQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=kjx9W+YsXGv7p+KabPkfaamcRSUXk/bFUX2RzRATx ws=; b=kGRVK3H09i+fz+mbzoW0E2rYq0AXKzog7Chd1uYRDl82ONeUiaTpMF3fu ItVswPGRUOl9t51VSqjZo85mmUcSsTMPRR9QLTF9bZczTnAHagVa5+IK/rGTAtsD svJL9jTEjA7HGkY01PDtdJEj1YB6KbGyh9+S5HKH1cHTL3Mgs65GJ2TOyl9fJQPF vgriqcwYSnoaQw3UQtlOAMOnwC3dcmLQK0PDTM8Mv/KwOR6GGbWasKeapJ052ywY PhrifzkmtOEZl2GYladoym7HCVbxDhjyZsnOVeuBzv2RZwLB4dydsFWTJTjgxtHG 5kHlzSVGWWDebSTLcgfO+kHOpawUw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrheejgdegiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpegtggfuhfgjfffgkfhfvffosehtjehmtdhhtddvnecuhfhrohhmpehjrghmvghs sehjohhjohhjrghmvghsrdgtohhmnecuffhomhgrihhnpehinhhgvggsrhhighhtshgvnh drnhhonecukfhppeejiedrudejuddrvddvledrieejnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehjrghmvghssehjohhjohhjrghmvghsrdgtohhmnecuvehluhhsthgvrhfuihiivg eptd X-ME-Proxy: Original-Received: from [10.0.1.9] (cpe-76-171-229-67.socal.res.rr.com [76.171.229.67]) by mail.messagingengine.com (Postfix) with ESMTPA id 3983D380076; Sun, 14 Jul 2019 23:39:49 -0400 (EDT) In-Reply-To: <875zo6zllj.fsf@mouse.gnus.org> X-Mailer: Apple Mail (2.3273) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163062 Archived-At: Thanks! > On Jul 12, 2019, at 7:58 PM, Lars Ingebrigtsen wrote: > > James Nguyen writes: > >> Digging into the function wdired-change-to-wdired-mode, that function >> throws an error if the current major mode is not 'dired-mode. >> >> (unless (eq major-mode 'dired-mode) >> (error "Not a Dired buffer")) >> >> I think we can change the check to be: >> >> (unless (derived-mode-p 'dired-mode) >> (error "Not a Dired buffer")) > > Makes sense to me; I've now done this change on the Emacs trunk. > > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no