From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Nicholas Savage" Newsgroups: gmane.emacs.bugs Subject: bug#39912: [PATCH] Open describe-function links in view-mode (Bug#39912) Date: Tue, 08 Sep 2020 20:14:15 -0400 Message-ID: <4098510f-4213-4c1c-9ac5-fdfdb14a69e8@www.fastmail.com> References: <87v9nkm137.fsf@betli.tmit.bme.hu> <48e2dded-3082-4ed0-96dd-784bb5623782@www.fastmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=c832d8e0c1ab4ec1b83e20212ee6e261 Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3216"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Cyrus-JMAP/3.3.0-259-g88fbbfa-fm-20200903.003-g88fbbfa3 To: "Stefan Kangas" , 39912@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 09 02:18:39 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFnot-0000kW-LB for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Sep 2020 02:18:39 +0200 Original-Received: from localhost ([::1]:33520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFnos-0002hy-MG for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Sep 2020 20:18:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37246) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFnnK-0007le-Ea for bug-gnu-emacs@gnu.org; Tue, 08 Sep 2020 20:17:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45212) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFnnK-0002Cx-27 for bug-gnu-emacs@gnu.org; Tue, 08 Sep 2020 20:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kFnnJ-0008Dw-TN for bug-gnu-emacs@gnu.org; Tue, 08 Sep 2020 20:17:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Nicholas Savage" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Sep 2020 00:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39912 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: easy Original-Received: via spool by 39912-submit@debbugs.gnu.org id=B39912.159961057331552 (code B ref 39912); Wed, 09 Sep 2020 00:17:01 +0000 Original-Received: (at 39912) by debbugs.gnu.org; 9 Sep 2020 00:16:13 +0000 Original-Received: from localhost ([127.0.0.1]:56758 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFnmW-0008Cp-NE for submit@debbugs.gnu.org; Tue, 08 Sep 2020 20:16:12 -0400 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:43823) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFnmR-0008CK-LR for 39912@debbugs.gnu.org; Tue, 08 Sep 2020 20:16:10 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7431C5C014D; Tue, 8 Sep 2020 20:16:02 -0400 (EDT) Original-Received: from imap21 ([10.202.2.71]) by compute1.internal (MEProxy); Tue, 08 Sep 2020 20:16:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=ZOYuUu NB05+xlLk6vu5hGeq3dLefw+hfvtBCQ8E3slM=; b=EUXk9yWkyCIfINqZ00W6CC c+Zh++G8EZv1wzVpb9BsLCVajwsHLUCxr95of/TKHWyczJ1TjNx/N2VIGC5TswxU G9tK2UGkF3/zwePpxCspeXe7MOBA26pyLNzJg0axF6Y3ZJUrU/7kQH9o2quc9bFA h0heh9TTNA9/lZ4eC86JeCwwkmIvdptRkYnbF1h2Jg7zgVnLYPwwGxGglc5Jn2gB 9TAzawPMCs20ST2fqEV9kPMYpB7cgdvOnGealQKeTQXEuAyNi5aMMa88+V7tZWlt 6tBlFE96VfcWLz4zOd/Vm0hzXXKOMr4JWzTIh5jS6X3GhjS94T5UxJ+7nTN2LcZA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudehgedgfeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesmhdtreerreerjeenucfhrhhomhepfdfpihgt hhholhgrshcuufgrvhgrghgvfdcuoehnihgtkhesnhhitghkshgrvhgrghgvrdgtrgeqne cuggftrfgrthhtvghrnhepkedvfffgheefleffvdevteekvdeijedvkeegteefvedviedt leejhffgffduleeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepnhhitghksehnihgtkhhsrghvrghgvgdrtggr X-ME-Proxy: Original-Received: by mailuser.nyi.internal (Postfix, from userid 501) id 44B28660069; Tue, 8 Sep 2020 20:15:56 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187607 Archived-At: --c832d8e0c1ab4ec1b83e20212ee6e261 Content-Type: text/plain Thanks for the comments. I've attached an updated patch, and have responded to your points below. On Tue, Sep 8, 2020, at 17:01, Stefan Kangas wrote: > "Nicholas Savage" writes: > > > I've written a patch for Bug #39912, as discussed in debbugs. I think I > > have formatted this correctly and have followed CONTRIBUTE as best as I > > could. > > Thanks! I have some comments. > > (Someone else will have to help you with getting the assignment process > started.) This is now underway! > > > I've also changed it so the actual source code link opens in view-mode > > as well. I don't know if there are ramifications of that, so I'm happy > > to change it if necessary. My thought process was that > > describe-function is used as a reference to the code, not as a point > > of entry for editing functions, so changing that is consistent with > > changing the NEWS links, but I don't know what I don't know. > > Actually, I use it to edit the source code all the time. That's what > that button is mostly used for, in my use. :-) > > So I think we'd better leave that part out. > Yeah, that makes sense now that I'm thinking about it. I thought it may be beyond the pale, which is why I wanted to highlight it. I've removed it now in the new attached patch. > > * Open describe-function links in view-mode (Bug#39912) to make > > behavior consistent depending on whether or not user has permission > > to edit the files. > > The description is okay, but could be shorter (and should mention the > link to NEWS button as discussed above). I'm also not sure if its > necessary to discuss file permissions here, since those details will be > in the bug report. Mentioning view-mode should be enough. > > Also, this doesn't seem to follow the ChangeLog format. If you use VC > (or Magit) to edit the files, you can simply put point on the newly > added line and type `C-x 4 a' to get it automatically generated. You > could even do it directly in the ELisp file, if point is in the changed > function. (Read CONTRIBUTE for more details.) I didn't know about `C-x 4 a'. Is that better now? I have reworded the description as well. I appreciate all of your advice and help! This has been my first real attempt at working in a development environment, as my day job is in a different industry, so there's a bit of a learning curve but I'm eager to catch up and contribute as I can. --c832d8e0c1ab4ec1b83e20212ee6e261 Content-Disposition: attachment;filename="0001-Open-describe-function-NEWS-links-in-view-mode-Bug-3.patch" Content-Type: text/x-patch; name="0001-Open-describe-function-NEWS-links-in-view-mode-Bug-3.patch" Content-Transfer-Encoding: BASE64 RnJvbSAyZTk4MDQ3MTM3ZTZmNTY0OTRmOGM0MWZkYmYxZDlkMTI3NWQwODQwIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBOaWNrIFNhdmFnZSA8bmlja0BuaWNrc2F2YWdlLmNh PgpEYXRlOiBUdWUsIDggU2VwIDIwMjAgMTY6MDg6MzAgLTA0MDAKU3ViamVjdDogW1BBVENI XSBPcGVuIGRlc2NyaWJlLWZ1bmN0aW9uIE5FV1MgbGlua3MgaW4gdmlldy1tb2RlIChCdWcj Mzk5MTIpCgoqIGxpc3AvaGVscC1tb2RlLmVsIChoZWxwLW5ld3MpOiBPcGVuIGRlc2NyaWJl LWZ1bmN0aW9uIE5FV1MgbGlua3MgaW4Kdmlldy1tb2RlIChCdWcjMzk5MTIpCgpDb3B5cmln aHQtcGFwZXJ3b3JrLWV4ZW1wdDogeWVzCi0tLQogbGlzcC9oZWxwLW1vZGUuZWwgfCAyICst CiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYg LS1naXQgYS9saXNwL2hlbHAtbW9kZS5lbCBiL2xpc3AvaGVscC1tb2RlLmVsCmluZGV4IDlj MmQxZDcyMjcuLjdhNWQ0MDVjMDEgMTAwNjQ0Ci0tLSBhL2xpc3AvaGVscC1tb2RlLmVsCisr KyBiL2xpc3AvaGVscC1tb2RlLmVsCkBAIC0zMDgsNyArMzA4LDcgQEAgJ2hlbHAtbmV3cwog ICA6c3VwZXJ0eXBlICdoZWxwLXhyZWYKICAgJ2hlbHAtZnVuY3Rpb24KICAgKGxhbWJkYSAo ZmlsZSBwb3MpCi0gICAgKHBvcC10by1idWZmZXIgKGZpbmQtZmlsZS1ub3NlbGVjdCBmaWxl KSkKKyAgICAodmlldy1idWZmZXIgKGZpbmQtZmlsZS1ub3NlbGVjdCBmaWxlKSkKICAgICAo Z290by1jaGFyIHBvcykpCiAgICdoZWxwLWVjaG8gKHB1cmVjb3B5ICJtb3VzZS0yLCBSRVQ6 IHNob3cgY29ycmVzcG9uZGluZyBORVdTIGFubm91bmNlbWVudCIpKQogDAotLSAKMi4yMC4x Cgo= --c832d8e0c1ab4ec1b83e20212ee6e261--