Re: in dired hit v on a .zip archive

Re: in dired hit v on a .zip archive

[Kevin Rodgers]

Dan Jacobson wrote:
 > In dired hit v on a .zip archive.
 > Now both view mode and zip-archive mode are in effect.
 > I say only zip-archive mode should be now in effect, just as if we hit RET.

I say Emacs is behaving correctly and as documented:

| v runs the command dired-view-file
|    which is an interactive compiled Lisp function in `dired'.
| (dired-view-file)
|
| In dired, examine a file in view mode, returning to dired when done.

 > Just as when we hit v on a subdirectory, are we put into view mode?
 > No, we are put into dired mode.

But we _should_ be put in View mode.  Here's a patch:

*** emacs-21.3/lisp/dired.el.orig	Fri Feb  7 04:48:13 2003
--- emacs-21.3/lisp/dired.el	Fri Apr  9 09:53:54 2004
***************
*** 1396,1402 ****
     (if (file-directory-p (dired-get-filename))
         (or (and (cdr dired-subdir-alist)
   	       (dired-goto-subdir (dired-get-filename)))
! 	  (dired (dired-get-filename)))
       (view-file (dired-get-filename))))

   (defun dired-find-file-other-window ()
--- 1396,1403 ----
     (if (file-directory-p (dired-get-filename))
         (or (and (cdr dired-subdir-alist)
   	       (dired-goto-subdir (dired-get-filename)))
!           (let ((find-file-run-dired t))
!             (view-file (dired-get-filename))))
       (view-file (dired-get-filename))))

   (defun dired-find-file-other-window ()


-- 
Kevin Rodgers

Re: in dired hit v on a .zip archive

[Dan Jacobson]

>> Just as when we hit v on a subdirectory, are we put into view mode?
>> No, we are put into dired mode.

K> But we _should_ be put in View mode.  Here's a patch:

Oh great, looks like dired but it's in view mode, just what us with
few cells to spare left upstairs need.

Anyway, when I hit v on a .deb here on debian, I like how it also
doesn't turn on view mode at the same time. etc.  No patches please
this time.

hitting v on a tar.gz does turn on tar and view mode.

Well, what is it going to be for all of these, yoo hoo, oh father of
free software? Strict RET and v divided, like Kevin wants, or v=RET
muddled, like I seem to maybe still want?

Re: in dired hit v on a .zip archive

[Kevin Rodgers]

Dan Jacobson wrote:
 > Well, what is it going to be for all of these, yoo hoo, oh father of
 > free software? Strict RET and v divided, like Kevin wants, or v=RET
 > muddled, like I seem to maybe still want?

Here's what RMS wrote to me regarding my patch:

| This change would not achieve its aim.  view-file on a Dired buffer
| does nothing except switch-to-buffer, because Dired mode is a special
| mode:
|
|   (interactive "fView file: ")
|   (unless (file-exists-p file) (error "%s does not exist" file))
|   (let ((had-a-buf (get-file-buffer file))
| 	  (buffer (find-file-noselect file)))
|     (if (eq (with-current-buffer buffer
| 		(get major-mode 'mode-class))
| 	      'special)
| 	  (progn
| 	    (switch-to-buffer buffer)
| 	    (message "Not using View mode because the major mode is special"))
|
| This recognizes that using view-mode on a directory listing is not
| very useful.  The code should do what it does now.

-- 
Kevin Rodgers

in dired hit v on a .zip archive

[Dan Jacobson]

In dired hit v on a .zip archive.
Now both view mode and zip-archive mode are in effect.
I say only zip-archive mode should be now in effect, just as if we hit RET.

Just as when we hit v on a subdirectory, are we put into view mode?
No, we are put into dired mode.