unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Noam Postavsky <npostavs@gmail.com>
Cc: Stefan Kangas <stefan@marxist.se>,
	20845@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#20845: 25.0.50; bookmark.el, handling of fictitious `buffer' property
Date: Fri, 5 Jul 2019 14:35:04 -0700 (PDT)	[thread overview]
Message-ID: <405d0ee9-4de7-473c-9308-fd83930259ad@default> (raw)
In-Reply-To: <855zogdxml.fsf@gmail.com>

> > It should be sufficient to communicate the buffer
> > _name_ as the property value.  And that's something
> > savable and retrievable - it's useful generally.
> >
> > IOW, it's OK to have `buffer' bookmark property,
> > but I think its value should be a buffer name.
> 
> Would that potentially be a problem if the buffer is renamed?

Yes. But it's not much different from the problem
that arises if a file name is changed.

And no different from the case where a buffer
(not a buffer name) no longer exists (which can
happen even if a buffer object is used in a live,
not persisted, `bookmark-alist').

We can try to jump through hoops for this.  It's
a choice how many hoops we want to jump through.

We could `condition-case'-handle the case where
`bookmark-default-handler' is used, and try to
deal with errors such as those.  We already do
that for condition `bookmark-error-no-filename'.





  reply	other threads:[~2019-07-05 21:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-18 15:26 bug#20845: 25.0.50; bookmark.el, handling of fictitious `buffer' property Drew Adams
2019-07-05 12:45 ` Stefan Kangas
2019-07-05 13:46   ` Stefan Monnier
2019-07-05 14:04     ` Stefan Kangas
2019-07-05 17:16       ` Drew Adams
2019-07-05 20:39         ` Noam Postavsky
2019-07-05 21:35           ` Drew Adams [this message]
2019-07-05 20:51         ` Stefan Monnier
2019-07-05 21:33           ` Drew Adams
2022-02-03 21:16     ` Lars Ingebrigtsen
2022-02-03 22:03       ` bug#20845: [External] : " Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=405d0ee9-4de7-473c-9308-fd83930259ad@default \
    --to=drew.adams@oracle.com \
    --cc=20845@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=npostavs@gmail.com \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).