From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mike Kupfer Newsgroups: gmane.emacs.bugs Subject: bug#57293: 29.0.50; query-replace with Wdired skips symlink target Date: Sat, 20 Aug 2022 18:54:45 -0700 Message-ID: <40517.1661046885@alto> References: <60773.1660878696@alto> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33820"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Michael Heerdegen , 57293@debbugs.gnu.org, Juri Linkov To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 21 03:55:21 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oPaBM-0008fP-SF for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Aug 2022 03:55:20 +0200 Original-Received: from localhost ([::1]:50794 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oPaBL-0001RK-B1 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 20 Aug 2022 21:55:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50974) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oPaB4-0001RB-It for bug-gnu-emacs@gnu.org; Sat, 20 Aug 2022 21:55:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43888) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oPaB4-0008Cb-92 for bug-gnu-emacs@gnu.org; Sat, 20 Aug 2022 21:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oPaB4-0001OR-18 for bug-gnu-emacs@gnu.org; Sat, 20 Aug 2022 21:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mike Kupfer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Aug 2022 01:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57293 X-GNU-PR-Package: emacs Original-Received: via spool by 57293-submit@debbugs.gnu.org id=B57293.16610468985342 (code B ref 57293); Sun, 21 Aug 2022 01:55:01 +0000 Original-Received: (at 57293) by debbugs.gnu.org; 21 Aug 2022 01:54:58 +0000 Original-Received: from localhost ([127.0.0.1]:33637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oPaAz-0001O6-Si for submit@debbugs.gnu.org; Sat, 20 Aug 2022 21:54:58 -0400 Original-Received: from shell1.rawbw.com ([198.144.192.42]:58253 ident=root) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oPaAu-0001Ns-Od for 57293@debbugs.gnu.org; Sat, 20 Aug 2022 21:54:56 -0400 Original-Received: from alto (135-180-174-133.dsl.dynamic.sonic.net [135.180.174.133] (may be forged)) (authenticated bits=0) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTPSA id 27L1sjxK028056 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 20 Aug 2022 18:54:50 -0700 (PDT) (envelope-from mkupfer@alum.berkeley.edu) X-Authentication-Warning: shell1.rawbw.com: Host 135-180-174-133.dsl.dynamic.sonic.net [135.180.174.133] (may be forged) claimed to be alto In-Reply-To: Your message of "Sat, 20 Aug 2022 18:07:17 -0700." X-Mailer: MH-E 8.6+git; nmh 1.7.1; Emacs 29.0.50 Content-ID: <40516.1661046885.1@alto> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240274 Archived-At: Stefan Kangas wrote: > Michael Heerdegen writes: > > > Mike Kupfer writes: > > > >> I expect query-replace to ask me about both the file foo and the symlink > >> target foo. That's what Emacs 28.1 does, and it's quite handy. > >> Instead, query-replace asks me only about the file foo, ignoring the > >> symlink target. > > > > Thanks for the report, Mike. See the new option > > `wdired-search-replace-filenames' to turn off the new behavior. > > > > Maybe turning this new behavior on by default was too much (Juri)? > > Shouldn't we get the Emacs 28 behavior whether or not that option is > enabled though? IOW, isn't this just a bug? The docstring says Non-nil to search and replace in file names only. so it does look like the relevant control. (But I wouldn't be surprised if I were missing something.) I have a slight preference for getting the Emacs 28 behavior by default, but I'm okay either way. If there had been a NEWS entry about the new option (hint hint :-)) I wouldn't have filed a bug. I agree with Michael's point about "\M-sf". Right now, you get the filename-only behavior for isearch via a specific functions and keybindings, but for query-replace, the behavior is controlled by a user option. More consistency between isearch and query-replace seems like it would be a good thing. I did notice this NEWS entry: *** Search and replace in Dired/Wdired supports more regexps. For example, the regexp ".*" will match only characters that are part of the file name. Also "^.*$" can be used to match at the beginning of the file name and at the end of the file name. Does that functionality require wdired-search-replace-filenames to be non-nil? cheers, mike