From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#49127: Performance degradation in encode_coding_object Date: Mon, 16 Aug 2021 20:06:32 +0200 Message-ID: <4001E59F-63FF-4EF6-87B5-8A627871C4B8@acm.org> References: <83sfz970av.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_2F59ED86-55C6-4DDB-83EB-6BDE5D11FBB0" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27481"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 49127@debbugs.gnu.org, victor.nawothnig@icloud.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 16 20:08:53 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mFh2b-0006zr-Jc for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 16 Aug 2021 20:08:53 +0200 Original-Received: from localhost ([::1]:34308 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFh2Z-0001e3-KE for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 16 Aug 2021 14:08:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60010) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFh1n-0000pA-Rg for bug-gnu-emacs@gnu.org; Mon, 16 Aug 2021 14:08:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39384) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mFh1n-0007os-Kz for bug-gnu-emacs@gnu.org; Mon, 16 Aug 2021 14:08:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mFh1m-0002h1-C0 for bug-gnu-emacs@gnu.org; Mon, 16 Aug 2021 14:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Aug 2021 18:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49127 X-GNU-PR-Package: emacs Original-Received: via spool by 49127-submit@debbugs.gnu.org id=B49127.162913724910300 (code B ref 49127); Mon, 16 Aug 2021 18:08:02 +0000 Original-Received: (at 49127) by debbugs.gnu.org; 16 Aug 2021 18:07:29 +0000 Original-Received: from localhost ([127.0.0.1]:50930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFh1B-0002fx-J5 for submit@debbugs.gnu.org; Mon, 16 Aug 2021 14:07:29 -0400 Original-Received: from mail211c50.megamailservers.eu ([91.136.10.221]:48428 helo=mail194c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFh15-0002ff-G1 for 49127@debbugs.gnu.org; Mon, 16 Aug 2021 14:07:24 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1629137237; bh=pZTKL2r/eIF4WofFOJaKCHIgqIiMqXgdmvNRtMQQ2Mg=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=GkwRjqs+ypbl6IKmr5XH7R7VdGkr164kSL6UweZT0Rj4FOVYeUq4gVjKZ8qquRiPx miNXWz+UdUaWN/r+17lIAITVVA5WBYZCvLe00Gl5i1pYvc4v8HJoZn0wf5BGw2nWf2 tiuX841q1RESAlr4otQX4qO4VP00WqicwvRIyQbk= Feedback-ID: mattiase@acm.or Original-Received: from stanniol.lan (c-b952e353.032-75-73746f71.bbcust.telenor.se [83.227.82.185]) (authenticated bits=0) by mail194c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 17GI7E9N029123; Mon, 16 Aug 2021 18:07:16 +0000 In-Reply-To: <83sfz970av.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F1A.611AA954.008D, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=QJQWuTDL c=1 sm=1 tr=0 a=von4qPfY+hyqc0zmWf0tYQ==:117 a=von4qPfY+hyqc0zmWf0tYQ==:17 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=3a_NVP5hYyDUylAqKpgA:9 a=CjuIK1q_8ugA:10 a=mxo5oClUaWORlOBPrwYA:9 a=1OfwrDeanrQA:10 a=nZGyFEsNMesJOn5ZQaYA:9 a=B2y7HmGcmWMA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212053 Archived-At: --Apple-Mail=_2F59ED86-55C6-4DDB-83EB-6BDE5D11FBB0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 16 aug. 2021 kl. 19.43 skrev Eli Zaretskii : >> I don't know how this could ever work. We loop through the markers in = the current buffer? >=20 > Yes. Why do you think this loop is broken? Because unless I misunderstood the code entirely, the current buffer has = nothing to do with the operation at hand. It's easy to reproduce the original problem: run Emacs in a terminal and = make a buffer with many markers. See how the text displays slower with = more markers. I've attached a short example; try (make-test-buffer = 1000). The attached patch fixes this problem. --Apple-Mail=_2F59ED86-55C6-4DDB-83EB-6BDE5D11FBB0 Content-Disposition: attachment; filename=lus.el Content-Type: application/octet-stream; x-unix-mode=0644; name="lus.el" Content-Transfer-Encoding: 7bit ;;; -*- lexical-binding -*- (defvar my-markers nil) (defun make-test-buffer (n) (setq my-markers nil) (with-current-buffer (get-buffer-create "test-buffer") (erase-buffer) (dotimes (i 1000) (insert (format "%8d " i)) (dotimes (_ n) (push (point-marker) my-markers)) (insert "abcdefghijklmnopqrstuvwxyz\n")))) --Apple-Mail=_2F59ED86-55C6-4DDB-83EB-6BDE5D11FBB0 Content-Disposition: attachment; filename=0001-Fix-marker-traversion-in-encode_coding_object.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Fix-marker-traversion-in-encode_coding_object.patch" Content-Transfer-Encoding: quoted-printable =46rom=20d38eace17a24ed2d15a3bf069e1aaf05a495e077=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Mon,=2016=20Aug=202021=2019:57:34=20+0200=0A= Subject:=20[PATCH]=20Fix=20marker=20traversion=20in=20= encode_coding_object=0A=0A*=20src/coding.c=20(encode_coding_object):=20= Only=20traverse=20markers=20if=20we=20are=0Aencoding=20to=20and=20from=20= buffers,=20and=20use=20the=20right=20buffer=20when=20doing=20so.=0A=0A= This=20also=20fixes=20a=20performance=20problem=20when=20running=20in=20= a=20terminal=20and=0Athe=20displayed=20buffer=20has=20many=20markers=20= (bug#49127).=0AReported=20by=20Victor=20Nawothnig.=0A---=0A=20= src/coding.c=20|=204=20++--=0A=201=20file=20changed,=202=20= insertions(+),=202=20deletions(-)=0A=0Adiff=20--git=20a/src/coding.c=20= b/src/coding.c=0Aindex=2087b55aecc0..599ed48b2e=20100644=0A---=20= a/src/coding.c=0A+++=20b/src/coding.c=0A@@=20-8275,11=20+8275,11=20@@=20= encode_coding_object=20(struct=20coding_system=20*coding,=0A=20=0A=20=20=20= attrs=20=3D=20CODING_ID_ATTRS=20(coding->id);=0A=20=0A-=20=20if=20(EQ=20= (src_object,=20dst_object))=0A+=20=20if=20(EQ=20(src_object,=20= dst_object)=20&&=20BUFFERP=20(dst_object))=0A=20=20=20=20=20{=0A=20=20=20= =20=20=20=20struct=20Lisp_Marker=20*tail;=0A=20=0A-=20=20=20=20=20=20for=20= (tail=20=3D=20BUF_MARKERS=20(current_buffer);=20tail;=20tail=20=3D=20= tail->next)=0A+=20=20=20=20=20=20for=20(tail=20=3D=20BUF_MARKERS=20= (XBUFFER=20(dst_object));=20tail;=20tail=20=3D=20tail->next)=0A=20=09{=0A= =20=09=20=20tail->need_adjustment=0A=20=09=20=20=20=20=3D=20= tail->charpos=20=3D=3D=20(tail->insertion_type=20?=20from=20:=20to);=0A= --=20=0A2.21.1=20(Apple=20Git-122.3)=0A=0A= --Apple-Mail=_2F59ED86-55C6-4DDB-83EB-6BDE5D11FBB0--