From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#16993: advice-add hides docstring Date: Wed, 12 Mar 2014 15:55:57 -0400 Message-ID: <3uzjkvxkc2.fsf@fencepost.gnu.org> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1394654220 19613 80.91.229.3 (12 Mar 2014 19:57:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 12 Mar 2014 19:57:00 +0000 (UTC) Cc: 16993@debbugs.gnu.org To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 12 20:57:08 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WNpH1-0000DX-9C for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Mar 2014 20:57:07 +0100 Original-Received: from localhost ([::1]:34491 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNpH0-000851-VO for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Mar 2014 15:57:06 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNpGx-00083a-JS for bug-gnu-emacs@gnu.org; Wed, 12 Mar 2014 15:57:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNpGw-0001Ll-Ls for bug-gnu-emacs@gnu.org; Wed, 12 Mar 2014 15:57:03 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33774) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNpGw-0001Lg-IM for bug-gnu-emacs@gnu.org; Wed, 12 Mar 2014 15:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WNpGv-0002Rx-V7 for bug-gnu-emacs@gnu.org; Wed, 12 Mar 2014 15:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Mar 2014 19:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16993-submit@debbugs.gnu.org id=B16993.13946541619296 (code B ref 16993); Wed, 12 Mar 2014 19:57:01 +0000 Original-Received: (at 16993) by debbugs.gnu.org; 12 Mar 2014 19:56:01 +0000 Original-Received: from localhost ([127.0.0.1]:34955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WNpFx-0002Po-EK for submit@debbugs.gnu.org; Wed, 12 Mar 2014 15:56:01 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:59760) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WNpFu-0002Pf-MU for 16993@debbugs.gnu.org; Wed, 12 Mar 2014 15:55:59 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1WNpFt-0007Hs-Qu; Wed, 12 Mar 2014 15:55:57 -0400 X-Spook: Craig Livingstone INS Adriatic ammunition e-cash CDMA X-Ran: I)j[x|MboFk8w[Eu5S+z\0KnhW>\K&da&=9H^/&E4Cmh8+iv"!N0"7=uZ# X-Hue: cyan X-Attribution: GM In-Reply-To: (Juanma Barranquero's message of "Wed, 12 Mar 2014 20:49:52 +0100") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:86787 Archived-At: Juanma Barranquero wrote: > Aha, I tried with two test functions, one with a key binding in its > doc (\\[universal-argument]) and the other without, and indeed, the > first one gets its advice info's font-locking removed and the other > doesn't. > > I'll try to come with an easy fix, if at all possible, unless you beat > me to it (feel free to ;-) I don't intend to work on it, but IMO substitute-command-keys should preserve text properties. AFAIK, there's no particular reason why it removes them; see e.g. http://lists.gnu.org/archive/html/emacs-pretest-bug/2005-11/msg00094.html > Still, the other problem (docstrings missing) is much more serious. I guess that's something to do with built-in functions. (I don't see an issue with insert-directory.)