* bug#16754: unnecessary requirement of X11 for imagemagick in case of cygwin
[not found] <COL131-W34207AB3320393A57A03F849D0@phx.gbl>
@ 2014-02-14 10:00 ` Mirek Kaim
2014-02-16 3:02 ` Glenn Morris
0 siblings, 1 reply; 6+ messages in thread
From: Mirek Kaim @ 2014-02-14 10:00 UTC (permalink / raw)
To: 16754
i've just compiled the latest version from repo under cygwin. imagemagick installed from cygwin package, with all dependecies - that includes some X-libs, but no X server per se. emacs configured --with-w32. all i did was this:
diff --git a/configure.ac b/configure.ac
index 326d528..bc95daa 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2236,7 +2236,7 @@ if test "${HAVE_X11}" = "yes" || test "${HAVE_NS}" = "yes"
fi
HAVE_IMAGEMAGICK=no
-if test "${HAVE_X11}" = "yes" || test "${HAVE_NS}" = "yes"; then
+#if test "${HAVE_X11}" = "yes" || test "${HAVE_NS}" = "yes"; then
if test "${with_imagemagick}" != "no"; then
## 6.2.8 is the earliest version known to work, but earlier versions
## might work - let us know if you find one.
@@ -2254,7 +2254,7 @@ if test "${HAVE_X11}" = "yes" || test "${HAVE_NS}" = "yes"
AC_CHECK_FUNCS(MagickExportImagePixels MagickMergeImageLayers)
fi
fi
-fi
+#fi
HAVE_GTK=no
and it works, checked with image-dired and pdf page scaling. obviously, imagemagick is independent from the actual gui used by emacs - as long as there is a gui, it makes sense to link with it. shouldn't it be then:
if test "${HAVE_X11}" = "yes" || test "${HAVE_NS}" = "yes" || test "${HAVE_W32}" = "yes"; then
or am i missing something? i'm not too familiar with configure and makefile stuff, and i never submitted a patch so i don't have an account, so feel free to patch that.
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#16754: unnecessary requirement of X11 for imagemagick in case of cygwin
2014-02-14 10:00 ` bug#16754: unnecessary requirement of X11 for imagemagick in case of cygwin Mirek Kaim
@ 2014-02-16 3:02 ` Glenn Morris
2014-02-16 8:26 ` Mirek Kaim
0 siblings, 1 reply; 6+ messages in thread
From: Glenn Morris @ 2014-02-16 3:02 UTC (permalink / raw)
To: Mirek Kaim; +Cc: 16754
Mirek Kaim wrote:
> and it works, checked with image-dired and pdf page scaling.
But image-dired does not use the built-in ImageMagick support, it just
calls the external ImageMagick executables. And DocView may do the same
too.
Anyway, what you say sounds plausible to me, but I have no way to test
it myself.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#16754: unnecessary requirement of X11 for imagemagick in case of cygwin
2014-02-16 3:02 ` Glenn Morris
@ 2014-02-16 8:26 ` Mirek Kaim
2014-02-16 19:33 ` Glenn Morris
0 siblings, 1 reply; 6+ messages in thread
From: Mirek Kaim @ 2014-02-16 8:26 UTC (permalink / raw)
To: Glenn Morris; +Cc: 16754@debbugs.gnu.org
> But image-dired does not use the built-in ImageMagick support, it just
> calls the external ImageMagick executables. And DocView may do the same
> too.
i'm
not sure if doc-view-scale-internally implies imagemagick, but what i
do know is that before recompiling emacs with imagemagick support,
doc-view displayed the pages at the original resolution (depending on
dpi setting, obviously), while afterwards it started using the
doc-view-image-width variable, so my guess is that it works (both builds
were done by me, the only difference was adding imagemagick and dbus
support).
of course i may be wrong, so any way to check if it works is welcome.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#16754: unnecessary requirement of X11 for imagemagick in case of cygwin
2014-02-16 8:26 ` Mirek Kaim
@ 2014-02-16 19:33 ` Glenn Morris
2014-02-17 9:20 ` Mirek Kaim
0 siblings, 1 reply; 6+ messages in thread
From: Glenn Morris @ 2014-02-16 19:33 UTC (permalink / raw)
To: Mirek Kaim; +Cc: 16754@debbugs.gnu.org
I think if you simply visit an image type that Emacs does not otherwise
support, eg .bmp, and check that
i) it displays as an image with "Image[imagemagick]" in the mode line.
ii) M-x image-transform-set-rotation RET 45 RET work.
we'll call that good enough. Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#16754: unnecessary requirement of X11 for imagemagick in case of cygwin
2014-02-16 19:33 ` Glenn Morris
@ 2014-02-17 9:20 ` Mirek Kaim
2014-02-18 1:47 ` Glenn Morris
0 siblings, 1 reply; 6+ messages in thread
From: Mirek Kaim @ 2014-02-17 9:20 UTC (permalink / raw)
To: Glenn Morris; +Cc: 16754@debbugs.gnu.org
> I think if you simply visit an image type that Emacs does not otherwise
> support, eg .bmp, and check that
>
> i) it displays as an image with "Image[imagemagick]" in the mode line.
>
> ii) M-x image-transform-set-rotation RET 45 RET work.
>
> we'll call that good enough. Thanks!
checked with both .bmp and .tga, it works. setting imagemagick render mode to 1 causes emacs to crash though, but default setting of 0 works fine.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#16754: unnecessary requirement of X11 for imagemagick in case of cygwin
2014-02-17 9:20 ` Mirek Kaim
@ 2014-02-18 1:47 ` Glenn Morris
0 siblings, 0 replies; 6+ messages in thread
From: Glenn Morris @ 2014-02-18 1:47 UTC (permalink / raw)
To: 16754-done
Version: 24.4
Thanks; applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-02-18 1:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <COL131-W34207AB3320393A57A03F849D0@phx.gbl>
2014-02-14 10:00 ` bug#16754: unnecessary requirement of X11 for imagemagick in case of cygwin Mirek Kaim
2014-02-16 3:02 ` Glenn Morris
2014-02-16 8:26 ` Mirek Kaim
2014-02-16 19:33 ` Glenn Morris
2014-02-17 9:20 ` Mirek Kaim
2014-02-18 1:47 ` Glenn Morris
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).