From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#8866: 23.3.50; flymake-mode colors warnings as errors Date: Wed, 15 Jun 2011 03:28:17 -0400 Message-ID: <3lwrgny2ni.fsf@fencepost.gnu.org> References: <87fwnc1a26.fsf@sc3d.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1308123467 30609 80.91.229.12 (15 Jun 2011 07:37:47 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 15 Jun 2011 07:37:47 +0000 (UTC) Cc: 8866@debbugs.gnu.org To: Reuben Thomas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 15 09:37:43 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QWkfU-0003zu-2F for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 Jun 2011 09:37:40 +0200 Original-Received: from localhost ([::1]:36807 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QWkfS-0005Bk-NC for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 Jun 2011 03:37:38 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:52700) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QWkXB-0003kF-0s for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2011 03:29:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QWkX9-00039h-HQ for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2011 03:29:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33546) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QWkX9-00039X-6L for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2011 03:29:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QWkX8-0003mh-Rp; Wed, 15 Jun 2011 03:29:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87fwnc1a26.fsf@sc3d.org> Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Jun 2011 07:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8866 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8866-submit@debbugs.gnu.org id=B8866.130812290914485 (code B ref 8866); Wed, 15 Jun 2011 07:29:02 +0000 Original-Received: (at 8866) by debbugs.gnu.org; 15 Jun 2011 07:28:29 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QWkWa-0003lZ-9d for submit@debbugs.gnu.org; Wed, 15 Jun 2011 03:28:28 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QWkWY-0003lO-8A for 8866@debbugs.gnu.org; Wed, 15 Jun 2011 03:28:27 -0400 Original-Received: from localhost ([127.0.0.1]:54296) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QWkWQ-0007Vo-Mq; Wed, 15 Jun 2011 03:28:18 -0400 X-Spook: president brigand EuroFed genetic insurgency New World X-Ran: +}]rS3@#LdEDjN[46m<[L\LV0^SFo[Y2#ca-.yISk-6^GQ*qbKsRB]}DC+%^$Nr:tz=lzJ X-Hue: red X-Attribution: GM User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 15 Jun 2011 03:29:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:47168 Archived-At: Reuben Thomas wrote: > In emacs -Q, I visit a C file, M-x flymake-mode, and introduce a > warning-inducing problem. The background of the line goes pink, which is > the error face, not the warning face. Crystal ball says: You are using gcc 4.5 or later. Your warnings look like: go.c:4:4: warning: 'a' is used uninitialized in this function rather than: go.c:4: warning: 'a' is used uninitialized in this function Ie, they include a column number. Due to the silly way this works, patching the "ant/javac" regexp in flymake.el may fix this: *** lisp/progmodes/flymake.el 2011-01-02 23:50:46 +0000 --- lisp/progmodes/flymake.el 2011-06-15 07:28:54 +0000 *************** *** 918,925 **** ;; PHP ("\\(?:Parse\\|Fatal\\) error: \\(.*\\) in \\(.*\\) on line \\([0-9]+\\)" 2 3 nil 1) ;; LaTeX warnings (fileless) ("\\(LaTeX \\(Warning\\|Error\\): .*\\) on input line \\([0-9]+\\)" 20 3 nil 1) ! ;; ant/javac ! (" *\\(\\[javac\\] *\\)?\\(\\([a-zA-Z]:\\)?[^:(\t\n]+\\)\:\\([0-9]+\\)\:[ \t\n]*\\(.+\\)" 2 4 nil 5)) ;; compilation-error-regexp-alist) (flymake-reformat-err-line-patterns-from-compile-el compilation-error-regexp-alist-alist)) --- 918,925 ---- ;; PHP ("\\(?:Parse\\|Fatal\\) error: \\(.*\\) in \\(.*\\) on line \\([0-9]+\\)" 2 3 nil 1) ;; LaTeX warnings (fileless) ("\\(LaTeX \\(Warning\\|Error\\): .*\\) on input line \\([0-9]+\\)" 20 3 nil 1) ! ;; ant/javac. Note this also matches gcc warnings! ! (" *\\(\\[javac\\] *\\)?\\(\\([a-zA-Z]:\\)?[^:(\t\n]+\\)\:\\([0-9]+\\)\\(?:\:[0-9]+\\)?\:[ \t\n]*\\(.+\\)" 2 4 nil 5)) ;; compilation-error-regexp-alist) (flymake-reformat-err-line-patterns-from-compile-el compilation-error-regexp-alist-alist))