From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Cecilio Pardo Newsgroups: gmane.emacs.bugs Subject: bug#74312: 31.0.50; Cygw32 build break Date: Thu, 14 Nov 2024 11:05:49 +0100 Message-ID: <3f6843ec-3166-493f-a67d-23fa82a17db0@imayhem.com> References: <858qtpkemi.wl--xmue@d1.dion.ne.jp> <86serxkb3x.fsf@gnu.org> <0f292392-7a84-4427-a9ed-9a4dc4014a85@cornell.edu> <86wmh9il65.fsf@gnu.org> <4add61f6-3654-4b9f-913b-ec3a52981aea@cornell.edu> <86jzd8ipxj.fsf@gnu.org> <85y11o1la9.wl--xmue@d1.dion.ne.jp> <86bjykiem2.fsf@gnu.org> <85o72jiels.wl--xmue@d1.dion.ne.jp> <2564f4d1-b58a-4b80-9b6e-acc2e8d2c254@imayhem.com> <85msi3jfh6.wl--xmue@d1.dion.ne.jp> <86serujgrg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4361"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: kzhr@d1.dion.ne.jp, 74312@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 14 11:06:30 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tBWk9-0000yW-WA for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Nov 2024 11:06:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tBWjm-0000Mu-TY; Thu, 14 Nov 2024 05:06:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tBWji-0000Mb-Uz for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2024 05:06:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tBWji-0008LG-Jx for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2024 05:06:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=jo9NxbW0+QA2jhwruQRIfehno8N/zr8YyO0iXSw3zFE=; b=Xxka1TQkO543Y9r2oEZV9hAaZCgRbvNVyKG1v/bWzbtXW1XzKzQWHu1vm2KLeID0cSuBHPlt9OmcbUsCat5+RxY2ZvJMrOt4PinitAXHhfT4cE/EB2W6/cUY1PJaTqZA3bL69KUIraOVrJuzDSELLrzImtKxGsNgwlX527AxW0O3OY2JM8FHzLMg9feu+wZ6a1QanDzlr6wIrjn7rjJvtGNRGfdTscDcoDJBuTxmK55m9d3i/ZXnp2gvMc3DidTu3mmpXz+fE8v7SioR/Cd+G8YOSBxA7desdXfvPetaEXhA+KGidR5LOe4+d41rDnwajYgdjRMbOrozQSJPeqRf+A==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tBWji-0005jb-DU for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2024 05:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Cecilio Pardo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Nov 2024 10:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74312 X-GNU-PR-Package: emacs Original-Received: via spool by 74312-submit@debbugs.gnu.org id=B74312.173157875822029 (code B ref 74312); Thu, 14 Nov 2024 10:06:02 +0000 Original-Received: (at 74312) by debbugs.gnu.org; 14 Nov 2024 10:05:58 +0000 Original-Received: from localhost ([127.0.0.1]:45136 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tBWje-0005jF-9a for submit@debbugs.gnu.org; Thu, 14 Nov 2024 05:05:58 -0500 Original-Received: from mail.imayhem.com ([82.223.54.191]:48821 helo=zealous-pike.82-223-54-191.plesk.page) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tBWjd-0005iw-0u for 74312@debbugs.gnu.org; Thu, 14 Nov 2024 05:05:57 -0500 Original-Received: from [192.168.68.104] (111.red-88-21-7.staticip.rima-tde.net [88.21.7.111]) by zealous-pike.82-223-54-191.plesk.page (Postfix) with ESMTPSA id 30008800CB; Thu, 14 Nov 2024 10:05:51 +0000 (UTC) Authentication-Results: zealous-pike.82-223-54-191.plesk.page; spf=pass (sender IP is 88.21.7.111) smtp.mailfrom=cpardo@imayhem.com smtp.helo=[192.168.68.104] Received-SPF: pass (zealous-pike.82-223-54-191.plesk.page: connection is authenticated) Content-Language: es-ES In-Reply-To: <86serujgrg.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295325 Archived-At: On 14/11/2024 10:39, Eli Zaretskii wrote: >> This should fix the Photo application problem. >> >> I didn't expect ref counting to be needed for this, my bad. > > Thanks. Can you tell more about the root cause of the problem and how > it is solved using reference counting? w32_drop_target as a COM interface should implement reference counting through the methods AddRef and Release. I didn't implement it (AddRef is a noop, Release frees all always) because I didn't expect to receive any AddRef calls besides the one we get when calling RegisterDragDrop. When dragging files from the Photo application, AddRef and Release are called. The application itselt in principle does not have access to the IDropTarget to call this methods. Or maybe I am very wrong here. In any case, I should have implemented AddRef/Release, and my assumption was wrong.