From: "Loïc Lemaître" <loic.lemaitre@gmail.com>
To: Dmitry Gutov <dmitry@gutov.dev>,
67684@debbugs.gnu.org, Yuan Fu <casouri@gmail.com>
Subject: bug#67684: 30.0.50; Font lock rule conflict in js-ts-mode at level 4
Date: Fri, 8 Dec 2023 12:16:24 +0100 [thread overview]
Message-ID: <3f5a923c-f946-4d66-81c8-632daa21544c@gmail.com> (raw)
In-Reply-To: <13417b56-4849-c7a5-9fd3-f1ff7909e9d4@gutov.dev>
Le 08/12/2023 à 02:33, Dmitry Gutov a écrit :
> Hi!
>
> On 07/12/2023 12:07, Loïc Lemaître wrote:
>> I have noticed a font coloration issue in js-ts-mode when setting the
>> treesit font lock level to 4: JSX attributes color is not the same
>> than at level 3.
>> There should have a conflict between rules for "property_identifier"
>> treesit type. The feature that triggers the conflict is "property"
>> (of the level 4).
>>
>> You can reproduce the issue by following these steps:
>> - M-: (setq treesit-font-lock-level 4)
>> - M-x js-ts-mode on a JSX buffer
>>
>> Note that the bug already exists in Emacs 29.1.
>
> The attached patch seems to fix that.
Yes I confirm, thanks !
>
> But it removes a function added by Yuan in e78e69b33189, while
> reshuffling the highlights to reorder priorities.
>
> Yuan, do you remember why you did it that way back then? Perhaps I'm
> missing some other conflict.
next prev parent reply other threads:[~2023-12-08 11:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 10:07 bug#67684: 30.0.50; Font lock rule conflict in js-ts-mode at level 4 Loïc Lemaître
2023-12-08 1:33 ` Dmitry Gutov
2023-12-08 11:16 ` Loïc Lemaître [this message]
2023-12-11 1:37 ` Yuan Fu
2023-12-11 16:35 ` Dmitry Gutov
2023-12-12 8:33 ` Yuan Fu
2023-12-12 22:02 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f5a923c-f946-4d66-81c8-632daa21544c@gmail.com \
--to=loic.lemaitre@gmail.com \
--cc=67684@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=dmitry@gutov.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).