bug#5146: Malayalam conjuncts are not formed inside 'call editor' buffer of po-mode

bug#5146: Malayalam conjuncts are not formed inside 'call editor' buffer of po-mode

[Praveen A]

[-- Attachment #1: Type: text/plain, Size: 829 bytes --]

Hi,

While in po-mode, editor is called by pressing enter when cursor is in
msgstr. Though conjuncts are formed in the main editor window, the pop
up 'Call Editor' window does not form conjuncts. Attached screen shot
shows difference between the two renderings.

http://websvn.kde.org/*checkout*/trunk/l10n-kde4/ml/messages/kdebase/plasma_applet_clock.po
can be used for testing this. Move cursor to any msgstr line and press
enter. Compare rendering in the main editor window and new pop up
window.

Thanks
Praveen

-- 
പ്രവീണ്‍ അരിമ്പ്രത്തൊടിയില്‍
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)
Join The DRM Elimination Crew Now!
http://fci.wikia.com/wiki/Anti-DRM-Campaign

[-- Attachment #2: emacs-po-mode-call-editor.png --]
[-- Type: image/png, Size: 111243 bytes --]

bug#5146: Malayalam conjuncts are not formed inside 'call editor' buffer of po-mode

[Kenichi Handa]

In article <3f2beab60912070854v3b818613ka526cd42f2617ac9@mail.gmail.com>, Praveen A <pravi.a@gmail.com> writes:

> While in po-mode, editor is called by pressing enter when cursor is in
> msgstr. Though conjuncts are formed in the main editor window, the pop
> up 'Call Editor' window does not form conjuncts. Attached screen shot
> shows difference between the two renderings.

> http://websvn.kde.org/*checkout*/trunk/l10n-kde4/ml/messages/kdebase/plasma=
> _applet_clock.po
> can be used for testing this. Move cursor to any msgstr line and press
> enter. Compare rendering in the main editor window and new pop up
> window.

It seems that in the editor buffer, auto-composition-mode is
turned off.  Perhaps that's because the buffer is in
fundamental mode.  This will fix that problem.

(add-hook 'po-subedit-mode-hook 'text-mode)

By the way, I don't know why auto-composition-mode is not
turned on in that buffer even if
global-auto-composition-mode is on.  I'll file another bug
report.

---
Kenichi Handa
handa@m17n.org

bug#5146: Malayalam conjuncts are not formed inside 'call editor' buffer of po-mode

[Praveen A]

2009/12/8 Kenichi Handa <handa@m17n.org>:
> It seems that in the editor buffer, auto-composition-mode is
> turned off.  Perhaps that's because the buffer is in
> fundamental mode.  This will fix that problem.
>
> (add-hook 'po-subedit-mode-hook 'text-mode)
>
> By the way, I don't know why auto-composition-mode is not
> turned on in that buffer even if
> global-auto-composition-mode is on.  I'll file another bug
> report.

But after turning this on, C-C C-c or C-C C-k to exit from this buffer
is not working :-(

- Praveen
-- 
പ്രവീണ്‍ അരിമ്പ്രത്തൊടിയില്‍
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)
Join The DRM Elimination Crew Now!
http://fci.wikia.com/wiki/Anti-DRM-Campaign

bug#5146: Malayalam conjuncts are not formed inside 'call editor' buffer of po-mode

[Kenichi Handa]

In article <3f2beab60912072322l5b812e06nfc184e7aaec500da@mail.gmail.com>, Praveen A <pravi.a@gmail.com> writes:

> 2009/12/8 Kenichi Handa <handa@m17n.org>:
> > It seems that in the editor buffer, auto-composition-mode is
> > turned off.  Perhaps that's because the buffer is in
> > fundamental mode.  This will fix that problem.
> >
> > (add-hook 'po-subedit-mode-hook 'text-mode)
> >
> > By the way, I don't know why auto-composition-mode is not
> > turned on in that buffer even if
> > global-auto-composition-mode is on.  I'll file another bug
> > report.

> But after turning this on, C-C C-c or C-C C-k to exit from this buffer
> is not working :-(

Ah! Ummm, how about this instead.

(add-hook 'po-subedit-mode-hook 'auto-composition-mode)

---
Kenichi Handa
handa@m17n.org

bug#5146: Malayalam conjuncts are not formed inside 'call editor' buffer of po-mode

[Praveen A]

2009/12/8 Kenichi Handa <handa@m17n.org>:
> Ah! Ummm, how about this instead.
>
> (add-hook 'po-subedit-mode-hook 'auto-composition-mode)

It is working now. It feels really great to see your quick response to
every issue we report. Thanks for your amazing work.

- Praveen
-- 
പ്രവീണ്‍ അരിമ്പ്രത്തൊടിയില്‍
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)
Join The DRM Elimination Crew Now!
http://fci.wikia.com/wiki/Anti-DRM-Campaign

bug#5146: Malayalam conjuncts are not formed inside 'call editor' buffer of po-mode

[Kenichi Handa]

In article <3f2beab60912080037u4c5b0442pb520b6ac479a7f4d@mail.gmail.com>, Praveen A <pravi.a@gmail.com> writes:

> 2009/12/8 Kenichi Handa <handa@m17n.org>:
> > Ah! Ummm, how about this instead.
> >
> > (add-hook 'po-subedit-mode-hook 'auto-composition-mode)

> It is working now. 

That's good.  But it is better to use this code instead:

(add-hook 'po-subedit-mode-hook '(lambda () (auto-composition-mode 1)))

because when the bug#4887:
  http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4887
is fixed, the first code may turns off auto-composition-mode.

> It feels really great to see your quick response to every
> issue we report. Thanks for your amazing work.

I too appreciate your cooperation to find the cause of the
rendering bug.

But, it seems that we reach a dead end (as for the case of
"meera" font) at the moment unless we find what is different
in your environment and mine, what is going on in your
Emacs' redisplay code.  I'll consider what I should ask you
to do to find them.

By the way, what input method are you using in the session
video you captured?

---
Kenichi Handa
handa@m17n.org

bug#5146: Malayalam conjuncts are not formed inside 'call editor' buffer of po-mode

[Praveen A]

2009/12/8 Kenichi Handa <handa@m17n.org>:
> That's good.  But it is better to use this code instead:
>
> (add-hook 'po-subedit-mode-hook '(lambda () (auto-composition-mode 1)))

OK. I changed it.

> But, it seems that we reach a dead end (as for the case of
> "meera" font) at the moment unless we find what is different
> in your environment and mine, what is going on in your
> Emacs' redisplay code.  I'll consider what I should ask you
> to do to find them.

Could that be any change is compilation options? something to do with
the toolkit? I could see the same issue in other machines too (Fedora
and Debian).

Are you using a distribution packaged version of emacs? If not, what
are the options passed to configure script?

> By the way, what input method are you using in the session
> video you captured?

I was using xkb, but the same issues happens with scim also.

-- 
പ്രവീണ്‍ അരിമ്പ്രത്തൊടിയില്‍
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)
Join The DRM Elimination Crew Now!
http://fci.wikia.com/wiki/Anti-DRM-Campaign

bug#5146: Malayalam conjuncts are not formed inside 'call editor' buffer of po-mode

[Kenichi Handa]

In article <3f2beab60912080522t36d20578h17c74c4f7b884a59@mail.gmail.com>, Praveen A <pravi.a@gmail.com> writes:

> > But, it seems that we reach a dead end (as for the case of
> > "meera" font) at the moment unless we find what is different
> > in your environment and mine, what is going on in your
> > Emacs' redisplay code.  I'll consider what I should ask you
> > to do to find them.

> Could that be any change is compilation options? something to do with
> the toolkit? I could see the same issue in other machines too (Fedora
> and Debian).

> Are you using a distribution packaged version of emacs? If not, what
> are the options passed to configure script?

I also tried with a newly installed Fedora 12.  Emacs,
m17n-lib, m17n-db, and libotf are what included in the
distribution.  The meera font is this:

/usr/share/fonts/smc/Meera_04.ttf

Do other people see the same rendering bug?  How about you, Parag?

---
Kenichi Handa
handa@m17n.org

bug#5146: Malayalam conjuncts are not formed inside 'call editor' buffer of po-mode

[Praveen A]

2009/12/9 Kenichi Handa <handa@m17n.org>:
> I also tried with a newly installed Fedora 12.  Emacs,
> m17n-lib, m17n-db, and libotf are what included in the
> distribution.  The meera font is this:
>
> /usr/share/fonts/smc/Meera_04.ttf
>
> Do other people see the same rendering bug?  How about you, Parag?

I had a chat with Parag and he suggested to test with other locales.
But the same error happens in all locales. We tested the bug case on
Parag's machine and was able to reproduce the same error.

Please comment out all "(set-fontset-font" directives from .emacs and
select "Set Default Font" from menu and choose Meera. Even the whole
editable window shrinks.

- Praveen
-- 
പ്രവീണ്‍ അരിമ്പ്രത്തൊടിയില്‍
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)
Join The DRM Elimination Crew Now!
http://fci.wikia.com/wiki/Anti-DRM-Campaign

bug#5146: Malayalam conjuncts are not formed inside 'call editor' buffer of po-mode

[Kenichi Handa]

In article <3f2beab60912090113s4cd124d8v67056717d88993d5@mail.gmail.com>, Praveen A <pravi.a@gmail.com> writes:

> Please comment out all "(set-fontset-font" directives from .emacs and
> select "Set Default Font" from menu and choose Meera. Even the whole
> editable window shrinks.

It didn't change the situation, but I finally could
reproduce strange rendering by installing the latest Emacs
on Fedora 12 and using it to display that sample file
~/temp.txt in meera font!

I've just started to debug this problme.  Please wait for a
while.

---
Kenichi Handa
handa@m17n.org

bug#5146: Malayalam conjuncts are not formed inside 'call editor' buffer of po-mode

[Praveen A]

2009/12/10 Kenichi Handa <handa@m17n.org>:
> It didn't change the situation, but I finally could
> reproduce strange rendering by installing the latest Emacs
> on Fedora 12 and using it to display that sample file
> ~/temp.txt in meera font!

Good to see you are able to reproduce the problem after many iterations.

> I've just started to debug this problme.  Please wait for a
> while.

Thanks. I'll wait.

- Praveen
-- 
പ്രവീണ്‍ അരിമ്പ്രത്തൊടിയില്‍
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)
Join The DRM Elimination Crew Now!
http://fci.wikia.com/wiki/Anti-DRM-Campaign

bug#5146: Malayalam conjuncts are not formed inside 'call editor' buffer of po-mode

[Kenichi Handa]

In article <3f2beab60912100212s3c4bd755le8e16ac393c36bee@mail.gmail.com>, Praveen A <pravi.a@gmail.com> writes:

> > I've just started to debug this problme.  Please wait for a
> > while.

> Thanks. I'll wait.

I found the source of the problem.  Fedora 12 has this font
configuration in /etc/fonts/conf.d/90-smc-fonts.conf:

<!-- multiply the matrix of Meera font for solving size mismatch with Rachana-->
<match target="font">
	<test name="family">
		<string>Meera</string>
	</test>
	<edit name="matrix" mode="assign">
			<name>matrix</name>
			<matrix>
				<double>1.2</double><double>0</double>
				<double>0</double><double>1.2</double>
			</matrix>
	</edit>
</match>

When I cancel that effect by having this in my
~/.fonts.conf:

<match target="font">
	<test name="family">
		<string>Meera</string>
	</test>
	<edit name="matrix" mode="assign">
			<name>matrix</name>
			<matrix>
				<double>1</double><double>0</double>
				<double>0</double><double>1</double>
			</matrix>
	</edit>
</match>

the rendering problem disappears except for that a little
bit smaller glyphs are shown compared with the case when you
use the other fonts (e.g. rachana).  How about you?

---
Kenichi Handa
handa@m17n.org

bug#5146: Malayalam conjuncts are not formed inside 'call editor' buffer of po-mode

[Praveen A]

2009/12/10 Kenichi Handa <handa@m17n.org>:
> the rendering problem disappears except for that a little
> bit smaller glyphs are shown compared with the case when you
> use the other fonts (e.g. rachana).  How about you?

Meera has a different Ascent and Descent values compared to other
fonts. Meera has ascent and descent as 1147, 901. Rachana has it as
1638, 410. This is to accommodate the characteristics of Malayalam
script. And this change results in smaller sizes compared to other
fonts. The fontconfig rule was added to offset small size for Meera
compared to other fonts.

Pango/GTK applications understand the scaling directives and scales up
Meera font properly. The ideal solution is to have m17n/emacs
implement fontconfig scaling feature.

Thanks
Praveen

-- 
പ്രവീണ്‍ അരിമ്പ്രത്തൊടിയില്‍
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)
Join The DRM Elimination Crew Now!
http://fci.wikia.com/wiki/Anti-DRM-Campaign

bug#5146: Malayalam conjuncts are not formed inside 'call editor' buffer of po-mode

[Kenichi Handa]

In article <3f2beab60912100338p1cc7bbc1xc7fc321bc8722837@mail.gmail.com>, Praveen A <pravi.a@gmail.com> writes:

> 2009/12/10 Kenichi Handa <handa@m17n.org>:
> > the rendering problem disappears except for that a little
> > bit smaller glyphs are shown compared with the case when you
> > use the other fonts (e.g. rachana).  How about you?

> Meera has a different Ascent and Descent values compared to other
> fonts. Meera has ascent and descent as 1147, 901. Rachana has it as
> 1638, 410. This is to accommodate the characteristics of Malayalam
> script. And this change results in smaller sizes compared to other
> fonts. The fontconfig rule was added to offset small size for Meera
> compared to other fonts.

Hmmm, I think there should be some consensus among Malayalam
font developpers as for this matter.

> Pango/GTK applications understand the scaling directives and scales up
> Meera font properly. The ideal solution is to have m17n/emacs
> implement fontconfig scaling feature.

I've just installed a fix.  I also fixed the regular
expression of Malayalam characters in
composition-function-table to fix another bug.  I'll fix 
regular expressions for the other Indic characters soon.

Please try with the latest CVS code.

---
Kenichi Handa
handa@m17n.org

bug#5146: Malayalam conjuncts are not formed inside 'call editor' buffer of po-mode

[Praveen A]

2009/12/12 Kenichi Handa <handa@m17n.org>:
> Hmmm, I think there should be some consensus among Malayalam
> font developpers as for this matter.

Most other fonts for Malayalam just followed what was common with
latin script fonts, but Meera was an effort to find the correct ascent
and descent for Malayalam. If we gets to fix the small size issue in
all apps, then following what Meera did for new fonts would be a good
thing.

> I've just installed a fix.  I also fixed the regular
> expression of Malayalam characters in
> composition-function-table to fix another bug.  I'll fix
> regular expressions for the other Indic characters soon.

Thanks.

> Please try with the latest CVS code.

Right now I'm checking out the code. I will tell you how it goes. Thanks again.

Praveen

-- 
പ്രവീണ്‍ അരിമ്പ്രത്തൊടിയില്‍
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)
Join The DRM Elimination Crew Now!
http://fci.wikia.com/wiki/Anti-DRM-Campaign

bug#5146: Malayalam conjuncts are not formed inside 'call editor' buffer of po-mode

[Praveen A]

2009/12/12 Praveen A <pravi.a@gmail.com>:
> Right now I'm checking out the code. I will tell you how it goes. Thanks again.

This bug is gone now. Display is coming correctly with Meera font.

- Praveen
-- 
പ്രവീണ്‍ അരിമ്പ്രത്തൊടിയില്‍
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)
Join The DRM Elimination Crew Now!
http://fci.wikia.com/wiki/Anti-DRM-Campaign