From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list Date: Fri, 3 Feb 2023 19:10:47 +0200 Message-ID: <3f14adfd-8aef-9352-4c9a-fff71f4223fb@yandex.ru> References: <837cwzw8j1.fsf@gnu.org> <1b8044bd-6855-fdc7-697d-70322a8349c0@yandex.ru> <83k00zuejn.fsf@gnu.org> <83fsbmvj5x.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39809"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: 61205@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no, dev@rjt.dev To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 03 18:11:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pNzaj-000AGQ-Hq for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Feb 2023 18:11:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pNzaZ-0004XN-W2; Fri, 03 Feb 2023 12:11:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNzaY-0004X3-S1 for bug-gnu-emacs@gnu.org; Fri, 03 Feb 2023 12:11:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pNzaY-0001lN-Jv for bug-gnu-emacs@gnu.org; Fri, 03 Feb 2023 12:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pNzaY-0005jY-Bj for bug-gnu-emacs@gnu.org; Fri, 03 Feb 2023 12:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Feb 2023 17:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61205 X-GNU-PR-Package: emacs Original-Received: via spool by 61205-submit@debbugs.gnu.org id=B61205.167544426022032 (code B ref 61205); Fri, 03 Feb 2023 17:11:02 +0000 Original-Received: (at 61205) by debbugs.gnu.org; 3 Feb 2023 17:11:00 +0000 Original-Received: from localhost ([127.0.0.1]:39870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNzaV-0005jI-R9 for submit@debbugs.gnu.org; Fri, 03 Feb 2023 12:11:00 -0500 Original-Received: from mail-ed1-f54.google.com ([209.85.208.54]:40613) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNzaR-0005j1-Da for 61205@debbugs.gnu.org; Fri, 03 Feb 2023 12:10:58 -0500 Original-Received: by mail-ed1-f54.google.com with SMTP id fi26so5820545edb.7 for <61205@debbugs.gnu.org>; Fri, 03 Feb 2023 09:10:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=wwhYNH3eGG3n9dAcXSBZVg92TJO1no2czWs+iedJhS4=; b=R//PfOGj2HyWTeMj5eyc+wkJZedQbUAKb6I+r6NSWoLF9pdlOwMMwYRW6qq1lC+sfr uzrJbCczEdllCafAwfYhsIBHqms0xD/xedKxygu/wtTdshP/uQb4+82OEQqM3zlLvaZE em+NHwf7yvvA9e544TecH3FsXoF9zXmRf1Aj/UrMP7PQKek+tbFoIYmvUbASpMkKtf24 hdqjPOrpgmBvisxgqmmH8xIN9FnFxBU4tkQHF6NLLyeYOk10iS9n5RqWOyN0G+LcAT5F 3fzLAFjVrEtyu15aHERCzJEWREQoQe9npj0pSrQ3IuUJce4ggMNsONwsZgQVWFEDISaI FToQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wwhYNH3eGG3n9dAcXSBZVg92TJO1no2czWs+iedJhS4=; b=oTPvLNMvFS7o9DQVeeudSa0yzKjMQtMuhswZkFDKyEbpGYUg1fFSr8YF5OeMrH84+o N7lo22YW4aNQh0UZExB9t/IaoICBx69+HFvlq5lPDCyO0GekvCAmY8WLQ+ZxBohTaAYa hoLn5SxUhqAzaouNFhhm6QYldjJdvsqMcCmfiR0pV2OblUbLmBGgYWKXiaX8GDWdQZ7Q 4W67+XtSEhAUzKq5qxciAWWToACCWynG07iricxt8HfRt72hIIO8U7XB6AeOGmKqYnOR 722h9XTaXxz1W2pigDZ0H7OrbbzvrIVPXsVF4suvCmFVOEKQGt1tLhX1Ba1l9H2FSHx3 qAIg== X-Gm-Message-State: AO0yUKUpG4j0j02Jvrm+UcjVB9oRAE/u28c6uS0VkdUj1m9FcSbcojCX wKRlDoDE78IbxpTFYSr402U= X-Google-Smtp-Source: AK7set9BdPRMnzme55gJekyYlzkZUaYvXUmPkjMgF3xvGa0omKrlu00oj3SIEhlnKHx+LFJZRlbIYw== X-Received: by 2002:a05:6402:3603:b0:4a0:e237:2cef with SMTP id el3-20020a056402360300b004a0e2372cefmr11675884edb.4.1675444249510; Fri, 03 Feb 2023 09:10:49 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id m10-20020a056402430a00b0048eb0886b00sm1407137edc.42.2023.02.03.09.10.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Feb 2023 09:10:48 -0800 (PST) Content-Language: en-US In-Reply-To: <83fsbmvj5x.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254738 Archived-At: On 03/02/2023 17:54, Eli Zaretskii wrote: >> Date: Fri, 3 Feb 2023 17:15:05 +0200 >> Cc:61205@debbugs.gnu.org,casouri@gmail.com,theo@thornhill.no,dev@rjt.dev >> From: Dmitry Gutov >> >>> Then as far as I'm concerned, this can go to level 4, but it must be >>> done consistently across all the *-ts modes. So if some mode wants >>> 'property' to be highlighted, and wants it badly, we should IMO keep >>> it in C as well. >> Consistency is what I'm after here. >> >> c-ts-mode, as well as go-ts-mode, rust-ts-mode and typescript-ts-mode, >> all previously mentioned in this report, currently put it at 3. >> >> The rest put it as 4, or don't use it at all. > The question is: how important is this for go-ts-mode, rust-ts-mode, > and typescript-ts-mode? I don't know the answer. If the importance > is not high, then this should be moved to level 4. Right. They don't seem to be particularly more important there than in other modes. Or than 'function', for example.