From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#45474: Icomplete exhibiting in recursive minibuffer when it =?UTF-8?Q?shouldn=E2=80=99t?= Date: Thu, 15 Apr 2021 17:40:04 +0000 Message-ID: <3ed97a9c53e0a5d4fef8@heytings.org> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="ptn44ZzFnc" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11711"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 45474@debbugs.gnu.org To: Dario Gjorgjevski Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 15 19:41:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lX5zY-0002t2-05 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Apr 2021 19:41:24 +0200 Original-Received: from localhost ([::1]:37608 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lX5zX-0007C6-1f for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Apr 2021 13:41:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36456) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lX5zC-0007Ba-Im for bug-gnu-emacs@gnu.org; Thu, 15 Apr 2021 13:41:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55818) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lX5zC-00037X-BR for bug-gnu-emacs@gnu.org; Thu, 15 Apr 2021 13:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lX5zC-0007di-8J for bug-gnu-emacs@gnu.org; Thu, 15 Apr 2021 13:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Apr 2021 17:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45474 X-GNU-PR-Package: emacs Original-Received: via spool by 45474-submit@debbugs.gnu.org id=B45474.161850840929290 (code B ref 45474); Thu, 15 Apr 2021 17:41:02 +0000 Original-Received: (at 45474) by debbugs.gnu.org; 15 Apr 2021 17:40:09 +0000 Original-Received: from localhost ([127.0.0.1]:39131 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lX5yK-0007cM-Ut for submit@debbugs.gnu.org; Thu, 15 Apr 2021 13:40:09 -0400 Original-Received: from heytings.org ([95.142.160.155]:39528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lX5yI-0007cA-Ct for 45474@debbugs.gnu.org; Thu, 15 Apr 2021 13:40:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1618508404; bh=cVc22/ecZkT0OPOQPa4rgMPBLvtNGhOy1Tf/kc7CCuw=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=jkVG1SIdeSD9rlZLZjFCuPNi8la0Ql1ZjS8SgSCttNmg17oVLhY5wMvknSMQN3iw+ y6Wkul1QwZ8vmYdfnXsKyEp5OJYH+gmG/mFySWd5fHMrt08VezOBTh/j7YCytHWvEe LVJabQTSOVHDRuDTr9jH/j1NEX0HxUIOh9P23aq1lQD0UAsVo3+t2/cFEaJjSbRs88 zL8m9Rtx9pin7cRvSMbe+uqKJTiTIHNgqWLonppm5yl4E7vJ47ZTqoLBxSwaFQP8Kc FweQ9VV2IV2LgX+b8pAv37gwh35JfvL7nz7DGSgbbuisjHrI+Lmt6ClaxvNuN6NxS2 rJFLp0+nQWwoA== In-Reply-To: Content-ID: <3ed97a9c53fe1e78d085@heytings.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204089 Archived-At: --ptn44ZzFnc Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-ID: <3ed97a9c53f48211d4fd@heytings.org> > > How to reproduce from emacs -Q: > > (setq enable-recursive-minibuffers t) > (setq icomplete-show-matches-on-no-input t) > M-x icomplete-mode RET > C-x C-f > [Icomplete now exhibits some filenames in the minibuffer] > M-: > [Icomplete shouldn=E2=80=99t exhibit anything here but it still > exhibits the filenames from the previous step and even > allows you to complete them with C-j] > > You can replace C-x C-f with other similar commands, e.g., C-x b or M-x.= =20 > I=E2=80=99m not sure if this bug comes from how Icomplete configures itse= lf or=20 > the implementation of recursive minibuffers. It appears that=20 > icomplete-simple-completing-p returns t when the M-: is happening in a=20 > recursive minibuffer, even though it should return nil so that Icomplete= =20 > doesn=E2=80=99t configure itself. > > If the M-: is not in a recursive minibuffer, everything is OK since=20 > icomplete-simple-completing-p returns nil. > Indeed; patch attached. Ideally this should be done inside=20 icomplete-minibuffer-setup, but if we did this (by checking=20 minibuffer-completing-symbol), it would prevent icomplete-mode from being= =20 active in the opposite situation: M-: followed by C-x C-f. --ptn44ZzFnc Content-Type: text/x-diff; name=Disable-icomplete-mode-when-reading-an-Emacs-Lisp-ex.patch Content-Transfer-Encoding: base64 Content-ID: <3ed97a9c53dc7ca3c6c5@heytings.org> Content-Description: Content-Disposition: attachment; filename=Disable-icomplete-mode-when-reading-an-Emacs-Lisp-ex.patch RnJvbSBlNGNiMDcyNzY3MjQ0ODZiZjAxODc1YzI0NjNkZWJmODE3ODRkNTlm IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogR3JlZ29yeSBIZXl0 aW5ncyA8Z3JlZ29yeUBoZXl0aW5ncy5vcmc+DQpEYXRlOiBUaHUsIDE1IEFw ciAyMDIxIDE3OjMzOjM3ICswMDAwDQpTdWJqZWN0OiBbUEFUQ0hdIERpc2Fi bGUgaWNvbXBsZXRlLW1vZGUgd2hlbiByZWFkaW5nIGFuIEVtYWNzIExpc3Ag ZXhwcmVzc2lvbg0KDQoqIGxpc3Avc2ltcGxlLmVsIChyZWFkLS1leHByZXNz aW9uKTogRGlzYWJsZSBpY29tcGxldGUtbW9kZSB3aGVuDQplbnRlcmluZyBh IHJlY3Vyc2l2ZSBtaW5pYnVmZmVyIHRvIHJlYWQgYW4gRW1hY3MgTGlzcCBl eHByZXNzaW9uDQooYnVnIzQ1NDc0KS4NCi0tLQ0KIGxpc3Avc2ltcGxlLmVs IHwgNCArKystDQogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwg MSBkZWxldGlvbigtKQ0KDQpkaWZmIC0tZ2l0IGEvbGlzcC9zaW1wbGUuZWwg Yi9saXNwL3NpbXBsZS5lbA0KaW5kZXggOTk5NzU1YTY0Mi4uOGY5ZDdhMTk3 YyAxMDA2NDQNCi0tLSBhL2xpc3Avc2ltcGxlLmVsDQorKysgYi9saXNwL3Np bXBsZS5lbA0KQEAgLTE3NTQsNyArMTc1NCw5IEBAIHJlYWQtLWV4cHJlc3Np b24NCiAgICAgICAgICAgKHNldC1zeW50YXgtdGFibGUgZW1hY3MtbGlzcC1t b2RlLXN5bnRheC10YWJsZSkNCiAgICAgICAgICAgKGFkZC1ob29rICdjb21w bGV0aW9uLWF0LXBvaW50LWZ1bmN0aW9ucw0KICAgICAgICAgICAgICAgICAg ICAgIydlbGlzcC1jb21wbGV0aW9uLWF0LXBvaW50IG5pbCB0KQ0KLSAgICAg ICAgICAocnVuLWhvb2tzICdldmFsLWV4cHJlc3Npb24tbWluaWJ1ZmZlci1z ZXR1cC1ob29rKSkNCisgICAgICAgICAgKHJ1bi1ob29rcyAnZXZhbC1leHBy ZXNzaW9uLW1pbmlidWZmZXItc2V0dXAtaG9vaykNCisgICAgICAgICAgOzsg aWYgd2UgZW50ZXIgYSByZWN1cnNpdmUgbWluaWJ1ZmZlciwgZGlzYWJsZSBp Y29tcGxldGUgKGJ1ZyM0NTQ3NCkNCisgICAgICAgICAgKHNldHEtbG9jYWwg aWNvbXBsZXRlLW1vZGUgbmlsKSkNCiAgICAgICAocmVhZC1mcm9tLW1pbmli dWZmZXIgcHJvbXB0IGluaXRpYWwtY29udGVudHMNCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgcmVhZC1leHByZXNzaW9uLW1hcCB0DQogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICdyZWFkLWV4cHJlc3Npb24taGlzdG9y eSkpKSkNCi0tIA0KMi4zMC4yDQoNCg== --ptn44ZzFnc--