From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#45474: Icomplete exhibiting in recursive minibuffer when it =?UTF-8?Q?shouldn=E2=80=99t?= Date: Thu, 15 Apr 2021 22:34:11 +0000 Message-ID: <3ed97a9c530093aca93d@heytings.org> References: <3ed97a9c53e0a5d4fef8@heytings.org> <87fszrz21d.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="RZ51XikxYj" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12239"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dario Gjorgjevski , 45474@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 16 00:39:45 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lXAeG-00035K-PG for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 16 Apr 2021 00:39:45 +0200 Original-Received: from localhost ([::1]:54690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lXAeF-0000Cs-D9 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Apr 2021 18:39:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53828) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXAZi-0004mS-LH for bug-gnu-emacs@gnu.org; Thu, 15 Apr 2021 18:35:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56175) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lXAZi-0002l4-DL for bug-gnu-emacs@gnu.org; Thu, 15 Apr 2021 18:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lXAZi-0004Hp-BZ for bug-gnu-emacs@gnu.org; Thu, 15 Apr 2021 18:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Apr 2021 22:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45474 X-GNU-PR-Package: emacs Original-Received: via spool by 45474-submit@debbugs.gnu.org id=B45474.161852605516421 (code B ref 45474); Thu, 15 Apr 2021 22:35:02 +0000 Original-Received: (at 45474) by debbugs.gnu.org; 15 Apr 2021 22:34:15 +0000 Original-Received: from localhost ([127.0.0.1]:39488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXAYx-0004Gm-0d for submit@debbugs.gnu.org; Thu, 15 Apr 2021 18:34:15 -0400 Original-Received: from heytings.org ([95.142.160.155]:39788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXAYv-0004Ge-80 for 45474@debbugs.gnu.org; Thu, 15 Apr 2021 18:34:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1618526051; bh=gMLyagWmiBzg2tWET+ue8OZsp6IZ9KZEKQiLIhmb+bA=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=JfBw2fTDIJx7L+wrXPiP8KyDbfTlNl7DDnOKPXyjRA5YP08AD5z+hGQXJ7YUvniIk iPt96K94zGNu+FzuYJMWacZTwFT4mxaf9dRFg7/tyHtXX1GD50a70vgVh0IZG+5Sky mzA4oF3y3KaZ4ZvEOSRKLwSn5zS2Ktv7ApcGBhZFhooUowiHgMVBj8Ult/kIYTsd07 kpnI8Y1FHxakbHEUkpI07rA73xOfF9LnFiSD/RhB0eN5q2NKlJuv8m7FGaNhLjWD8R h7Z4s1gYAl0dmdL9IHNcM35cDqyJYq9l6kgf4mjGp2uQOgUrexheZmJi0LthkzRNrb sdZubfRmMIp0g== In-Reply-To: <87fszrz21d.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204103 Archived-At: --RZ51XikxYj Content-Type: text/plain; charset=us-ascii; format=flowed >>> If the M-: is not in a recursive minibuffer, everything is OK since >>> icomplete-simple-completing-p returns nil. >> >> Indeed; patch attached. Ideally this should be done inside >> icomplete-minibuffer-setup, but if we did this (by checking >> minibuffer-completing-symbol), it would prevent icomplete-mode from >> being active in the opposite situation: M-: followed by C-x C-f. >> >> @@ -1754,7 +1754,9 @@ read--expression >> (set-syntax-table emacs-lisp-mode-syntax-table) >> (add-hook 'completion-at-point-functions >> #'elisp-completion-at-point nil t) >> - (run-hooks 'eval-expression-minibuffer-setup-hook)) >> + (run-hooks 'eval-expression-minibuffer-setup-hook) >> + ;; if we enter a recursive minibuffer, disable icomplete (bug#45474) >> + (setq-local icomplete-mode nil)) > > Is this really specific only to read--expression? I can reproduce the > same issue with any command that doesn't use completion, e.g. C-x C-f > C-x f. > Indeed, but the bug report was only about read-expression. It's far more annoying to see completion candidates when you want to type a complete expression than when you just have to enter a short argument. Anyway, given that you asked for it, here's a more general solution. I did not check all places where read-from-minibuffer is used, but adapting them is straightforward. --RZ51XikxYj Content-Type: text/x-diff; name=Make-it-possible-to-disable-icomplete-mode-in-recurs.patch Content-Transfer-Encoding: base64 Content-ID: <3ed97a9c53d7b5f7e5cb@heytings.org> Content-Description: Content-Disposition: attachment; filename=Make-it-possible-to-disable-icomplete-mode-in-recurs.patch RnJvbSA3ZmMzOGYyYTY2ZjU1NDVjMjc2ODM2ZDYyYTdlM2E4NjY5YzNlYjEw IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogR3JlZ29yeSBIZXl0 aW5ncyA8Z3JlZ29yeUBoZXl0aW5ncy5vcmc+DQpEYXRlOiBUaHUsIDE1IEFw ciAyMDIxIDIyOjI3OjA4ICswMDAwDQpTdWJqZWN0OiBbUEFUQ0hdIE1ha2Ug aXQgcG9zc2libGUgdG8gZGlzYWJsZSBpY29tcGxldGUtbW9kZSBpbiByZWN1 cnNpdmUNCiBtaW5pYnVmZmVycw0KDQoqIGxpc3AvaWNvbXBsZXRlLmVsICht aW5pYnVmZmVyLWRpc2FibGUtaWNvbXBsZXRlLW1vZGUpOiBOZXcgaW50ZXJu YWwNCnZhcmlhYmxlLg0KKGljb21wbGV0ZS1taW5pYnVmZmVyLXNldHVwKTog RGlzYWJsZSBpY29tcGxldGUtbW9kZSB3aGVuDQptaW5pYnVmZmVyLWRpc2Fi bGUtaWNvbXBsZXRlLW1vZGUgaXMgbm9uLW5pbA0KDQoqIGxpc3Avc3Vici5l bCAocmVhZC1udW1iZXIsIHJlYWQtY2hhci1mcm9tLW1pbmlidWZmZXIsIHkt b3Itbi1wKTogVXNlIGl0Lg0KDQoqIGxpc3Avc2ltcGxlLmVsIChyZWFkLS1l eHByZXNzaW9uKTogVXNlIGl0Lg0KLS0tDQogbGlzcC9pY29tcGxldGUuZWwg fCAgNSArKysrKw0KIGxpc3Avc2ltcGxlLmVsICAgIHwgIDMgKysrDQogbGlz cC9zdWJyLmVsICAgICAgfCAxNyArKysrKysrKysrKystLS0tLQ0KIDMgZmls ZXMgY2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkN Cg0KZGlmZiAtLWdpdCBhL2xpc3AvaWNvbXBsZXRlLmVsIGIvbGlzcC9pY29t cGxldGUuZWwNCmluZGV4IGQ1YjZmNzZkN2IuLjU1MWI4YmRjNGEgMTAwNjQ0 DQotLS0gYS9saXNwL2ljb21wbGV0ZS5lbA0KKysrIGIvbGlzcC9pY29tcGxl dGUuZWwNCkBAIC00NDIsMTAgKzQ0MiwxNSBAQCBpY29tcGxldGUtc2ltcGxl LWNvbXBsZXRpbmctcA0KICAgICAgICAgICAgICAgIChlcSBpY29tcGxldGUt d2l0aC1jb21wbGV0aW9uLXRhYmxlcyB0KQ0KICAgICAgICAgICAgICAgICht ZW1iZXIgdGFibGUgaWNvbXBsZXRlLXdpdGgtY29tcGxldGlvbi10YWJsZXMp KSkpKSkNCiANCisoZGVmdmFyIG1pbmlidWZmZXItZGlzYWJsZS1pY29tcGxl dGUtbW9kZSBuaWwpDQorDQogOzs7XyA+IGljb21wbGV0ZS1taW5pYnVmZmVy LXNldHVwICgpDQogKGRlZnVuIGljb21wbGV0ZS1taW5pYnVmZmVyLXNldHVw ICgpDQogICAiUnVuIGluIG1pbmlidWZmZXIgb24gYWN0aXZhdGlvbiB0byBl c3RhYmxpc2ggaW5jcmVtZW50YWwgY29tcGxldGlvbi4NCiBVc3VhbGx5IHJ1 biBieSBpbmNsdXNpb24gaW4gYG1pbmlidWZmZXItc2V0dXAtaG9vaycuIg0K KyAgKHdoZW4gbWluaWJ1ZmZlci1kaXNhYmxlLWljb21wbGV0ZS1tb2RlDQor ICAgIChzZXRxLWxvY2FsIGljb21wbGV0ZS1tb2RlIG5pbCkNCisgICAgKHNl dHEgbWluaWJ1ZmZlci1kaXNhYmxlLWljb21wbGV0ZS1tb2RlIG5pbCkpDQog ICAod2hlbiAoYW5kIGljb21wbGV0ZS1tb2RlIChpY29tcGxldGUtc2ltcGxl LWNvbXBsZXRpbmctcCkpDQogICAgIChzZXRxLWxvY2FsIGljb21wbGV0ZS0t aW5pdGlhbC1pbnB1dCAoaWNvbXBsZXRlLS1maWVsZC1zdHJpbmcpKQ0KICAg ICAoc2V0cS1sb2NhbCBjb21wbGV0aW9uLXNob3ctaW5saW5lLWhlbHAgbmls KQ0KZGlmZiAtLWdpdCBhL2xpc3Avc2ltcGxlLmVsIGIvbGlzcC9zaW1wbGUu ZWwNCmluZGV4IDk5OTc1NWE2NDIuLjk2MjZiMzYwNWYgMTAwNjQ0DQotLS0g YS9saXNwL3NpbXBsZS5lbA0KKysrIGIvbGlzcC9zaW1wbGUuZWwNCkBAIC0x NzM5LDYgKzE3MzksOCBAQCBldmFsLWV4cHJlc3Npb24tcHJpbnQtZm9ybWF0 DQogKGRlZnZhciBldmFsLWV4cHJlc3Npb24tbWluaWJ1ZmZlci1zZXR1cC1o b29rIG5pbA0KICAgIkhvb2sgcnVuIGJ5IGBldmFsLWV4cHJlc3Npb24nIHdo ZW4gZW50ZXJpbmcgdGhlIG1pbmlidWZmZXIuIikNCiANCisoZGVmdmFyIG1p bmlidWZmZXItZGlzYWJsZS1pY29tcGxldGUtbW9kZSkNCisNCiAoZGVmdW4g cmVhZC0tZXhwcmVzc2lvbiAocHJvbXB0ICZvcHRpb25hbCBpbml0aWFsLWNv bnRlbnRzKQ0KICAgIlJlYWQgYW4gRW1hY3MgTGlzcCBleHByZXNzaW9uIGZy b20gdGhlIG1pbmlidWZmZXIuDQogDQpAQCAtMTc1NSw2ICsxNzU3LDcgQEAg cmVhZC0tZXhwcmVzc2lvbg0KICAgICAgICAgICAoYWRkLWhvb2sgJ2NvbXBs ZXRpb24tYXQtcG9pbnQtZnVuY3Rpb25zDQogICAgICAgICAgICAgICAgICAg ICAjJ2VsaXNwLWNvbXBsZXRpb24tYXQtcG9pbnQgbmlsIHQpDQogICAgICAg ICAgIChydW4taG9va3MgJ2V2YWwtZXhwcmVzc2lvbi1taW5pYnVmZmVyLXNl dHVwLWhvb2spKQ0KKyAgICAgIChzZXRxIG1pbmlidWZmZXItZGlzYWJsZS1p Y29tcGxldGUtbW9kZSB0KQ0KICAgICAgIChyZWFkLWZyb20tbWluaWJ1ZmZl ciBwcm9tcHQgaW5pdGlhbC1jb250ZW50cw0KICAgICAgICAgICAgICAgICAg ICAgICAgICAgICByZWFkLWV4cHJlc3Npb24tbWFwIHQNCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgJ3JlYWQtZXhwcmVzc2lvbi1oaXN0b3J5KSkp KQ0KZGlmZiAtLWdpdCBhL2xpc3Avc3Vici5lbCBiL2xpc3Avc3Vici5lbA0K aW5kZXggYzJiZTI2YTE1Zi4uYmMyNWZlMjM0ZiAxMDA2NDQNCi0tLSBhL2xp c3Avc3Vici5lbA0KKysrIGIvbGlzcC9zdWJyLmVsDQpAQCAtMjc5NCw2ICsy Nzk0LDggQEAgcmVhZC1wYXNzd2QNCiAoZGVmdmFyIHJlYWQtbnVtYmVyLWhp c3RvcnkgbmlsDQogICAiVGhlIGRlZmF1bHQgaGlzdG9yeSBmb3IgdGhlIGBy ZWFkLW51bWJlcicgZnVuY3Rpb24uIikNCiANCisoZGVmdmFyIG1pbmlidWZm ZXItZGlzYWJsZS1pY29tcGxldGUtbW9kZSkNCisNCiAoZGVmdW4gcmVhZC1u dW1iZXIgKHByb21wdCAmb3B0aW9uYWwgZGVmYXVsdCBoaXN0KQ0KICAgIlJl YWQgYSBudW1lcmljIHZhbHVlIGluIHRoZSBtaW5pYnVmZmVyLCBwcm9tcHRp bmcgd2l0aCBQUk9NUFQuDQogREVGQVVMVCBzcGVjaWZpZXMgYSBkZWZhdWx0 IHZhbHVlIHRvIHJldHVybiBpZiB0aGUgdXNlciBqdXN0IHR5cGVzIFJFVC4N CkBAIC0yODEyLDYgKzI4MTQsNyBAQCByZWFkLW51bWJlcg0KIAkJCQkJcHJv bXB0IHQgdCkpKSkNCiAgICAgKHdoaWxlDQogCShwcm9nbg0KKwkgIChzZXRx IG1pbmlidWZmZXItZGlzYWJsZS1pY29tcGxldGUtbW9kZSB0KQ0KIAkgIChs ZXQgKChzdHIgKHJlYWQtZnJvbS1taW5pYnVmZmVyDQogCQkgICAgICBwcm9t cHQgbmlsIG5pbCBuaWwgKG9yIGhpc3QgJ3JlYWQtbnVtYmVyLWhpc3Rvcnkp DQogCQkgICAgICAod2hlbiBkZWZhdWx0DQpAQCAtMzA1Miw4ICszMDU1LDEw IEBAIHJlYWQtY2hhci1mcm9tLW1pbmlidWZmZXINCiAgICAgICAgICA7OyBQ cm90ZWN0IHRoaXMtY29tbWFuZCB3aGVuIGNhbGxlZCBmcm9tIHByZS1jb21t YW5kLWhvb2sgKGJ1ZyM0NTAyOSkNCiAgICAgICAgICAodGhpcy1jb21tYW5k IHRoaXMtY29tbWFuZCkNCiAgICAgICAgICAocmVzdWx0DQotICAgICAgICAg IChyZWFkLWZyb20tbWluaWJ1ZmZlciBwcm9tcHQgbmlsIG1hcCBuaWwNCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChvciBoaXN0b3J5ICdl bXB0eS1oaXN0b3J5KSkpDQorICAgICAgICAgIChwcm9nbg0KKyAgICAgICAg ICAgIChzZXRxIG1pbmlidWZmZXItZGlzYWJsZS1pY29tcGxldGUtbW9kZSB0 KQ0KKyAgICAgICAgICAgIChyZWFkLWZyb20tbWluaWJ1ZmZlciBwcm9tcHQg bmlsIG1hcCBuaWwNCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgKG9yIGhpc3RvcnkgJ2VtcHR5LWhpc3RvcnkpKSkpDQogICAgICAgICAg KGNoYXINCiAgICAgICAgICAgKGlmICg+IChsZW5ndGggcmVzdWx0KSAwKQ0K ICAgICAgICAgICAgICAgOzsgV2UgaGF2ZSBhIHN0cmluZyAod2l0aCBvbmUg Y2hhcmFjdGVyKSwgc28gcmV0dXJuIHRoZSBmaXJzdCBvbmUuDQpAQCAtMzI0 Nyw5ICszMjUyLDExIEBAIHktb3Itbi1wDQogICAgICAgICAgICAgICAgICAg ICAgICBtYXApKQ0KICAgICAgICAgICAgICA7OyBQcm90ZWN0IHRoaXMtY29t bWFuZCB3aGVuIGNhbGxlZCBmcm9tIHByZS1jb21tYW5kLWhvb2sgKGJ1ZyM0 NTAyOSkNCiAgICAgICAgICAgICAgKHRoaXMtY29tbWFuZCB0aGlzLWNvbW1h bmQpDQotICAgICAgICAgICAgIChzdHIgKHJlYWQtZnJvbS1taW5pYnVmZmVy DQotICAgICAgICAgICAgICAgICAgIHByb21wdCBuaWwga2V5bWFwIG5pbA0K LSAgICAgICAgICAgICAgICAgICAob3IgeS1vci1uLXAtaGlzdG9yeS12YXJp YWJsZSAnZW1wdHktaGlzdG9yeSkpKSkNCisgICAgICAgICAgICAgKHN0ciAo cHJvZ24NCisgICAgICAgICAgICAgICAgICAgIChzZXRxIG1pbmlidWZmZXIt ZGlzYWJsZS1pY29tcGxldGUtbW9kZSB0KQ0KKyAgICAgICAgICAgICAgICAg ICAgKHJlYWQtZnJvbS1taW5pYnVmZmVyDQorICAgICAgICAgICAgICAgICAg ICAgcHJvbXB0IG5pbCBrZXltYXAgbmlsDQorICAgICAgICAgICAgICAgICAg ICAgKG9yIHktb3Itbi1wLWhpc3RvcnktdmFyaWFibGUgJ2VtcHR5LWhpc3Rv cnkpKSkpKQ0KICAgICAgICAgKHNldHEgYW5zd2VyIChpZiAobWVtYmVyIHN0 ciAnKCJ5IiAiWSIpKSAnYWN0ICdza2lwKSkpKSkNCiAgICAgKGxldCAoKHJl dCAoZXEgYW5zd2VyICdhY3QpKSkNCiAgICAgICAodW5sZXNzIG5vbmludGVy YWN0aXZlDQotLSANCjIuMzAuMg0KDQo= --RZ51XikxYj--