From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Henrik Grimler Newsgroups: gmane.emacs.bugs Subject: bug#47596: File descriptor error when exiting emacs on android 11 Date: Tue, 11 May 2021 19:06:11 +0200 Message-ID: <3eca4ad4c693735b4c9d76b3d3301287086fed4b.camel@grimler.se> References: <83im51deye.fsf@gnu.org> <730dad3a54f0f53b22e9603879e949b60f5b2c00.camel@grimler.se> <191e2295b88384adf0e7cc1e3dc84cf8f37eb973.camel@grimler.se> <838s5wdhef.fsf@gnu.org> <2215b2299da65d790a705d9b83051028a1a2b693.camel@grimler.se> <87k0ocw37m.fsf@gnus.org> <8a9fbefead009fce76aa5a28315c0fedf3ce7bec.camel@grimler.se> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-7W8qvDH7+CpoNkU1E+IP" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33669"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.40.1 Cc: 47596@debbugs.gnu.org To: Lars Ingebrigtsen , eliz@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 11 19:07:36 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lgVr6-0008dO-B1 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 May 2021 19:07:36 +0200 Original-Received: from localhost ([::1]:53802 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgVr5-0007D2-9f for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 May 2021 13:07:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54384) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgVqY-0006Od-Qw for bug-gnu-emacs@gnu.org; Tue, 11 May 2021 13:07:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53929) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lgVqY-0002Cz-DN for bug-gnu-emacs@gnu.org; Tue, 11 May 2021 13:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lgVqY-0006ZW-6r for bug-gnu-emacs@gnu.org; Tue, 11 May 2021 13:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Henrik Grimler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 May 2021 17:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47596 X-GNU-PR-Package: emacs Original-Received: via spool by 47596-submit@debbugs.gnu.org id=B47596.162075278225214 (code B ref 47596); Tue, 11 May 2021 17:07:02 +0000 Original-Received: (at 47596) by debbugs.gnu.org; 11 May 2021 17:06:22 +0000 Original-Received: from localhost ([127.0.0.1]:37242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgVpu-0006Yc-0O for submit@debbugs.gnu.org; Tue, 11 May 2021 13:06:22 -0400 Original-Received: from h04mx15.reliablemail.org ([185.76.67.208]:49102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgVps-0006YP-W8 for 47596@debbugs.gnu.org; Tue, 11 May 2021 13:06:21 -0400 X-Halon-Out: 3102689a-b27b-11eb-a4a4-354a41e2f763 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=grimler.se; s=default; h=MIME-Version:Content-Type:References:In-Reply-To:Date:Cc:To:From :Subject:Message-ID:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=YVxadFqPW/QIMgf7F+SHETGOyglD/uGYp7FCPKsXsHc=; b=rChm3PFOv0Es6TEkZaatI0N91j MDI2Jc3niYh12V8UWovTQr8CrB4CmlUMpKz/cNQlK4qPnvoNybf0QWcdyd0bOTAlmKB01r+gy8xR0 WvmgJfshyiNDZTiTDsESbo8wuwDiMqgu+X9066FMc1/ztbIEmQMAx7/DTaR7SFaxIVIjJswhUSfJ5 7YtPOIxcVYy6NNr1LaOFw8tiU+oczVFWa0ovkA1yXZYnoiV9/7Ru8pTG3fEAMEVHNTPTSjjW2j/TP ZfQ4zgFyVBAMJhpYkgU2U8cU4TvxnFCZMyfM32SR0Qw6CH5mRklHaBCYScjqXtT49B+x5C2buRGjf FKH6rNjw==; In-Reply-To: <8a9fbefead009fce76aa5a28315c0fedf3ce7bec.camel@grimler.se> X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cpsrv07.misshosting.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - grimler.se X-Get-Message-Sender-Via: cpsrv07.misshosting.com: authenticated_id: henrik@grimler.se X-Authenticated-Sender: cpsrv07.misshosting.com: henrik@grimler.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206259 Archived-At: --=-7W8qvDH7+CpoNkU1E+IP Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Hi again, Enh at google suggested [1] that `setlinebuf (stderr)` could be an alternative instead of opening a copy of stderr. I tried out the attached patch, which removes the buferr variable and uses setlinebuf on stderr instead, and it seem to work (in the sense that emacs opens and closes without errors) on archlinux as well as android. Could this work or do we need to have both buferr and stderr? Best regards, Henrik Grimler [1] https://issuetracker.google.com/issues/184380442 --=-7W8qvDH7+CpoNkU1E+IP Content-Disposition: attachment; filename="line_buffered_stderr.patch" Content-Type: text/x-patch; name="line_buffered_stderr.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 Y29tbWl0IGVmM2JlYWY2NjQzNDdmN2ZjZTFmMzQ3NWZlNjVkZTcyOTMyMDgzN2UKQXV0aG9yOiBI ZW5yaWsgR3JpbWxlciA8aGVucmlrQGdyaW1sZXIuc2U+CkRhdGU6ICAgVHVlIE1heSAxMSAwOToz Njo1MiAyMDIxICswMjAwCgogICAgVXNlIHNldGxpbmVidWYgdG8gbWFrZSBzdGRlcnIgbGluZSBi dWZmZXJlZAogICAgCiAgICBJZiBhdG9taWMgd3JpdGVzIGFyZSBzdXBwb3J0ZWQuICBBbmRyb2lk ID49IDEwIGhhcyBhIGZpbGUgZGVzY3JpcHRvcgogICAgc2FuaXRpemVyIHdoaWNoIGVycm9ycyBp ZiBhIHN0cmVhbSBpcyBjbG9zZWQgd2hpbGUgdGhlcmUgYXJlIHN0aWxsCiAgICBmZCdzIGFzc29j aWF0ZWQgd2l0aCBpdC4gSW4gZW1hY3Mgc3RkZXJyIGlzIG9wZW5lZCB0d2ljZSBpZiBsaW5lCiAg ICBidWZmZXJlZCBzdHJlYW1zIGFyZSBzdXBwb3J0ZWQuICBSYXRoZXIgdGhhbiBvcGVuaW5nIGEg Y29weSB3ZSBjYW4KICAgIG1ha2Ugc3RkZXJyIGxpbmUgYnVmZmVyZWQgd2l0aCBzZXRsaW5lYnVm IGluc3RlYWQuCgpkaWZmIC0tZ2l0IGEvc3JjL3N5c2RlcC5jIGIvc3JjL3N5c2RlcC5jCmluZGV4 IGQ5NDBhY2M0ZTAuLjc3ZTFhMGJlM2MgMTAwNjQ0Ci0tLSBhL3NyYy9zeXNkZXAuYworKysgYi9z cmMvc3lzZGVwLmMKQEAgLTIzMiwxMCArMjMyLDYgQEAgZm9yY2Vfb3BlbiAoaW50IGZkLCBpbnQg ZmxhZ3MpCiAgICAgfQogfQogCi0vKiBBIHN0cmVhbSB0aGF0IGlzIGxpa2Ugc3RkZXJyLCBleGNl cHQgbGluZSBidWZmZXJlZC4gIEl0IGlzIE5VTEwKLSAgIGR1cmluZyBzdGFydHVwLCBvciBpZiBs aW5lIGJ1ZmZlcmluZyBpcyBub3QgaW4gdXNlLiAgKi8KLXN0YXRpYyBGSUxFICpidWZlcnI7Ci0K IC8qIE1ha2Ugc3VyZSBzdGRpbiwgc3Rkb3V0LCBhbmQgc3RkZXJyIGFyZSBvcGVuIHRvIHNvbWV0 aGluZywgc28gdGhhdAogICAgdGhlaXIgZmlsZSBkZXNjcmlwdG9ycyBhcmUgbm90IGhpamFja2Vk IGJ5IGxhdGVyIHN5c3RlbSBjYWxscy4gICovCiB2b2lkCkBAIC0yNDksMTIgKzI0NSwxMCBAQCBp bml0X3N0YW5kYXJkX2ZkcyAodm9pZCkKICAgZm9yY2Vfb3BlbiAoU1RET1VUX0ZJTEVOTywgT19S RE9OTFkpOwogICBmb3JjZV9vcGVuIChTVERFUlJfRklMRU5PLCBPX1JET05MWSk7CiAKLSAgLyog U2V0IGJ1ZmVyciBpZiBwb3NzaWJsZSBvbiBwbGF0Zm9ybXMgZGVmaW5pbmcgX1BDX1BJUEVfQlVG LCBhcworICAvKiBNYWtlIHN0ZGVyciBsaW5lIGJ1ZmZlcmVkIG9uIHBsYXRmb3JtcyBkZWZpbmlu ZyBfUENfUElQRV9CVUYsIGFzCiAgICAgIHRoZXkgc3VwcG9ydCB0aGUgbm90aW9uIG9mIGF0b21p YyB3cml0ZXMgdG8gcGlwZXMuICAqLwogICAjaWZkZWYgX1BDX1BJUEVfQlVGCi0gICAgYnVmZXJy ID0gZmRvcGVuIChTVERFUlJfRklMRU5PLCAidyIpOwotICAgIGlmIChidWZlcnIpCi0gICAgICBz ZXR2YnVmIChidWZlcnIsIE5VTEwsIF9JT0xCRiwgMCk7CisgICAgc2V0bGluZWJ1ZiAoc3RkZXJy KTsKICAgI2VuZGlmCiB9CiAKQEAgLTI2NTAsMTEgKzI2NDQsMTEgQEAgc2FmZV9zdHJzaWduYWwg KGludCBjb2RlKQogc3RhdGljIEZJTEUgKgogZXJyc3RyZWFtICh2b2lkKQogewotICBGSUxFICpl cnIgPSBidWZlcnI7Ci0gIGlmICghZXJyKQotICAgIHJldHVybiBzdGRlcnI7CisjaWZkZWYgX1BD X1BJUEVfQlVGCisgIC8qIGZsdXNoIGxpbmUgYnVmZmVyZWQgc3RkZXJyICovCiAgIGZmbHVzaF91 bmxvY2tlZCAoc3RkZXJyKTsKLSAgcmV0dXJuIGVycjsKKyNlbmRpZgorICByZXR1cm4gc3RkZXJy OwogfQogCiAvKiBUaGVzZSBmdW5jdGlvbnMgYXJlIGxpa2UgZnB1dGMsIHZmcHJpbnRmLCBhbmQg ZndyaXRlLApAQCAtMjY5Niw5ICsyNjkwLDEyIEBAIGNsb3NlX291dHB1dF9zdHJlYW1zICh2b2lk KQogICAgICAgX2V4aXQgKEVYSVRfRkFJTFVSRSk7CiAgICAgfQogCisgIGJvb2wgZXJyOworI2lm ZGVmIF9QQ19QSVBFX0JVRgorICBlcnIgPSAoZmZsdXNoIChzdGRlcnIpICE9IDAgfHwgZmVycm9y IChzdGRlcnIpKTsKKyNlbmRpZgogICAvKiBEbyBub3QgY2xvc2Ugc3RkZXJyIGlmIGFkZHJlc3Nl cyBhcmUgYmVpbmcgc2FuaXRpemVkLCBhcyB0aGUKICAgICAgc2FuaXRpemVyIG1pZ2h0IHJlcG9y dCB0byBzdGRlcnIgYWZ0ZXIgdGhpcyBmdW5jdGlvbiBpcyBpbnZva2VkLiAgKi8KLSAgYm9vbCBl cnIgPSBidWZlcnIgJiYgKGZmbHVzaCAoYnVmZXJyKSAhPSAwIHx8IGZlcnJvciAoYnVmZXJyKSk7 CiAgIGlmIChlcnIgfCAoQUREUkVTU19TQU5JVElaRVIKIAkgICAgID8gZmZsdXNoIChzdGRlcnIp ICE9IDAgfHwgZmVycm9yIChzdGRlcnIpCiAJICAgICA6IGNsb3NlX3N0cmVhbSAoc3RkZXJyKSAh PSAwKSkK --=-7W8qvDH7+CpoNkU1E+IP--