From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#47599: 28.0.50; Feature request improve/update isearch Date: Wed, 07 Apr 2021 17:58:13 +0000 Message-ID: <3ec7e2e58adbe810caca@heytings.org> References: <20210405020725.ob7bewlin7cid4pa.ref@Ergus> <20210405020725.ob7bewlin7cid4pa@Ergus> <87mtubrzp3.fsf@mail.linkov.net> <87k0pe49ny.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="6K6av3vHMj" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22356"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47599@debbugs.gnu.org, Ergus To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 07 20:14:23 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lUCh5-0005ii-HN for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Apr 2021 20:14:23 +0200 Original-Received: from localhost ([::1]:57298 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUCh4-0003AA-Ft for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Apr 2021 14:14:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50040) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUCSE-0001FO-6F for bug-gnu-emacs@gnu.org; Wed, 07 Apr 2021 13:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33610) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lUCSD-0007oE-Ty for bug-gnu-emacs@gnu.org; Wed, 07 Apr 2021 13:59:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lUCSD-0001Ti-Tf for bug-gnu-emacs@gnu.org; Wed, 07 Apr 2021 13:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Apr 2021 17:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47599 X-GNU-PR-Package: emacs Original-Received: via spool by 47599-submit@debbugs.gnu.org id=B47599.16178182975629 (code B ref 47599); Wed, 07 Apr 2021 17:59:01 +0000 Original-Received: (at 47599) by debbugs.gnu.org; 7 Apr 2021 17:58:17 +0000 Original-Received: from localhost ([127.0.0.1]:45156 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lUCRV-0001Si-8B for submit@debbugs.gnu.org; Wed, 07 Apr 2021 13:58:17 -0400 Original-Received: from heytings.org ([95.142.160.155]:57224) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lUCRT-0001SY-0L for 47599@debbugs.gnu.org; Wed, 07 Apr 2021 13:58:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1617818293; bh=E3nbB/msG/Cz0B3JIfL+kCI4/6uHVSi4y7cnhCEeBsY=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=GqXjgB0hliQYjU7x53HE6+C1pfPOvs0+LoSE5wkb1wzU2uaJmwOjV3jqfl9QBaESK ca3TfehlcARpYc5gTOT9mdIJpP2AeKZNKkOkDQRxvEsPTQELt7A2klCNgT1Y+5xFUS UrULkJ4CagfDWVmGU09Z2RBiMewo6cXenBJE+h5Qz3aBCCbd4BGEANIUuoRwycYOfL GT3yjGn+eG4Te9bkh1IRL5iE9Uf7pEAzhG0ZIGX7ml44coclpA2pseoUB6ipr2no1Y /sjMNdGWVWcJoYveEJIFrJkuljyX8ua8lGHYngSjPueOFO0JGUdhTIC+YjjzQUDnYl INZlZDHfCjzVA== In-Reply-To: <87k0pe49ny.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203698 Archived-At: --6K6av3vHMj Content-Type: text/plain; charset=us-ascii; format=flowed > > Thanks, finally there is an option to avoid typing extra C-r. > :-) And thanks for your feedback! > > Is it possible to find a clearer name? > Maybe isearch-repeat-on-direction-change would be better with the prefix > 'isearch-repeat-' to hint that it applies to the commands > 'isearch-repeat-*'? > Done. > > This breaks the following feature: > > When isearch-forward is t: > - C-1 C-r moves to the previous match (like your patch does without 'C-1') > - C-2 C-r moves to the second previous match > - C-u -1 C-r moves to the next match > - C-u -2 C-r moves to the second next match > > This is due to these lines in isearch-repeat-backward: > > ;; Reverse the direction back > (isearch-repeat 'backward)) > (t > ;; Take into account one iteration to reverse direction > (when isearch-forward (setq count (1+ count))) > > When the new option is non-nil, there is no need to increment 'count'. > Also the new option should be let-bound to nil around the call to > '(isearch-repeat 'backward)' above to just change the direction back > without moving to the next match. > > The same applies to isearch-repeat-forward and when isearch-forward is nil. > Fixed, thank you! --6K6av3vHMj Content-Type: text/x-diff; name=0001-User-option-to-move-to-another-match-when-changing-d.patch Content-Transfer-Encoding: base64 Content-ID: <3ec7e2e58a09c7bcd7aa@heytings.org> Content-Description: Content-Disposition: attachment; filename=0001-User-option-to-move-to-another-match-when-changing-d.patch RnJvbSBhOTBkMjQ0N2I0NDg4MzFmM2Y0YWI4MjAwNzY5ZWY3NDk2MTJjMDJh IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogR3JlZ29yeSBIZXl0 aW5ncyA8Z3JlZ29yeUBoZXl0aW5ncy5vcmc+DQpEYXRlOiBXZWQsIDcgQXBy IDIwMjEgMTc6NTE6MzAgKzAwMDANClN1YmplY3Q6IFtQQVRDSF0gVXNlciBv cHRpb24gdG8gbW92ZSB0byBhbm90aGVyIG1hdGNoIHdoZW4gY2hhbmdpbmcg ZGlyZWN0aW9uDQogaW4gaXNlYXJjaC4NCg0KKiBsaXNwL2lzZWFyY2guZWwg KGlzZWFyY2gtZGlyZWN0aW9uLWNoYW5nZS1jaGFuZ2VzLW1hdGNoKTogTmV3 DQp1c2VyIG9wdGlvbi4NCihpc2VhcmNoLXJlcGVhdCk6IFVzZSB0aGUgbmV3 IG9wdGlvbi4NCihpc2VhcmNoLXJlcGVhdC1mb3J3YXJkLCBpc2VhcmNoLXJl cGVhdC1iYWNrd2FyZCk6IEFkYXB0IHRvIHRoZQ0KbmV3IG9wdGlvbi4NCg0K KiBldGMvTkVXUzogTWVudGlvbiB0aGUgbmV3IHVzZXIgb3B0aW9uLg0KDQoq IGRvYy9lbWFjcy9zZWFyY2gudGV4aTogRG9jdW1lbnQgdGhlIG5ldyB1c2Vy IG9wdGlvbi4NCi0tLQ0KIGRvYy9lbWFjcy9zZWFyY2gudGV4aSB8ICA4ICsr KysrKysrDQogZXRjL05FV1MgICAgICAgICAgICAgIHwgIDYgKysrKysrDQog bGlzcC9pc2VhcmNoLmVsICAgICAgIHwgMjQgKysrKysrKysrKysrKysrKysr KystLS0tDQogMyBmaWxlcyBjaGFuZ2VkLCAzNCBpbnNlcnRpb25zKCspLCA0 IGRlbGV0aW9ucygtKQ0KDQpkaWZmIC0tZ2l0IGEvZG9jL2VtYWNzL3NlYXJj aC50ZXhpIGIvZG9jL2VtYWNzL3NlYXJjaC50ZXhpDQppbmRleCBmM2M0MmJj ZWE3Li4zODQzMGEyYWIxIDEwMDY0NA0KLS0tIGEvZG9jL2VtYWNzL3NlYXJj aC50ZXhpDQorKysgYi9kb2MvZW1hY3Mvc2VhcmNoLnRleGkNCkBAIC0yMDEs NiArMjAxLDE0IEBAIHNvbWV0aGluZyBiZWZvcmUgdGhlIHN0YXJ0aW5nIHBv aW50LCB0eXBlIEBrYmR7Qy1yfSB0byBzd2l0Y2ggdG8gYQ0KIGJhY2t3YXJk IHNlYXJjaCwgbGVhdmluZyB0aGUgc2VhcmNoIHN0cmluZyB1bmNoYW5nZWQu ICBTaW1pbGFybHksDQogQGtiZHtDLXN9IGluIGEgYmFja3dhcmQgc2VhcmNo IHN3aXRjaGVzIHRvIGEgZm9yd2FyZCBzZWFyY2guDQogDQorQGNpbmRleCBz ZWFyY2gsIGNoYW5naW5nIGRpcmVjdGlvbg0KK0B2aW5kZXggaXNlYXJjaC1y ZXBlYXQtb24tZGlyZWN0aW9uLWNoYW5nZQ0KKyAgV2hlbiB5b3UgY2hhbmdl IHRoZSBkaXJlY3Rpb24gb2YgYSBzZWFyY2gsIHRoZSBmaXJzdCBjb21tYW5k IHlvdQ0KK3R5cGUgd2lsbCwgYnkgZGVmYXVsdCwgcmVtYWluIG9uIHRoZSBz YW1lIG1hdGNoLCBhbmQgdGhlIGN1cnNvciB3aWxsDQorbW92ZSB0byB0aGUg b3RoZXIgZW5kIG9mIHRoZSBtYXRjaC4gIFRvIG1vdmUgdG8gYW5vdGhlciBt YXRjaA0KK2ltbWVkaWF0ZWx5LCBjdXN0b21pemUgdGhlIHZhcmlhYmxlDQor QGNvZGV7aXNlYXJjaC1yZXBlYXQtb24tZGlyZWN0aW9uLWNoYW5nZX0gdG8g QGNvZGV7dH0uDQorDQogQGNpbmRleCBzZWFyY2gsIHdyYXBwaW5nIGFyb3Vu ZA0KIEBjaW5kZXggc2VhcmNoLCBvdmVyd3JhcHBlZA0KIEBjaW5kZXggd3Jh cHBlZCBzZWFyY2gNCmRpZmYgLS1naXQgYS9ldGMvTkVXUyBiL2V0Yy9ORVdT DQppbmRleCBkM2E4NzQ4ZGVkLi44ZDdiM2E2YzQ2IDEwMDY0NA0KLS0tIGEv ZXRjL05FV1MNCisrKyBiL2V0Yy9ORVdTDQpAQCAtMzY3LDYgKzM2NywxMiBA QCB0cnlpbmcgdG8gYmUgbm9uLWRlc3RydWN0aXZlLg0KIFRoaXMgY29tbWFu ZCBvcGVucyBhIG5ldyBidWZmZXIgY2FsbGVkICIqTWVtb3J5IFJlcG9ydCoi IGFuZCBnaXZlcyBhDQogc3VtbWFyeSBvZiB3aGVyZSBFbWFjcyBpcyB1c2lu ZyBtZW1vcnkgY3VycmVudGx5Lg0KIA0KKysrKw0KKyoqIE5ldyB1c2VyIG9w dGlvbiAnaXNlYXJjaC1yZXBlYXQtb24tZGlyZWN0aW9uLWNoYW5nZScuDQor V2hlbiB0aGlzIG9wdGlvbiBpcyBzZXQsIGRpcmVjdGlvbiBjaGFuZ2VzIGlu IElzZWFyY2ggbW92ZSB0byBhbm90aGVyDQorc2VhcmNoIG1hdGNoLCBpZiB0 aGVyZSBpcyBvbmUsIGluc3RlYWQgb2YgbW92aW5nIHBvaW50IHRvIHRoZSBv dGhlcg0KK2VuZCBvZiB0aGUgY3VycmVudCBtYXRjaC4NCisNCiAqKiBPdXRs aW5lDQogDQogKysrDQpkaWZmIC0tZ2l0IGEvbGlzcC9pc2VhcmNoLmVsIGIv bGlzcC9pc2VhcmNoLmVsDQppbmRleCBhODI4YzU2OWFhLi5hNDE4MjdmOWNk IDEwMDY0NA0KLS0tIGEvbGlzcC9pc2VhcmNoLmVsDQorKysgYi9saXNwL2lz ZWFyY2guZWwNCkBAIC0xODUsNiArMTg1LDE2IEBAIFdoZW4gYG5pbCcsIG5l dmVyIHdyYXAsIGp1c3Qgc3RvcCBhdCB0aGUgbGFzdCBtYXRjaC4iDQogICAg ICAgICAgICAgICAgICAoY29uc3QgOnRhZyAiRGlzYWJsZSB3cmFwcGluZyIg bmlsKSkNCiAgIDp2ZXJzaW9uICIyOC4xIikNCiANCisoZGVmY3VzdG9tIGlz ZWFyY2gtcmVwZWF0LW9uLWRpcmVjdGlvbi1jaGFuZ2UgbmlsDQorICAiV2hl dGhlciBhIGRpcmVjdGlvbiBjaGFuZ2Ugc2hvdWxkIG1vdmUgdG8gYW5vdGhl ciBtYXRjaC4NCitXaGVuIGBuaWwnLCB0aGUgZGVmYXVsdCwgYSBkaXJlY3Rp b24gY2hhbmdlIG1vdmVzIHBvaW50IHRvIHRoZSBvdGhlcg0KK2VuZCBvZiB0 aGUgY3VycmVudCBzZWFyY2ggbWF0Y2guDQorV2hlbiBgdCcsIGEgZGlyZWN0 aW9uIGNoYW5nZSBtb3ZlcyB0byBhbm90aGVyIHNlYXJjaCBtYXRjaCwgaWYg dGhlcmUNCitpcyBvbmUuIg0KKyAgOnR5cGUgJyhjaG9pY2UgKGNvbnN0IDp0 YWcgIlJlbWFpbiBvbiB0aGUgc2FtZSBtYXRjaCIgbmlsKQ0KKyAgICAgICAg ICAgICAgICAgKGNvbnN0IDp0YWcgIk1vdmUgdG8gYW5vdGhlciBtYXRjaCIg dCkpDQorICA6dmVyc2lvbiAiMjguMSIpDQorDQogKGRlZnZhciBpc2VhcmNo LW1vZGUtaG9vayBuaWwNCiAgICJGdW5jdGlvbihzKSB0byBjYWxsIGFmdGVy IHN0YXJ0aW5nIHVwIGFuIGluY3JlbWVudGFsIHNlYXJjaC4iKQ0KIA0KQEAg LTE4NDcsNiArMTg1Nyw4IEBAIFVzZSBgaXNlYXJjaC1leGl0JyB0byBxdWl0 IHdpdGhvdXQgc2lnbmFsaW5nLiINCiAJICAgICAgKGZ1bmNhbGwgaXNlYXJj aC13cmFwLWZ1bmN0aW9uKQ0KIAkgICAgKGdvdG8tY2hhciAoaWYgaXNlYXJj aC1mb3J3YXJkIChwb2ludC1taW4pIChwb2ludC1tYXgpKSkpKSkNCiAgICAg OzsgQy1zIGluIHJldmVyc2Ugb3IgQy1yIGluIGZvcndhcmQsIGNoYW5nZSBk aXJlY3Rpb24uDQorICAgIChpZiAoYW5kIGlzZWFyY2gtb3RoZXItZW5kIGlz ZWFyY2gtcmVwZWF0LW9uLWRpcmVjdGlvbi1jaGFuZ2UpDQorICAgICAgICAo Z290by1jaGFyIGlzZWFyY2gtb3RoZXItZW5kKSkNCiAgICAgKHNldHEgaXNl YXJjaC1mb3J3YXJkIChub3QgaXNlYXJjaC1mb3J3YXJkKQ0KIAkgIGlzZWFy Y2gtc3VjY2VzcyB0KSkNCiANCkBAIC0xOTEyLDEwICsxOTI0LDEyIEBAIG9m IHRoZSBidWZmZXIsIHR5cGUgXFxbaXNlYXJjaC1iZWdpbm5pbmctb2YtYnVm ZmVyXSB3aXRoIGEgbnVtZXJpYyBhcmd1bWVudC4iDQogICAgICAgICAoY29u ZCAoKDwgY291bnQgMCkNCiAgICAgICAgICAgICAgICAoaXNlYXJjaC1yZXBl YXQtYmFja3dhcmQgKGFicyBjb3VudCkpDQogICAgICAgICAgICAgICAgOzsg UmV2ZXJzZSB0aGUgZGlyZWN0aW9uIGJhY2sNCi0gICAgICAgICAgICAgICAo aXNlYXJjaC1yZXBlYXQgJ2ZvcndhcmQpKQ0KKyAgICAgICAgICAgICAgIChs ZXQgKChpc2VhcmNoLXJlcGVhdC1vbi1kaXJlY3Rpb24tY2hhbmdlIG5pbCkp DQorICAgICAgICAgICAgICAgICAoaXNlYXJjaC1yZXBlYXQgJ2ZvcndhcmQp KSkNCiAgICAgICAgICAgICAgICh0DQogICAgICAgICAgICAgICAgOzsgVGFr ZSBpbnRvIGFjY291bnQgb25lIGl0ZXJhdGlvbiB0byByZXZlcnNlIGRpcmVj dGlvbg0KLSAgICAgICAgICAgICAgICh3aGVuIChub3QgaXNlYXJjaC1mb3J3 YXJkKSAoc2V0cSBjb3VudCAoMSsgY291bnQpKSkNCisgICAgICAgICAgICAg ICAodW5sZXNzIGlzZWFyY2gtcmVwZWF0LW9uLWRpcmVjdGlvbi1jaGFuZ2UN CisgICAgICAgICAgICAgICAgICh3aGVuIChub3QgaXNlYXJjaC1mb3J3YXJk KSAoc2V0cSBjb3VudCAoMSsgY291bnQpKSkpDQogICAgICAgICAgICAgICAg KGlzZWFyY2gtcmVwZWF0ICdmb3J3YXJkIGNvdW50KSkpKQ0KICAgICAoaXNl YXJjaC1yZXBlYXQgJ2ZvcndhcmQpKSkNCiANCkBAIC0xOTMzLDEwICsxOTQ3 LDEyIEBAIG9mIHRoZSBidWZmZXIsIHR5cGUgXFxbaXNlYXJjaC1lbmQtb2Yt YnVmZmVyXSB3aXRoIGEgbnVtZXJpYyBhcmd1bWVudC4iDQogICAgICAgICAo Y29uZCAoKDwgY291bnQgMCkNCiAgICAgICAgICAgICAgICAoaXNlYXJjaC1y ZXBlYXQtZm9yd2FyZCAoYWJzIGNvdW50KSkNCiAgICAgICAgICAgICAgICA7 OyBSZXZlcnNlIHRoZSBkaXJlY3Rpb24gYmFjaw0KLSAgICAgICAgICAgICAg IChpc2VhcmNoLXJlcGVhdCAnYmFja3dhcmQpKQ0KKyAgICAgICAgICAgICAg IChsZXQgKChpc2VhcmNoLXJlcGVhdC1vbi1kaXJlY3Rpb24tY2hhbmdlIG5p bCkpDQorICAgICAgICAgICAgICAgICAoaXNlYXJjaC1yZXBlYXQgJ2JhY2t3 YXJkKSkpDQogICAgICAgICAgICAgICAodA0KICAgICAgICAgICAgICAgIDs7 IFRha2UgaW50byBhY2NvdW50IG9uZSBpdGVyYXRpb24gdG8gcmV2ZXJzZSBk aXJlY3Rpb24NCi0gICAgICAgICAgICAgICAod2hlbiBpc2VhcmNoLWZvcndh cmQgKHNldHEgY291bnQgKDErIGNvdW50KSkpDQorICAgICAgICAgICAgICAg KHVubGVzcyBpc2VhcmNoLXJlcGVhdC1vbi1kaXJlY3Rpb24tY2hhbmdlDQor ICAgICAgICAgICAgICAgICAod2hlbiBpc2VhcmNoLWZvcndhcmQgKHNldHEg Y291bnQgKDErIGNvdW50KSkpKQ0KICAgICAgICAgICAgICAgIChpc2VhcmNo LXJlcGVhdCAnYmFja3dhcmQgY291bnQpKSkpDQogICAgIChpc2VhcmNoLXJl cGVhdCAnYmFja3dhcmQpKSkNCiANCi0tIA0KMi4zMC4yDQoNCg== --6K6av3vHMj--