From: Dmitry Gutov <dmitry@gutov.dev>
To: Juri Linkov <juri@linkov.net>, Spencer Baugh <sbaugh@janestreet.com>
Cc: 63829@debbugs.gnu.org
Subject: bug#63829: 29.0.90; project-find-file's future history breaks with common-parent-directory
Date: Tue, 6 Jun 2023 04:40:04 +0300 [thread overview]
Message-ID: <3e404df1-b3a9-f9e3-4270-f42df8b704c7@gutov.dev> (raw)
In-Reply-To: <86h6rnw7gm.fsf@mail.linkov.net>
On 04/06/2023 19:36, Juri Linkov wrote:
>> On top of your patch, I can implement the feature I mentioned with the
>> patch at the end. This causes the following nice behavior:
>>
>> 1. Open ~/src/emacs/emacs-29/lisp/progmodes/project.el
>> 2. C-x p p ~/src/emacs/trunk
>> 3. f
>> 4. M-n and the minibuffer contains "lisp/progmodes/project.el"
>> 5. RET and we have now easily switched to the same file in another
>> project
>>
>> Does the implementation seem OK?
>>
>> diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
>> index ac7be8dcbb2..b1e01df5314 100644
>> --- a/lisp/progmodes/project.el
>> +++ b/lisp/progmodes/project.el
>> @@ -1008,7 +1008,12 @@ project-find-file
>> (dirs (list root)))
>> (project-find-file-in
>> (or (thing-at-point 'filename)
>> - buffer-file-name)
>> + (and buffer-file-name
>> + (if-let (buffer-proj (and project-current-directory-override
>> + (project-current nil default-directory)))
> But we are going to remove project-current-directory-override in bug#63648
> where default-directory will be changed to next-default-directory.
I guess the proposed logic could be reimplemented without using
project-current-directory-override -- just based on the changed value of
default-directory. And using the parent directory of buffer-file-name.
But so far the patch over there is not complete yet, is it? I wouldn't
say it's a settled matter so far.
> BTW, I asked about this before inhttps://debbugs.gnu.org/58447#127
> and then it was deemed to be not too general to handle, so I backed it out
> inhttps://debbugs.gnu.org/58447#160 with such conclusion:
>
> OTOH, `C-x p f M-p' in another project is not my primary workflow.
> But if someone wants to keep a plain history, this could be added
> later in master, e.g. by a new value of project-read-file-name-function
> and a function that is mostly a copy of project--read-file-cpd-relative.
>
> So maybe this could be implemented in master now?
I think the design there was to use relative file names in history? Or a
different variable for project file name history (which would use
relative names only). I'm not ruling that out, but the patch proposed
here is a little more focused.
OTOH, it only allows finding the "current" file in the other project,
but not other files that were previously visited too. Spencer, what do
you think about that capability? Do you also feel it is missing and
would like to look into it next? Then the current patch might be the
wrong direction.
next prev parent reply other threads:[~2023-06-06 1:40 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 22:32 bug#63829: 29.0.90; project-find-file's future history breaks with common-parent-directory Spencer Baugh
2023-06-02 6:47 ` Eli Zaretskii
2023-06-03 12:19 ` Dmitry Gutov
2023-06-03 12:48 ` Eli Zaretskii
2023-06-03 13:48 ` Dmitry Gutov
2023-06-03 2:30 ` Dmitry Gutov
2023-06-03 11:00 ` Spencer Baugh
2023-06-04 16:36 ` Juri Linkov
2023-06-06 1:40 ` Dmitry Gutov [this message]
2023-06-06 15:55 ` Spencer Baugh
2023-08-10 12:02 ` sbaugh
2023-08-12 1:23 ` Dmitry Gutov
2023-08-14 20:12 ` Spencer Baugh
2023-08-14 22:47 ` sbaugh
2023-08-16 1:49 ` Dmitry Gutov
2023-08-16 2:57 ` sbaugh
2023-08-17 2:14 ` Dmitry Gutov
2023-08-17 19:41 ` Spencer Baugh
2023-08-17 20:12 ` Spencer Baugh
2023-08-18 20:57 ` Spencer Baugh
2023-08-19 2:14 ` Dmitry Gutov
2023-08-20 17:23 ` Juri Linkov
2023-08-20 17:16 ` Juri Linkov
2023-08-21 1:15 ` Dmitry Gutov
2023-08-23 2:13 ` Dmitry Gutov
2023-08-19 2:08 ` Dmitry Gutov
2023-08-19 12:00 ` sbaugh
2023-08-21 1:51 ` Dmitry Gutov
2023-08-20 17:20 ` Juri Linkov
2023-08-21 1:43 ` Dmitry Gutov
2023-08-21 7:06 ` Juri Linkov
2023-08-23 0:37 ` Dmitry Gutov
2023-08-23 2:26 ` Dmitry Gutov
2023-08-23 17:52 ` Juri Linkov
2023-08-23 18:25 ` Dmitry Gutov
2023-08-20 17:13 ` Juri Linkov
2023-08-21 1:17 ` Dmitry Gutov
2023-08-21 6:58 ` Juri Linkov
2023-08-23 0:27 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e404df1-b3a9-f9e3-4270-f42df8b704c7@gutov.dev \
--to=dmitry@gutov.dev \
--cc=63829@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).