bug#14844: 24.3.50; `line-move-1': remove unused parameter _TO-END

bug#14844: 24.3.50; `line-move-1': remove unused parameter _TO-END

[Drew Adams]

Occam's razor says it should not be.

In GNU Emacs 24.3.50.1 (i686-pc-mingw32)
 of 2013-07-01 on LEG570
Bzr revision: 113246 lekktu@gmail.com-20130701165437-ea20s94hqwp3ttaj
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/usr --enable-checking CFLAGS='-O0 -g3'
 CPPFLAGS='-DGLYPH_DEBUG=1 -I/c/usr/include''

bug#14844: 24.3.50; `line-move-1': remove unused parameter _TO-END

[Drew Adams]

Worse.  It seems that the TO-END arg is not used *anywhere*, and should be
removed from `line-move' and `line-move-partial' as well.  Too bad these
functions do not even have doc strings to explain what was intended by the
creation of this unused parameter.

> Occam's razor says it should not be.

bug#14844: 24.3.50; `line-move-1': remove unused parameter _TO-END

[Drew Adams]

In addition, this unused parameter was apparently introduced in Emacs 22.
And it was *never even used then*, anywhere.
Its time has clearly come and gone.

> Worse.  It seems that the TO-END arg is not used *anywhere*, and should be
> removed from `line-move' and `line-move-partial' as well.  Too bad these
> functions do not even have doc strings to explain what was intended by the
> creation of this unused parameter.
> 
> > Occam's razor says it should not be.

bug#14844: 24.3.50; `line-move-1': remove unused parameter _TO-END

[Lars Ingebrigtsen]

Drew Adams <drew.adams@oracle.com> writes:

> Worse.  It seems that the TO-END arg is not used *anywhere*, and should be
> removed from `line-move' and `line-move-partial' as well.  Too bad these
> functions do not even have doc strings to explain what was intended by the
> creation of this unused parameter.

Well, it's certainly in the calls to it from simple.el:

grep --color -nH -e "line-move-1" `find . -name '*.el'`
./simple.el:5930:	  (line-move-1 arg noerror to-end)
./simple.el:5941:;; This is like line-move-1 except that it also performs
./simple.el:5955:      (line-move-1 arg noerror to-end)
./simple.el:5997:	(line-move-1 arg noerror to-end)))))
./simple.el:5999:;; Display-based alternative to line-move-1.
./simple.el:6071:(defun line-move-1 (arg &optional noerror _to-end)

I'll remove those from the calls, but I think the _to_end parameter will
have to remain in the -1 function.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#14844: 24.3.50; `line-move-1': remove unused parameter _TO-END

[Andreas Schwab]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> I'll remove those from the calls, but I think the _to_end parameter will
> have to remain in the -1 function.

line-move is a compiled Lisp function in ‘simple.el’.

(line-move ARG &optional NOERROR TO-END TRY-VSCROLL)

Move forward ARG lines.
If NOERROR, don’t signal an error if we can’t move ARG lines.
TO-END is unused.
^^^^^^^^^^^^^^^^

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

bug#14844: 24.3.50; `line-move-1': remove unused parameter _TO-END

[Lars Ingebrigtsen]

Andreas Schwab <schwab@linux-m68k.org> writes:

> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> I'll remove those from the calls, but I think the _to_end parameter will
>> have to remain in the -1 function.
>
> line-move is a compiled Lisp function in ‘simple.el’.
>
> (line-move ARG &optional NOERROR TO-END TRY-VSCROLL)
>
> Move forward ARG lines.
> If NOERROR, don’t signal an error if we can’t move ARG lines.
> TO-END is unused.
> ^^^^^^^^^^^^^^^^

I don't know what you're trying to express here.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no