From: Drew Adams <drew.adams@oracle.com>
To: Ivan Shmakov <ivan@siamics.net>, 18175@debbugs.gnu.org
Subject: bug#18175: files.el: use mapc in (mapcar 'switch-to-buffer ...)
Date: Sat, 2 Aug 2014 17:55:53 -0700 (PDT) [thread overview]
Message-ID: <3d8bb179-4e59-4d81-9ee1-54ff0da430b0@default> (raw)
In-Reply-To: <87r40yftes.fsf@violet.siamics.net>
> Given that switch-to-buffer returns its argument, /and/ given
> that mapc returns the sequence it’s given, I suggest that the
> (mapcar 'switch-to-buffer LIST) forms in lisp/files.el be
> replaced with (mapc 'switch-to-buffer LIST), – if only to avoid
> the unnecessary consing when the list is effectively copied in
> the mapcar case.
>
> The lists mapcar is applied to in such cases are returned from
> find-file-noselect, and so, as it seems, are “fresh” ones
> anyway.
Not a good idea, IMHO.
It's not just about performance; it's about coding style.
By using `mapcar' you are signaling that you are interested in the return values of the argument function (and of course the resulting list of them).
By using `mapc' you are signaling that the values returned by the argument function are unimportant (only its side effects are significant).
If you want to improve the performance, and that is the only change you want to make, then please consider another approach.
next prev parent reply other threads:[~2014-08-03 0:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-02 21:55 bug#18175: files.el: use mapc in (mapcar 'switch-to-buffer ...) Ivan Shmakov
2014-08-03 0:55 ` Drew Adams [this message]
2014-08-03 8:55 ` Ivan Shmakov
2014-08-03 16:32 ` Drew Adams
2014-08-03 18:25 ` Ivan Shmakov
2014-08-03 18:43 ` Drew Adams
2014-08-06 17:26 ` Stefan Monnier
2014-08-07 19:15 ` Ivan Shmakov
2014-08-07 19:29 ` Stefan Monnier
2015-01-23 15:27 ` Ivan Shmakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d8bb179-4e59-4d81-9ee1-54ff0da430b0@default \
--to=drew.adams@oracle.com \
--cc=18175@debbugs.gnu.org \
--cc=ivan@siamics.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).