From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.bugs Subject: bug#31355: 26.1; [PATCH] Fix remote-host/tramp directory tracking for shells in `term' buffers Date: Fri, 04 May 2018 01:52:09 +1200 Message-ID: <3d76a935822f56f94705b1f59421a00a@webmail.orcon.net.nz> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=_19c6dd1ad805c4506a27aef28672c7ca" X-Trace: blaine.gmane.org 1525355475 24917 195.159.176.226 (3 May 2018 13:51:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 3 May 2018 13:51:15 +0000 (UTC) User-Agent: Orcon Webmail To: 31355@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 03 15:51:11 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fEEdZ-0006KA-Ma for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 May 2018 15:51:09 +0200 Original-Received: from localhost ([::1]:56480 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEEff-0008DJ-17 for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 May 2018 09:53:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEEfR-00088g-8r for bug-gnu-emacs@gnu.org; Thu, 03 May 2018 09:53:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fEEfO-0004Fa-5o for bug-gnu-emacs@gnu.org; Thu, 03 May 2018 09:53:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39923) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fEEfO-0004FO-02 for bug-gnu-emacs@gnu.org; Thu, 03 May 2018 09:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fEEfN-0007Kc-NV for bug-gnu-emacs@gnu.org; Thu, 03 May 2018 09:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Phil Sainty Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 May 2018 13:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 31355 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.152535556628160 (code B ref -1); Thu, 03 May 2018 13:53:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 3 May 2018 13:52:46 +0000 Original-Received: from localhost ([127.0.0.1]:47820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fEEf8-0007K7-Dm for submit@debbugs.gnu.org; Thu, 03 May 2018 09:52:46 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:50547) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fEEf6-0007Ju-Ci for submit@debbugs.gnu.org; Thu, 03 May 2018 09:52:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fEEex-00044y-UQ for submit@debbugs.gnu.org; Thu, 03 May 2018 09:52:39 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:42439) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fEEex-00044q-PE for submit@debbugs.gnu.org; Thu, 03 May 2018 09:52:35 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41470) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEEes-0007nP-8G for bug-gnu-emacs@gnu.org; Thu, 03 May 2018 09:52:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fEEep-00040W-5G for bug-gnu-emacs@gnu.org; Thu, 03 May 2018 09:52:30 -0400 Original-Received: from smtp-3.orcon.net.nz ([60.234.4.44]:36614) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fEEeo-0003yj-Ho for bug-gnu-emacs@gnu.org; Thu, 03 May 2018 09:52:27 -0400 Original-Received: from [10.253.37.70] (port=43271 helo=webmail.orcon.net.nz) by smtp-3.orcon.net.nz with esmtpa (Exim 4.86_2) (envelope-from ) id 1fEEeX-0002ur-Dm for bug-gnu-emacs@gnu.org; Fri, 04 May 2018 01:52:21 +1200 Original-Received: from [150.107.175.243] via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Fri, 04 May 2018 01:52:09 +1200 X-Sender: psainty@orcon.net.nz X-GeoIP: -- X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145968 Archived-At: --=_19c6dd1ad805c4506a27aef28672c7ca Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed With tramp methods now being mandatory, the term.el directory tracking was generating invalid tramp paths on remote hosts. I've rolled a patch for this (along with some very minor improvements to the related commentary) in which I'm hard-coding the "ssh" method. I'm not sure whether that's the ideal fix, but I suspect it's likely to do the trick for most people, whereas the current code won't work at all. -Phil In GNU Emacs 26.1 (build 1, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2018-04-15 built on shodan Windowing system distributor 'The X.Org Foundation', version 11.0.11804000 System Description: Ubuntu 16.04.4 LTS Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. uncompressing term.el.gz...done C-c i is undefined Quit [3 times] Making completion list... [3 times] Quit [4 times] GNU Emacs 26.1 (build 1, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2018-04-15 Configured using: 'configure --prefix=/home/phil/emacs/26.1rc1/usr/local --with-x-toolkit=lucid --without-sound' Configured features: XAW3D XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK DBUS GSETTINGS NOTIFY GNUTLS LIBXML2 FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11 THREADS LCMS2 Important settings: value of $LANG: en_NZ.UTF-8 locale-coding-system: utf-8 Major mode: Dired by name Minor modes in effect: show-paren-mode: t minibuffer-depth-indicate-mode: t winner-mode: t global-hl-line-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr imenu misearch multi-isearch jka-compr thingatpt find-func emacsbug message rmc puny seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib format-spec rfc822 mml mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils dired-x easymenu paren mb-depth winner ring hl-line dired dired-loaddefs advice elec-pair time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 108228 20488) (symbols 48 20930 1) (miscs 40 423 129) (strings 32 31412 1231) (string-bytes 1 820395) (vectors 16 15792) (vector-slots 8 508466 10704) (floats 8 60 351) (intervals 56 1335 16) (buffers 992 17) (heap 1024 17853 1684)) --=_19c6dd1ad805c4506a27aef28672c7ca Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-Fix-remote-host-directory-tracking-for-shells-in-ter.patch Content-Disposition: attachment; filename=0001-Fix-remote-host-directory-tracking-for-shells-in-ter.patch; size=2878 RnJvbSA0YWU4MTFlMDUwOTAyMjgwZjZlZmYxOTU0MWRiNGIzMmY0ODQ4MTkwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsIFNhaW50eSA8cHNhaW50eUBvcmNvbi5uZXQubno+CkRh dGU6IEZyaSwgNCBNYXkgMjAxOCAwMToyOTo0MiArMTIwMApTdWJqZWN0OiBbUEFUQ0hdIEZpeCBy ZW1vdGUtaG9zdCBkaXJlY3RvcnkgdHJhY2tpbmcgZm9yIHNoZWxscyBpbiBgdGVybScKIGJ1ZmZl cnMKCiogbGlzcC90ZXJtLmVsICh0ZXJtLWhhbmRsZS1hbnNpLXRlcm1pbmFsLW1lc3NhZ2VzKTog VXNlIGV4cGxpY2l0CiJzc2giIHRyYW1wIG1ldGhvZCB3aGVuIGNvbnN0cnVjdGluZyB0aGUgdHJh bXAgcGF0aCBmb3IgYSBub24tbG9jYWwKaG9zdCwgYXMgYSBtZXRob2QgaXMgbm93IG1hbmRhdG9y eS4KCk1pbm9yIHJlbGF0ZWQgaW1wcm92ZW1lbnRzIHRvIHRoZSBjb21tZW50YXJ5LgotLS0KIGxp c3AvdGVybS5lbCB8IDI3ICsrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5n ZWQsIDE1IGluc2VydGlvbnMoKyksIDEyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Av dGVybS5lbCBiL2xpc3AvdGVybS5lbAppbmRleCA3NWMyNzc5Li5hOTcwNTcwIDEwMDY0NAotLS0g YS9saXNwL3Rlcm0uZWwKKysrIGIvbGlzcC90ZXJtLmVsCkBAIC0yMzMsMzEgKzIzMywzMyBAQAog OzsKIDs7ICBOb3RpY2U6IGZvciBkaXJlY3RvcnkvaG9zdC91c2VyIHRyYWNraW5nIHlvdSBuZWVk IHRvIGhhdmUgc29tZXRoaW5nCiA7OyBsaWtlIHRoaXMgaW4geW91ciBzaGVsbCBzdGFydHVwIHNj cmlwdCAodGhpcyBpcyBmb3IgYSBQT1NJWGlzaCBzaGVsbAotOzsgbGlrZSBCYXNoIGJ1dCBzaG91 bGQgYmUgcXVpdGUgZWFzeSB0byBwb3J0IHRvIG90aGVyIHNoZWxscykKKzs7IGxpa2UgQmFzaCBi dXQgc2hvdWxkIGJlIHF1aXRlIGVhc3kgdG8gcG9ydCB0byBvdGhlciBzaGVsbHMpLgorOzsKKzs7 IEZvciB0cm91Ymxlc2hvb3RpbmcgaW4gQmFzaCwgeW91IGNhbiBjaGVjayB0aGUgZGVmaW5pdGlv biBvZiB0aGUKKzs7IGN1c3RvbSBmdW5jdGlvbnMgd2l0aCB0aGUgInR5cGUiIGNvbW1hbmQuICBl LmcuICJ0eXBlIGNkIi4gIElmIHlvdQorOzsgZG8gbm90IHNlZSB0aGUgZXhwZWN0ZWQgZGVmaW5p dGlvbiBmcm9tIHRoZSBjb25maWcgYmVsb3csIHRoZW4gdGhlCis7OyBkaXJlY3RvcnkgdHJhY2tp bmcgd2lsbCBub3Qgd29yay4KIDs7CiA7OyAgICAgICAgICAgICAtLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tCiA7OwotOzsgICMgU2V0IEhPU1ROQU1FIGlmIG5vdCBhbHJl YWR5IHNldC4KKzs7CSMgU2V0IEhPU1ROQU1FIGlmIG5vdCBhbHJlYWR5IHNldC4KIDs7CTogJHtI T1NUTkFNRT0kKHVuYW1lIC1uKX0KIDs7Ci07OyAgIyBzdSBkb2VzIG5vdCBjaGFuZ2UgdGhpcyBi dXQgSSdkIGxpa2UgaXQgdG8KLTs7Cis7OwkjIHN1IGRvZXMgbm90IGNoYW5nZSB0aGlzIGJ1dCBJ J2QgbGlrZSBpdCB0bwogOzsJVVNFUj0kKHdob2FtaSkKIDs7Ci07OyAgIyAuLi4KKzs7CSMgLi4u CiA7OwogOzsJY2FzZSAkVEVSTSBpbgogOzsJICAgIGV0ZXJtKikKIDs7CiA7OwkJcHJpbnRmICcl c1xuJyBcCiA7OwkJIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tIFwKLTs7CQkgIkhlbGxvICR1c2VyIiBcCis7OwkJICJIZWxsbyAk VVNFUiIgXAogOzsJCSAiVG9kYXkgaXMgJChkYXRlKSIgXAogOzsJCSAiV2UgYXJlIG9uICRIT1NU TkFNRSBydW5uaW5nICQodW5hbWUpIHVuZGVyIEVtYWNzIHRlcm0gbW9kZSIgXAogOzsJCSAtLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LQogOzsKLTs7CQlleHBvcnQgRURJVE9SPWVtYWNzY2xpZW50Ci07OwogOzsJCSMgVGhlIFwwMzMg c3RhbmRzIGZvciBFU0MuCiA7OwkJIyBUaGVyZSBpcyBhIHNwYWNlIGJldHdlZW4gIkFuU2lUPyIg YW5kICR3aGF0ZXZlci4KIDs7CkBAIC0yNjksMTAgKzI3MSwxMSBAQAogOzsJCXByaW50ZiAnXDAz M0FuU2lUaCAlc1xuJyAiJEhPU1ROQU1FIgogOzsJCXByaW50ZiAnXDAzM0FuU2lUdSAlc1xuJyAi JFVTRVIiCiA7OwotOzsJCWV2YWwgJChkaXJjb2xvcnMgJEhPTUUvLmVtYWNzX2RpcmNvbG9ycykK Kzs7CQkjIFVzZSBjdXN0b20gZGlyY29sb3JzIGluIHRlcm0gYnVmZmVycy4KKzs7CQkjIGV2YWwg JChkaXJjb2xvcnMgJEhPTUUvLmVtYWNzX2RpcmNvbG9ycykKIDs7CWVzYWMKIDs7Ci07OyAgIyAu Li4KKzs7CSMgLi4uCiA7OwogOzsKIApAQCAtMjc1Myw4ICsyNzU2LDggQEAgdGVybS1oYW5kbGUt YW5zaS10ZXJtaW5hbC1tZXNzYWdlcwogCQkJCQkoc3RyaW5nPSB0ZXJtLWFuc2ktYXQtdXNlciAo dXNlci1yZWFsLWxvZ2luLW5hbWUpKSkKIAkJICAgKGV4cGFuZC1maWxlLW5hbWUgdGVybS1hbnNp LWF0LWRpcikKIAkJIChpZiAoc3RyaW5nPSB0ZXJtLWFuc2ktYXQtdXNlciAodXNlci1yZWFsLWxv Z2luLW5hbWUpKQotCQkgICAgIChjb25jYXQgIi8iIHRlcm0tYW5zaS1hdC1ob3N0ICI6IiB0ZXJt LWFuc2ktYXQtZGlyKQotCQkgICAoY29uY2F0ICIvIiB0ZXJtLWFuc2ktYXQtdXNlciAiQCIgdGVy bS1hbnNpLWF0LWhvc3QgIjoiCisgICAgICAgICAgICAgICAgICAgICAoY29uY2F0ICIvc3NoOiIg dGVybS1hbnNpLWF0LWhvc3QgIjoiIHRlcm0tYW5zaS1hdC1kaXIpCisgICAgICAgICAgICAgICAg ICAgKGNvbmNhdCAiL3NzaDoiIHRlcm0tYW5zaS1hdC11c2VyICJAIiB0ZXJtLWFuc2ktYXQtaG9z dCAiOiIKIAkJCSAgIHRlcm0tYW5zaS1hdC1kaXIpKSkpKQogCiAJOzsgSSdtIG5vdCBzdXJlIHRo aXMgaXMgbmVjZXNzYXJ5LAotLSAKMi44LjMKCg== --=_19c6dd1ad805c4506a27aef28672c7ca--