unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#43385: 27.1; Regression in `find-library'
@ 2020-09-13 21:25 Drew Adams
  2020-09-13 23:25 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 7+ messages in thread
From: Drew Adams @ 2020-09-13 21:25 UTC (permalink / raw)
  To: 43385

emacs -Q

M-x find-library RET mouse. TAB

No match.  It should show mouse.el and mouse.elc as completions.

This is a regression.

In GNU Emacs 27.1 (build 1, x86_64-w64-mingw32)
 of 2020-08-12 built on CIRROCUMULUS
Repository revision: 86d8d76aa36037184db0b2897c434cdaab1a9ae8
Repository branch: HEAD
Windowing system distributor 'Microsoft Corp.', version 10.0.18362
System Description: Microsoft Windows 10 Pro (v10.0.1903.18362.1016)





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#43385: 27.1; Regression in `find-library'
  2020-09-13 21:25 bug#43385: 27.1; Regression in `find-library' Drew Adams
@ 2020-09-13 23:25 ` Lars Ingebrigtsen
  2020-09-13 23:49   ` Drew Adams
  2020-09-14 14:48   ` Eli Zaretskii
  0 siblings, 2 replies; 7+ messages in thread
From: Lars Ingebrigtsen @ 2020-09-13 23:25 UTC (permalink / raw)
  To: Drew Adams; +Cc: 43385

Drew Adams <drew.adams@oracle.com> writes:

> emacs -Q
>
> M-x find-library RET mouse. TAB
>
> No match.  It should show mouse.el and mouse.elc as completions.

No, it shouldn't -- it should complete over library names, and the
library name is "mouse", not "mouse.el" or "mouse.elc".

(Closing this bug report.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#43385: 27.1; Regression in `find-library'
  2020-09-13 23:25 ` Lars Ingebrigtsen
@ 2020-09-13 23:49   ` Drew Adams
  2020-09-14 15:04     ` Drew Adams
  2020-09-14 14:48   ` Eli Zaretskii
  1 sibling, 1 reply; 7+ messages in thread
From: Drew Adams @ 2020-09-13 23:49 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: 43385

> > emacs -Q
> >
> > M-x find-library RET mouse. TAB
> >
> > No match.  It should show mouse.el and mouse.elc as completions.
> 
> No, it shouldn't -- it should complete over library names, and the
> library name is "mouse", not "mouse.el" or "mouse.elc".
> 
> (Closing this bug report.)

I _really_ disagree.  The latter has always been the
behavior, since Day One.

It allows you to load either the .el or the .elc, au
choix, without needing to specify or even know where
those are located.

You CAN just provide the base name, with no extension,
which picks up one or the other, according to the
well-documented lookup behavior.  That too is a feature.

But it's just as much a feature to be able to specify
which one you want to load.  This is about LOADING.
Loading Lisp code can involve loading source or
byte-compiled code.  Users should be able to control
which gets loaded, when both are available (in the
`load-path').

All three, mouse, mouse.el, and mouse.elc, are library
names - ways to refer to a library.  Interactively, the
first is a shortcut for a complex lookup procedure to
get to one of the others.

This is a definite step backward, an incompatible
change - a regression that hurts users.  (And it's not
even called out in NEWS as an intentional change.)

I can't believe that you would defend this as an
improvement.  I've been able to specify which I want
since 1985.





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#43385: 27.1; Regression in `find-library'
  2020-09-13 23:25 ` Lars Ingebrigtsen
  2020-09-13 23:49   ` Drew Adams
@ 2020-09-14 14:48   ` Eli Zaretskii
  2020-09-14 14:51     ` Lars Ingebrigtsen
  1 sibling, 1 reply; 7+ messages in thread
From: Eli Zaretskii @ 2020-09-14 14:48 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: 43385

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Mon, 14 Sep 2020 01:25:01 +0200
> Cc: 43385@debbugs.gnu.org
> 
> Drew Adams <drew.adams@oracle.com> writes:
> 
> > emacs -Q
> >
> > M-x find-library RET mouse. TAB
> >
> > No match.  It should show mouse.el and mouse.elc as completions.
> 
> No, it shouldn't -- it should complete over library names, and the
> library name is "mouse", not "mouse.el" or "mouse.elc".

So you think this change from what Emacs 26.3 did is intentional?  Is
there some NEWS item to describe it?  And which change modified this
behavior?

In general, "M-x load-library RET" definitely does accept mouse.el, so
I'm not sure the current behavior is correct, or even intentional.





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#43385: 27.1; Regression in `find-library'
  2020-09-14 14:48   ` Eli Zaretskii
@ 2020-09-14 14:51     ` Lars Ingebrigtsen
  0 siblings, 0 replies; 7+ messages in thread
From: Lars Ingebrigtsen @ 2020-09-14 14:51 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 43385

Eli Zaretskii <eliz@gnu.org> writes:

> So you think this change from what Emacs 26.3 did is intentional?  Is
> there some NEWS item to describe it?  And which change modified this
> behavior?
>
> In general, "M-x load-library RET" definitely does accept mouse.el, so
> I'm not sure the current behavior is correct, or even intentional.

That bit was intentional, but has now been reverted, because (in a
related bug report from Stefan) it was reported that it failed to
complete "org/o" now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#43385: 27.1; Regression in `find-library'
  2020-09-13 23:49   ` Drew Adams
@ 2020-09-14 15:04     ` Drew Adams
  0 siblings, 0 replies; 7+ messages in thread
From: Drew Adams @ 2020-09-14 15:04 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: 43385

> > No, it shouldn't -- it should complete over library names, and the
> > library name is "mouse", not "mouse.el" or "mouse.elc".
> >
> > (Closing this bug report.)
> 
> I _really_ disagree.  The latter has always been the
> behavior, since Day One.
> 
> It allows you to load either the .el or the .elc, au
> choix, without needing to specify or even know where
> those are located.
> 
> You CAN just provide the base name, with no extension,
> which picks up one or the other, according to the
> well-documented lookup behavior.  That too is a feature.
> 
> But it's just as much a feature to be able to specify
> which one you want to load.  This is about LOADING.
> Loading Lisp code can involve loading source or
> byte-compiled code.  Users should be able to control
> which gets loaded, when both are available (in the
> `load-path').
> 
> All three, mouse, mouse.el, and mouse.elc, are library
> names - ways to refer to a library.  Interactively, the
> first is a shortcut for a complex lookup procedure to
> get to one of the others.
> 
> This is a definite step backward, an incompatible
> change - a regression that hurts users.  (And it's not
> even called out in NEWS as an intentional change.)
> 
> I can't believe that you would defend this as an
> improvement.  I've been able to specify which I want
> since 1985.

I spoke here of "loading", not "finding" the library.
Sorry, that was a mistake.  (And `find-library', unlike
`load-library', which I was thinking of there, didn't
exist in 1985.)

But it points out precisely the problem.  `load-library'
does NOT have this regression.  Your argument about the
library being only "mouse" clearly doesn't apply for
`load-library': you can do `M-x load-library mouse. TAB'
and you get the expected completions.

`find-library' should behave the same way, as it always
has, before this regression.  Please reconsider.  Thx.





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#43385: 27.1; Regression in `find-library'
       [not found]   ` <<835z8gbej2.fsf@gnu.org>
@ 2020-09-14 15:19     ` Drew Adams
  0 siblings, 0 replies; 7+ messages in thread
From: Drew Adams @ 2020-09-14 15:19 UTC (permalink / raw)
  To: Eli Zaretskii, Lars Ingebrigtsen; +Cc: 43385

> > > emacs -Q
> > >
> > > M-x find-library RET mouse. TAB
> > >
> > > No match.  It should show mouse.el and mouse.elc as completions.
> >
> > No, it shouldn't -- it should complete over library names, and the
> > library name is "mouse", not "mouse.el" or "mouse.elc".
> 
> So you think this change from what Emacs 26.3 did is intentional?  Is
> there some NEWS item to describe it?  And which change modified this
> behavior?
> 
> In general, "M-x load-library RET" definitely does accept mouse.el, so
> I'm not sure the current behavior is correct, or even intentional.

To be clear, I confused things by speaking of
"loading" the library.  I myself lost track of
the fact that this bug report is instead about
`find-library'.  `load-library' does not have
the problem (regression) that `find-library'
suffers from.  I think `find-library' should
be fixed to behave as before, which is similar
to how `load-library' behaves.





^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-09-14 15:19 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-13 21:25 bug#43385: 27.1; Regression in `find-library' Drew Adams
2020-09-13 23:25 ` Lars Ingebrigtsen
2020-09-13 23:49   ` Drew Adams
2020-09-14 15:04     ` Drew Adams
2020-09-14 14:48   ` Eli Zaretskii
2020-09-14 14:51     ` Lars Ingebrigtsen
     [not found] <<3d23db5a-732d-4ea5-9d07-c25bc4f773ae@default>
     [not found] ` <<87zh5tdzua.fsf@gnus.org>
     [not found]   ` <<835z8gbej2.fsf@gnu.org>
2020-09-14 15:19     ` Drew Adams

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).