From: Ken Brown <kbrown@cornell.edu>
To: martin rudalics <rudalics@gmx.at>,
Dani Moncayo <dmoncayo@gmail.com>, Eli Zaretskii <eliz@gnu.org>
Cc: Lars Magne Ingebrigtsen <larsi@gnus.org>,
25542@debbugs.gnu.org,
Noam Postavsky <npostavs@users.sourceforge.net>
Subject: bug#25542: 25.1; Restoring the frame from fullscreen to maximized
Date: Thu, 10 Sep 2020 15:04:29 -0400 [thread overview]
Message-ID: <3cea3f08-d87c-03a0-4b0b-b54f3ea63149@cornell.edu> (raw)
In-Reply-To: <a0363119-8d5f-5db8-7bd5-6e450d61e4dd@gmx.at>
On 9/10/2020 2:16 PM, martin rudalics wrote:
> >> (2) Does 'toggle-frame-fullscreen' the second time when you type F11
> >> correctly call
> >>
> >> (set-frame-parameter frame 'fullscreen fullscreen-restore)
> >>
> >> with 'fullscreen-restore' equal to 'maximized' at all?
> >
> > No. The value of 'fullscreen-restore' is nil. But if I repeat the
> experiment with the taskbar on the bottom, the value of fullscreen-restore is
> 'maximized'.
>
> Thanks for telling me what I forgot to ask. IIUC this means that after
> maximizing the frame with the mouse, the value of
>
> (frame-parameter nil 'fullscreen)
>
> is nil. Correct?
Yes.
> And what is its value if, instead, you maximize the
> frame via 'toggle-frame-maximized'?
maximized.
> In either case the bug should be a consequence of the earlier mentioned
>
> if (x < 0 && y < 0)
> store_frame_param (f, Qfullscreen, Qmaximized);
>
> so we do not remember in the fullscreen parameter that the frame has
> been maximized. Apparently some check _is_ needed (why?) so probably
> using
>
> if (x < 0 || y < 0)
> store_frame_param (f, Qfullscreen, Qmaximized);
>
> instead will fix it. Can you try that (as I said elsewhere it will then
> fail for borderless, maximized frames)?
Yes, that does fix it. I haven't tried to test anything involving borderless
frames.
Ken
next prev parent reply other threads:[~2020-09-10 19:04 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 8:15 bug#25542: 25.1; Restoring the frame from fullscreen to maximized Dani Moncayo
2017-01-26 9:51 ` martin rudalics
2017-01-26 10:20 ` Dani Moncayo
2017-01-26 10:54 ` Dani Moncayo
2017-01-26 17:49 ` Dani Moncayo
2017-01-26 18:02 ` Noam Postavsky
2017-01-26 19:06 ` martin rudalics
2017-01-27 7:54 ` Dani Moncayo
2017-01-27 9:18 ` martin rudalics
2017-01-26 14:00 ` martin rudalics
2017-01-26 15:43 ` Noam Postavsky
2017-01-26 16:10 ` Eli Zaretskii
2017-01-27 8:03 ` Dani Moncayo
2017-01-27 8:16 ` Eli Zaretskii
2017-01-27 8:22 ` Dani Moncayo
2017-01-27 9:19 ` martin rudalics
2017-01-27 9:25 ` Dani Moncayo
2017-01-27 9:31 ` Dani Moncayo
2017-01-27 9:50 ` martin rudalics
2017-01-27 10:22 ` Dani Moncayo
2017-01-27 10:27 ` Dani Moncayo
2017-01-27 9:34 ` martin rudalics
2017-01-27 10:01 ` Dani Moncayo
2017-01-27 13:47 ` martin rudalics
2017-01-27 18:50 ` Noam Postavsky
2017-01-28 8:02 ` martin rudalics
2020-09-04 12:32 ` Lars Ingebrigtsen
2020-09-04 17:50 ` Dani Moncayo
2020-09-05 6:46 ` Eli Zaretskii
2020-09-05 11:59 ` Dani Moncayo
2020-09-05 12:17 ` Eli Zaretskii
2020-09-05 12:19 ` Dani Moncayo
2020-09-05 12:30 ` Eli Zaretskii
2020-09-05 12:32 ` Dani Moncayo
2020-09-05 12:48 ` Eli Zaretskii
2020-09-05 15:10 ` Ken Brown
2020-09-05 16:07 ` Eli Zaretskii
2020-09-05 16:10 ` Ken Brown
2020-09-05 16:41 ` Eli Zaretskii
2020-09-09 8:44 ` martin rudalics
2020-09-09 16:46 ` Dani Moncayo
2020-09-09 18:19 ` Ken Brown
2020-09-09 20:24 ` Ken Brown
2020-09-10 7:16 ` martin rudalics
2020-09-10 15:05 ` Ken Brown
2020-09-10 18:16 ` martin rudalics
2020-09-10 19:04 ` Ken Brown [this message]
2020-09-11 7:53 ` martin rudalics
2020-09-11 20:16 ` Ken Brown
2020-09-11 20:33 ` Achim Gratz
2020-09-11 21:18 ` Ken Brown
2020-09-12 6:54 ` martin rudalics
2020-09-12 11:37 ` Ken Brown
2020-09-12 6:54 ` martin rudalics
2020-09-12 6:06 ` Eli Zaretskii
2020-09-12 6:54 ` martin rudalics
2017-01-26 16:08 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cea3f08-d87c-03a0-4b0b-b54f3ea63149@cornell.edu \
--to=kbrown@cornell.edu \
--cc=25542@debbugs.gnu.org \
--cc=dmoncayo@gmail.com \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
--cc=npostavs@users.sourceforge.net \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).