From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Konstantin Kharlamov Newsgroups: gmane.emacs.bugs Subject: bug#75065: Upon archive download failure print the original error Date: Fri, 27 Dec 2024 21:34:30 +0300 Message-ID: <3c76908be3fea66640bded9494013d1393bc660c.camel@yandex.ru> References: <4361fa59c17dc06b285fea25f025a9e86f81d1fe.camel@yandex.ru> <867c7mzuva.fsf@gnu.org> <87bjwytis3.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38925"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.54.2 Cc: 75065-done@debbugs.gnu.org, Eli Zaretskii To: Stefan Monnier , Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 27 19:35:19 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tRFB9-000A04-81 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 Dec 2024 19:35:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tRFAv-0003YJ-QT; Fri, 27 Dec 2024 13:35:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRFAt-0003VL-2l for bug-gnu-emacs@gnu.org; Fri, 27 Dec 2024 13:35:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tRFAs-0005JS-P2 for bug-gnu-emacs@gnu.org; Fri, 27 Dec 2024 13:35:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:Date:From:To:Subject; bh=KKYCMXpnrWgKh43Bzb4eKcOk4AWcW9H8A5R6Go2N9R8=; b=l0hfRfxs8iSGlQjO71uA2VJ6BDIKCVNDg0A6hBTNUAAhKBkh6ERHk/9lXEzQUeSD0YFxpMCcXKOUBwX4UT1caBk+8V8yD83MDEcw9do3HtVg1MAPdnyqBnUnl9A5/AKppaar5lzKEfVS0bnATlBZlaTov2qXuh1kG4pDRfh0Qg+IefzX5U3CrydAFK5WwkUCdvvYKyex1PxlJfbk7eefU1a+ZdU6LpkBdhkyOZvXMl1Uy7agiX02CWAupf7pmLt1OB9vhlyt/9zQV6jtCeq3txvVnespJNdxiAIf+LBglAKTvBZohkhQb0Br/TZpc1OXQ/DOalFYQmuHjl4Z6RaUwg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tRFAr-00084h-Lt for bug-gnu-emacs@gnu.org; Fri, 27 Dec 2024 13:35:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Konstantin Kharlamov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Dec 2024 18:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75065 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 75065-done@debbugs.gnu.org id=D75065.173532448131006 (code D ref 75065); Fri, 27 Dec 2024 18:35:01 +0000 Original-Received: (at 75065-done) by debbugs.gnu.org; 27 Dec 2024 18:34:41 +0000 Original-Received: from localhost ([127.0.0.1]:47559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRFAX-000842-AO for submit@debbugs.gnu.org; Fri, 27 Dec 2024 13:34:41 -0500 Original-Received: from forward502a.mail.yandex.net ([178.154.239.82]:50106) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRFAV-00083o-0j for 75065-done@debbugs.gnu.org; Fri, 27 Dec 2024 13:34:40 -0500 Original-Received: from mail-nwsmtp-smtp-production-main-52.vla.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-52.vla.yp-c.yandex.net [IPv6:2a02:6b8:c0d:9:0:640:2d51:0]) by forward502a.mail.yandex.net (Yandex) with ESMTPS id 414E7612E4; Fri, 27 Dec 2024 21:34:33 +0300 (MSK) Original-Received: by mail-nwsmtp-smtp-production-main-52.vla.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id UYfQmb4OmmI0-ScDP7UCS; Fri, 27 Dec 2024 21:34:32 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1735324472; bh=KKYCMXpnrWgKh43Bzb4eKcOk4AWcW9H8A5R6Go2N9R8=; h=References:Date:In-Reply-To:Cc:To:From:Subject:Message-ID; b=t9E21ZqQV7B1Jm4cFUzgAFKCkp3UXqaQtxOd4oZF19Hdg7meq6WIwQRphA0m/kajT yF75pdkH9U+v4zMoPIrQTWYLhpi5w7LohbHbd+/C3ja6eTFh2h1VvEvGadOixQR8SY bATxIMA851/MWiIeS1G3GsFl4bNEr5Ix8WdyhQOo= Authentication-Results: mail-nwsmtp-smtp-production-main-52.vla.yp-c.yandex.net; dkim=pass header.i=@yandex.ru In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297841 Archived-At: On Fri, 2024-12-27 at 12:01 -0500, Stefan Monnier wrote: > > `%s` to print `err` or `(cdr err)` would be wrong, since `%s` is > > for use > > with strings rather than lists.=C2=A0 IOW, IMO, it should be either > >=20 > > =C2=A0=C2=A0=C2=A0 ...%S" ... err) > >=20 > > or > >=20 > > =C2=A0=C2=A0=C2=A0 ...%s" ... (error-message-string err)) > >=20 > > where the first is a bit more "debugging/developer" friendly and > > the second > > is a bit more "user" friendly. >=20 > Revising the code of `package.el` I see that those errors&messages > are > meant to be exposed to the user, so they should preferably use > `error-message-string`. >=20 > So I installed the patch below into `master`. > Thank you! This is not fair: despite me actively answering on my patch, you took my changes, just changed one function call to another, and rewritten the author like if it were you who were writing and debugging the code and the issue rather than me.