From: Konstantin Kharlamov <Hi-Angel@yandex.ru>
To: Stefan Monnier <monnier@iro.umontreal.ca>,
Philip Kaludercic <philipk@posteo.net>
Cc: 75065-done@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#75065: Upon archive download failure print the original error
Date: Fri, 27 Dec 2024 21:34:30 +0300 [thread overview]
Message-ID: <3c76908be3fea66640bded9494013d1393bc660c.camel@yandex.ru> (raw)
In-Reply-To: <jwvseq96p0c.fsf-monnier+emacs@gnu.org>
On Fri, 2024-12-27 at 12:01 -0500, Stefan Monnier wrote:
> > `%s` to print `err` or `(cdr err)` would be wrong, since `%s` is
> > for use
> > with strings rather than lists. IOW, IMO, it should be either
> >
> > ...%S" ... err)
> >
> > or
> >
> > ...%s" ... (error-message-string err))
> >
> > where the first is a bit more "debugging/developer" friendly and
> > the second
> > is a bit more "user" friendly.
>
> Revising the code of `package.el` I see that those errors&messages
> are
> meant to be exposed to the user, so they should preferably use
> `error-message-string`.
>
> So I installed the patch below into `master`.
> Thank you!
This is not fair: despite me actively answering on my patch, you took
my changes, just changed one function call to another, and rewritten
the author like if it were you who were writing and debugging the code
and the issue rather than me.
next prev parent reply other threads:[~2024-12-27 18:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-24 15:25 bug#75065: Upon archive download failure print the original error Konstantin Kharlamov
2024-12-26 8:55 ` Eli Zaretskii
2024-12-26 18:13 ` Philip Kaludercic
2024-12-26 18:17 ` Konstantin Kharlamov
2024-12-26 18:31 ` Philip Kaludercic
2024-12-26 19:17 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-26 20:14 ` Konstantin Kharlamov
2024-12-26 20:32 ` Stefan Kangas
2024-12-26 20:37 ` Konstantin Kharlamov
2024-12-26 20:40 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-26 20:51 ` Konstantin Kharlamov
2024-12-26 20:53 ` Konstantin Kharlamov
2024-12-26 21:03 ` Konstantin Kharlamov
2024-12-27 7:22 ` Eli Zaretskii
2024-12-27 17:01 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-27 18:34 ` Konstantin Kharlamov [this message]
2024-12-28 3:09 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c76908be3fea66640bded9494013d1393bc660c.camel@yandex.ru \
--to=hi-angel@yandex.ru \
--cc=75065-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).