bug#23203: 25.0.91; some loaddefs files have auto-save remnants after building (and install doesn't ignore them)

["Phillip Lord" <phillip.lord@russet.org.uk>]

[-- Attachment #1: Type: text/plain, Size: 664 bytes --]

On Sun, April 3, 2016 12:47 pm, Achim Gratz wrote:
> Andreas Schwab writes:
>
>> Achim Gratz writes:
>>
>>> as there is no point of having a backup for an auto-generated file.
>>
>> I disagree.  Even for generated files you may want to check what has
>> changed when last regenerated.
>
> There was no previous version, this being a bootstrap build.  And if I
> want to check differences between builds, I can just use different build
> directories.

The attached patch fixes the problem in my hands (assuming we believe that
this is a bug). The solution may be a bit blunt, though, although the
function patched is documented as "use in batch during build".

Phil

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fix.diff --]
[-- Type: text/x-patch; name="fix.diff", Size: 629 bytes --]

diff --git a/lisp/emacs-lisp/autoload.el b/lisp/emacs-lisp/autoload.el
index e688d6b..bc7873b 100644
--- a/lisp/emacs-lisp/autoload.el
+++ b/lisp/emacs-lisp/autoload.el
@@ -870,6 +870,9 @@ batch-update-autoloads
   ;; Exclude those files that are preloaded on ALL platforms.
   ;; These are the ones in loadup.el where "(load" is at the start
   ;; of the line (crude, but it works).
+  ;; Stop the production of backup files which make little sense
+  ;; during the build process.
+  (setq make-backup-files nil)
   (unless autoload-excludes
     (let ((default-directory (file-name-directory generated-autoload-file))
 	  file)