From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#35133: 26.1; 1) `:tag' for `restricted-sexp' (not in a choice, set, etc.), 2) Remove `Value Menu' if a no-op Date: Wed, 9 Dec 2020 15:30:43 -0800 (PST) Message-ID: <3bae30db-9eb9-4185-b549-1cdfd60efc59@default> References: <4bd9e603-0d75-4de4-9bd3-6fa94a96e8a4@default> <87360f2fsp.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30110"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 35133@debbugs.gnu.org To: Mauro Aranda , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 10 00:33:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kn8xL-0007cT-KY for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Dec 2020 00:33:11 +0100 Original-Received: from localhost ([::1]:53046 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kn8xK-0003Az-An for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Dec 2020 18:33:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43354) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kn8xC-0003Ap-7I for bug-gnu-emacs@gnu.org; Wed, 09 Dec 2020 18:33:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53216) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kn8xC-0000TW-00 for bug-gnu-emacs@gnu.org; Wed, 09 Dec 2020 18:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kn8xB-0006GF-SU for bug-gnu-emacs@gnu.org; Wed, 09 Dec 2020 18:33:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Dec 2020 23:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35133 X-GNU-PR-Package: emacs Original-Received: via spool by 35133-submit@debbugs.gnu.org id=B35133.160755678024060 (code B ref 35133); Wed, 09 Dec 2020 23:33:01 +0000 Original-Received: (at 35133) by debbugs.gnu.org; 9 Dec 2020 23:33:00 +0000 Original-Received: from localhost ([127.0.0.1]:36529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kn8x9-0006Fz-NI for submit@debbugs.gnu.org; Wed, 09 Dec 2020 18:32:59 -0500 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:51990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kn8x8-0006Fm-Jw for 35133@debbugs.gnu.org; Wed, 09 Dec 2020 18:32:59 -0500 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0B9NPNh4164877; Wed, 9 Dec 2020 23:32:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=sL/qnFf9gCa71ghptm6C1G+TQiMDcZa6ppMR2QxwAQw=; b=FgcrsgPtmX0t8tM8FRhzPiCG3rpEIkCM6rlC1GftT9VSdumteLNRTRQrqnTGYHBjj3UG Ct7KOH31FSRmcYPdM/tWOThXfGEDT+PPHYzCeSrkeChCPOJBBc7jniFTk2MGSqbOzddf kmFBiEUYwj1Rs7jhu/uFTqE7ESUe8o2utMZ3Qc/69geo3oeKw5s8k6i2jiPbljVBPcmv C4VaJai2CCJUSP2R4ptkRQMkwYNQ2l/lAZOG1j3IIrjL0lNkYhCAl7pKdHsMU0mR0qy3 82jeiUmtzy1RwaB1an4+xc4iYwImnwyfbltfBwhzndA2xRS8m660Q0jJ0QIXQT7SgxXa Wg== Original-Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 35825mavfg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 09 Dec 2020 23:32:52 +0000 Original-Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0B9NUqJ8168106; Wed, 9 Dec 2020 23:30:52 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 358ksqt9fw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Dec 2020 23:30:52 +0000 Original-Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0B9NUhcb003540; Wed, 9 Dec 2020 23:30:43 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5071.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9830 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=949 suspectscore=0 bulkscore=0 malwarescore=0 phishscore=0 mlxscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012090162 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9830 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 bulkscore=0 phishscore=0 mlxlogscore=959 clxscore=1011 priorityscore=1501 mlxscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012090161 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195606 Archived-At: > Not much time until the weekend, I'm afraid. > > Dropping the tag is intentional, in custom-variable-value-create: > (push (widget-create-child-and-convert >=C2=A0 =C2=A0widget type >=C2=A0 =C2=A0:format value-format >=C2=A0 =C2=A0 ^^^^^^^^^^^^^^^^^^^ >=C2=A0 =C2=A0:value value) >=C2=A0 children)) > > I suppose we could stop overriding the :format property, but for some > widgets overriding it might make sense.=C2=A0 For example, for the choice > widget, deleting the :format value-format line would create the > following: > > Foo: Choice: [Value Menu] The-Tag: > > Which isn't good, IMO.=C2=A0 Other customization types I can think of tha= t we > should pay attention if we go with this change would be: repeat, set and > radio. > > I think that those three, if we print their tag, won't give too much > valuable information about the variable.=C2=A0 =C2=A0I mean, we'd end up = with > something like this: > > Foo: Repeat: > [INS] [DEL] Something > [INS] > > And any user may ask what does "repeat" mean.=C2=A0 Maybe changing the ta= gs > to something slightly more useful is all we need, and with this change > the Custom buffer will show the customization type of the variable to > the user, which looks like a win to me.=C2=A0 What do you think about the > "problematic" tags? Thanks for looking into this Mauro. I'd suggest handling this in two stages: 1. Take care of what is clearly, or pretty clearly, straightforward. 2. Think about how to handle other cases. ____ But in general, for defcustom I think I'm in favor of allowing the realization of a :tag, regardless of whether using it might be problematic sometimes. After all, using :tag is optional. If the result isn't helpful, someone won't use it. But I guess you're asking about default tags? What happens if there's no default :tag for some widget (such as `repeat') but when you use the widget you provide a :tag? Would that be possible? IOW, maybe a :tag for `repeat' isn't useful by default, but maybe adding a :tag when you use some `repeat' could be useful. (For the problematic cases, maybe the tag text should be shown without the trailing colon? Maybe it depends on where the tag is placed and how long the string is.) Anyway, for now at least, #1 would be great. Thx.