From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock Date: Sun, 19 Nov 2023 16:31:22 +0200 Message-ID: <3bad2052-286b-8532-b9ae-72e8278d5ff3@gutov.dev> References: <83sf5g1lko.fsf@gnu.org> <9d460f36-6035-da54-3abc-12171ac8977f@gutov.dev> <83h6lw19zw.fsf@gnu.org> <894f674f-76ea-90af-3acc-73ca6e7caf35@gutov.dev> <834jhv1lfw.fsf@gnu.org> <83ttpvyxn0.fsf@gnu.org> <42fe7d0e-024c-3e0d-3bc5-b0e6ec50f260@gutov.dev> <83r0kzyo93.fsf@gnu.org> <4b4a190a-ec88-6f50-1f94-900b3afdfc41@gutov.dev> <87sf53m59w.fsf@catern.com> <83a5rbm3j9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17376"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: sbaugh@janestreet.com, 66993@debbugs.gnu.org To: Eli Zaretskii , sbaugh@catern.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 19 15:32:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r4iqQ-0004Jo-87 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Nov 2023 15:32:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r4iqH-0002Hv-0W; Sun, 19 Nov 2023 09:32:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r4iqA-0002Gp-PX for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2023 09:32:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r4iq8-0007sI-M9 for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2023 09:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r4iq9-0007yz-UU for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2023 09:32:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Nov 2023 14:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66993-submit@debbugs.gnu.org id=B66993.170040429630649 (code B ref 66993); Sun, 19 Nov 2023 14:32:01 +0000 Original-Received: (at 66993) by debbugs.gnu.org; 19 Nov 2023 14:31:36 +0000 Original-Received: from localhost ([127.0.0.1]:50239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4ipj-0007yH-Ns for submit@debbugs.gnu.org; Sun, 19 Nov 2023 09:31:36 -0500 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:60331) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4iph-0007y3-64 for 66993@debbugs.gnu.org; Sun, 19 Nov 2023 09:31:34 -0500 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7035E5C020F; Sun, 19 Nov 2023 09:31:26 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 19 Nov 2023 09:31:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1700404286; x=1700490686; bh=QN/6uqUSU0zIgC8iMDOU38+nk7tQ7DPgsCI hX20eHf0=; b=oyXA5uL11SyCJTh8ujXGNXwu6zE0ispPFimuj73zMmbPfctJKmv eWj7CiF0xv2YOX3RAbrBA2dd2mgJ9Watey4p2xDi1jufiBSkhju5JSMmGlHLmoLR 95tiAmPyi9fre+VM4yDuHXbPjwS1RboLoRbu1NhSyQJUsAUTcP24ENozoZb2G7lv 8kR4ol6O9GhNMjBtFp6zaAgYpaFgT6HbLxq0aVMix3ExkKXbDmkWuDOKt5hEBoNR yjgkJHqyhO3LPMJvLmb5Dm1mlSlJTAYnuMbun5n9udGFOmdaD7swOY3jkrbsOYUV RQNu/y+bVEJOkCZcAVLi3eBZFFLMnC7t/zQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1700404286; x=1700490686; bh=QN/6uqUSU0zIgC8iMDOU38+nk7tQ7DPgsCI hX20eHf0=; b=KL5MMb0YcOva+f55ex6l6Hnd8jbg1TWoc0MQzggNz8ihfNdCwNR puPE4HLLOTl7RpayuKft/9Rf078wwAbfJJkbKeEWwZNzH32/dabcg0dDWPCETi0k 1J3NWb7HulJ3vadRHxhLVoa2BD5HvhOJvvE+VB0Nf3gJNtqxnoNQ+AtyG0Mp5/TK dbvfpX4vB9+a6I6RxEn1DIWQOK8ykkoAbA4D8PXeoZRCEhq3+5tC9Rs2jB2WL+9o gPpja24VnWYTMWPgt5eYLNCg2Xu6pf0gxekDwphWrWcJVFX0WDIfIbLzfjibQfW3 XCz0cF9JCO/s+8DiDflBBjutHmHnq+in6fg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeggedgieeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 19 Nov 2023 09:31:24 -0500 (EST) Content-Language: en-US In-Reply-To: <83a5rbm3j9.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274618 Archived-At: On 18/11/2023 18:26, Eli Zaretskii wrote: >> From:sbaugh@catern.com >> Date: Sat, 18 Nov 2023 15:48:33 +0000 (UTC) >> Cc: Spencer Baugh, Eli Zaretskii, >> 66993@debbugs.gnu.org >> >>> What happens if savehist-mode is nil, though? Which it is by >>> default. For users with this setup the project history will just >>> disappear. >> Indeed. >> >>> What kind of backward compatibility did you have in mind? >> I was thinking about either keeping our code for saving to >> project-list-file around in some obsoleted form, or using a subset of >> the savehist code to save only project--list when it's not otherwise >> enabled. >> >> But actually, maybe it's time that we just enable savehist by default. > Even if we decide to do that (and I'm not at all sure we should), how > would that solve the difficulty pointed out by Dmitry? Even if > savehist is ON by default, the user could turn it OFF, right? I think the working hypothesis is that they are the same feature: if project--list is used for saving the previous inputs, it can be covered by savehist-mode. And if used explicitly turns off savehist-mode (after it's been made the default), that can mean they're fine with not storing all of those histories, including the projects one. AFAIK project-known-project-roots is also used by some "splash page" packages to list the known projects for quick visiting, but that's not very different from using file-name-history to show a list of "last visited files", which also some code does. So I was primarily worried about migration -- for those who didn't enable savehist-mode yet (perhaps due to not being aware of it), but have existing saved project histories.