From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: wkirschbaum@gmail.com, casouri@gmail.com, 62333@debbugs.gnu.org
Subject: bug#62333: 30.0.50; Issue with tree-sitter syntax tree during certain changes
Date: Sat, 25 Mar 2023 17:25:17 +0200 [thread overview]
Message-ID: <3b3d82d1-f0f6-a768-a5db-8dc9386a5a34@yandex.ru> (raw)
In-Reply-To: <83wn34c2qa.fsf@gnu.org>
On 25/03/2023 16:41, Eli Zaretskii wrote:
>> Date: Sat, 25 Mar 2023 16:18:12 +0200
>> Cc: wkirschbaum@gmail.com, casouri@gmail.com, 62333@debbugs.gnu.org
>> From: Dmitry Gutov <dgutov@yandex.ru>
>>
>>> mixed-major-mode shouldn't be a problem.
>>
>> Why wouldn't it?
>
> Because the sexp ends inside the current mode's block.
But if the mmm framework narrowed the region to the current mode's
block, widening will force tree-sitter to parse the whole buffer. Which
might even result in parse errors (instead of meaningful parse nodes)
near point.
Or consider the case when the code in the current snippet is incomplete
(e.g. a missing paren). Then it might find a "match" somewhere far outside.
>>>> Because if we wanted to widen in all similar situations, we might as
>>>> well make it not obey the narrowing at all.
>>>
>>> It is impossible to not obey narrowing, not in Emacs. I told that and
>>> explained that many times already, including simple examples of what
>>> trouble this could cause to even the most innocent Lisp code. I hoped
>>> that by now this should no longer be brought forward.
>>
>> Okay. But do you advocate all uses of tree-sitter to (widen) first?
>
> No, just in sexp-movement functions, at least for now. If we discover
> this is need in many more situations, we might consider more drastic
> measures. But I don't think we are there yet. We've discovered just
> one such case, in just one such mode, and it's on master. We still
> have ample time to see how widespread this is.
I'm not sure whether tree-sitter is going to be used with mmm-mode (or
similar) a lot, since it has its own provisions for mixing languages.
But I'd also like to consider the other cases where we *don't* want to
widen first. Any of them come to mind?
next prev parent reply other threads:[~2023-03-25 15:25 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 14:00 bug#62333: 30.0.50; Issue with tree-sitter syntax tree during certain changes Wilhelm Kirschbaum
2023-03-23 1:03 ` Dmitry Gutov
2023-03-23 3:03 ` Yuan Fu
2023-03-23 4:20 ` Dmitry Gutov
2023-03-23 7:13 ` Eli Zaretskii
2023-03-23 21:18 ` Yuan Fu
2023-03-23 21:30 ` Dmitry Gutov
2023-03-23 22:06 ` Dmitry Gutov
2023-03-23 23:59 ` Yuan Fu
2023-03-24 6:05 ` Eli Zaretskii
2023-03-24 7:34 ` Yuan Fu
2023-03-25 1:51 ` Dmitry Gutov
2023-03-25 12:34 ` Eli Zaretskii
2023-03-25 13:00 ` Dmitry Gutov
2023-03-25 13:14 ` Eli Zaretskii
2023-03-25 13:44 ` Dmitry Gutov
2023-03-25 14:09 ` Eli Zaretskii
2023-03-25 14:18 ` Dmitry Gutov
2023-03-25 14:41 ` Eli Zaretskii
2023-03-25 15:25 ` Dmitry Gutov [this message]
2023-03-25 15:57 ` Eli Zaretskii
2023-03-25 16:03 ` Dmitry Gutov
2023-03-25 16:24 ` Eli Zaretskii
2023-03-25 17:05 ` Dmitry Gutov
2023-03-25 17:40 ` Eli Zaretskii
2023-03-25 19:31 ` Yuan Fu
2023-03-25 23:29 ` Dmitry Gutov
2023-03-26 22:52 ` Yuan Fu
2023-03-27 1:29 ` Dmitry Gutov
2023-03-26 4:28 ` Eli Zaretskii
2023-03-26 22:57 ` Yuan Fu
2023-03-27 13:32 ` Eli Zaretskii
2023-03-27 18:43 ` Yuan Fu
2023-03-25 22:57 ` Dmitry Gutov
2023-03-26 5:04 ` Eli Zaretskii
2023-03-26 9:25 ` Dmitry Gutov
2023-03-26 10:01 ` Eli Zaretskii
2023-03-26 22:00 ` Dmitry Gutov
2023-03-27 8:24 ` Gregory Heytings
2023-03-27 13:39 ` Eli Zaretskii
2023-03-27 20:05 ` Gregory Heytings
2023-03-28 11:30 ` Eli Zaretskii
2023-03-28 11:39 ` Gregory Heytings
2023-03-28 12:11 ` Eli Zaretskii
2023-03-28 12:25 ` Gregory Heytings
2023-03-28 12:36 ` Eli Zaretskii
2023-03-27 23:06 ` Dmitry Gutov
2023-03-28 11:32 ` Eli Zaretskii
2023-03-28 21:08 ` Dmitry Gutov
2023-03-29 11:08 ` Eli Zaretskii
2023-03-31 1:10 ` Dmitry Gutov
2023-03-31 1:27 ` Dmitry Gutov
2023-03-31 6:19 ` Eli Zaretskii
2023-03-31 7:46 ` Eli Zaretskii
2023-03-31 12:38 ` Dmitry Gutov
2023-03-31 13:03 ` Eli Zaretskii
2023-03-31 13:26 ` Dmitry Gutov
2023-03-31 12:46 ` Dmitry Gutov
2023-03-31 13:06 ` Eli Zaretskii
2023-03-31 18:43 ` Yuan Fu
2023-04-01 1:53 ` Dmitry Gutov
2023-04-01 5:47 ` Eli Zaretskii
2023-04-01 16:12 ` Dmitry Gutov
2023-04-02 22:08 ` Yuan Fu
2023-04-03 12:31 ` Eli Zaretskii
2023-03-27 23:20 ` Dmitry Gutov
2023-03-27 13:29 ` Eli Zaretskii
2023-03-27 23:33 ` Dmitry Gutov
2023-03-28 11:38 ` Eli Zaretskii
2023-03-28 21:19 ` Dmitry Gutov
2023-03-29 11:17 ` Eli Zaretskii
2023-03-30 15:50 ` Gregory Heytings
2023-03-30 16:04 ` Eli Zaretskii
2023-03-30 16:28 ` Gregory Heytings
2023-03-30 16:40 ` Eli Zaretskii
2023-03-30 17:27 ` Gregory Heytings
2023-03-30 17:47 ` Eli Zaretskii
2023-03-30 20:14 ` Gregory Heytings
2023-03-30 22:08 ` Gregory Heytings
2023-03-31 6:15 ` Eli Zaretskii
2023-03-31 1:25 ` Dmitry Gutov
2023-03-31 6:22 ` Eli Zaretskii
2023-03-31 1:17 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b3d82d1-f0f6-a768-a5db-8dc9386a5a34@yandex.ru \
--to=dgutov@yandex.ru \
--cc=62333@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
--cc=wkirschbaum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).