From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jimmy Wong Newsgroups: gmane.emacs.bugs Subject: bug#63300: 29.0.90; Tramp keeps customizing variables on every connection Date: Sun, 4 Jun 2023 17:55:42 +0100 Message-ID: <3aba5090-3ed7-4a2b-b65c-872880e2bf76@Spark> References: <87h6rnsiup.fsf@gmx.de> <871qirsbcd.fsf@gmx.de> <666e41e6-b1fc-4dd3-a190-187a73c868f8@Spark> <87sfb7qvoh.fsf@gmx.de> <814039a1-20ea-4068-b950-1cd9ed594e21@Spark> <87o7lvquy2.fsf@gmx.de> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="647cc214_2a3a869f_436" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31539"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63300@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 04 18:56:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q5r1c-00082G-Q0 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Jun 2023 18:56:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q5r1P-0005dl-Jy; Sun, 04 Jun 2023 12:56:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5r1O-0005c9-EV for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2023 12:56:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q5r1O-0006Un-64 for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2023 12:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q5r1O-0007kK-1k for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2023 12:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jimmy Wong Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Jun 2023 16:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63300 X-GNU-PR-Package: emacs Original-Received: via spool by 63300-submit@debbugs.gnu.org id=B63300.168589775729766 (code B ref 63300); Sun, 04 Jun 2023 16:56:02 +0000 Original-Received: (at 63300) by debbugs.gnu.org; 4 Jun 2023 16:55:57 +0000 Original-Received: from localhost ([127.0.0.1]:47037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5r1I-0007k1-SA for submit@debbugs.gnu.org; Sun, 04 Jun 2023 12:55:57 -0400 Original-Received: from mail-wm1-f50.google.com ([209.85.128.50]:55635) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5r1G-0007jp-U3 for 63300@debbugs.gnu.org; Sun, 04 Jun 2023 12:55:55 -0400 Original-Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-3f6e1394060so34351955e9.3 for <63300@debbugs.gnu.org>; Sun, 04 Jun 2023 09:55:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685897749; x=1688489749; h=mime-version:subject:references:in-reply-to:message-id:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=DMGE9lv1XFmioBnU3rQ8hvYUfAcox/ktKQxAthtF/cc=; b=Q/ECVRJj7aL88ogioseABQacscbODStWDUFD3t0AZ1vMuO2djM03xlAlgmvXblNEDC PkrkWklHWht6CiTk+uNgSsUq7bOfgqQ3UyqsRJOegKRrZkZWdLg+EBDciOK85OP8kvYd lR6E8Vn/lAtB4rgV8hrpsGzqZl6/ADDdtyI4CARY5csv0kNa+ZsDOxVEUzsD0/a/nMeO 5EyLoBEY0YckZ/QzSzzWGhdMZ7W/+5fLLdOoHQgrOgf/8oh7H2QdWDbTfqytgeDPvU5Q 3UeTgnZiWbsHexth7/owJHLTAmXv3kvgYOXicbo6ItAHV8mil/1sl/53wNmBM+ud7pIR Ss/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685897749; x=1688489749; h=mime-version:subject:references:in-reply-to:message-id:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DMGE9lv1XFmioBnU3rQ8hvYUfAcox/ktKQxAthtF/cc=; b=KshO9n+1vk/0596V93WMcDP5hXdfcIGzuMDRkdwkkhFaJrHAXMSXD47CUpIPl5NHLG d+Gs8PdGz0QjRnKLAQ7v1Fp9RZQ/b3+wkdHii9mwR7ye9oLSHY0fwYJ+MmhN5+WTQKYx UEPNOAjH7z0kj7a/O5+p5wyKIRC6t6U4KTcqhAiMslZCWLXKKrB9semnOOyjTQozTXZP XKauK2lypwVGG4fIuMSgtWVNKDxA0tifdMMR8ysulP0OuioexizbtOTiYHiQmGcwkFNd BYgyWSKhIicGhOobryJp/O1GOeofQOoQiB8NOJ8Bme/Yi57IjosQDT8f1VH1Z/ZAJHSe cZ0A== X-Gm-Message-State: AC+VfDx59zKXSTIhyWl7vlcIOwwjCqSQiioh24CKLNTaD+Zb8fjT0xzM jEHiKzJAYOdf3XkfOwoAecnOzRLYCck= X-Google-Smtp-Source: ACHHUZ6T5XRl2wA+AvS7C009ouGCTuk8DiGK9Sxke0SD2VpIw2JztqCJaB5UL0h8qQOCDULHh4ZEyw== X-Received: by 2002:a05:600c:2906:b0:3f6:91c:4e86 with SMTP id i6-20020a05600c290600b003f6091c4e86mr5308546wmd.3.1685897749167; Sun, 04 Jun 2023 09:55:49 -0700 (PDT) Original-Received: from [2a01:4b00:89a0:2400::ffff:ffff] ([2a01:4b00:89a0:2400:6063:8212:189a:b65]) by smtp.gmail.com with ESMTPSA id n24-20020a1c7218000000b003f4fffccd73sm8320850wmc.9.2023.06.04.09.55.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Jun 2023 09:55:48 -0700 (PDT) In-Reply-To: X-Readdle-Message-ID: 3aba5090-3ed7-4a2b-b65c-872880e2bf76@Spark X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262977 Archived-At: --647cc214_2a3a869f_436 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Actually, I take it back. customize-save-variable only saves variables th= at have the saved-value symbol property set. This property is normally se= t by customize when it is saved to the custom file. Something in Tramp is= setting this property without saving the variable values to the custom f= ile or going through customize. In fact, you can see it via M-x customize= -option connection-local-criteria-alist. The value will be shown as SAVED= . In addition, setting =60enable-connection-local-variables=60 to nil early= in early-init.el has no effect, the variable is still set on load. Both of this behavior violate what is documented in the docstring and htt= ps://www.gnu.org/software/emacs/manual/html=5Fnode/elisp/Standard-Propert= ies.html. If you must, enable-conneciton-local-variables should be respected, and i= f you must, set the theme-value property on these connection-local variab= les instead of saved-value so custom-save-all will not save them. On 4 Jun 2023 at 1:23 PM +0100, Jimmy Wong , wrote: > I=E2=80=99ll file a separate bug. You can close this one. Thanks. > On 4 Jun 2023 at 1:21 PM +0100, Michael Albinus , wrote: > > Jimmy Wong writes: > > > > Hi, > > > > > Well, yes, I consider this a poorly considered =E2=80=9Cfeature=E2=80= =9D, or arguably > > > a bug, for exactly the reason you said, they are local to connectio= ns > > > and machines, and thus highly variable. > > > > Not really. They exist for the reason that a user can override the > > default values offered by Tramp. This I would call a user option. > > > > Tramp has a lot of further host specific data, which are all kept in > > variables. > > > > > We can probably argue whether this is a bug in tramp or a bug in > > > customize-save-variable tho (why on earth does the act of saving a > > > single variable value saves all customized values if a custom file > > > exists=3F) > > > > I agree with the latter. > > > > Best regards, Michael. --647cc214_2a3a869f_436 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline
Actually, I take it back. customize-save-variable o= nly saves variables that have the saved-value symbol property set. This p= roperty is normally set by customize when it is saved to the custom file.= Something in Tramp is setting this property without saving the variable = values to the custom file or going through customize. In fact, you can se= e it via M-x customize-option connection-local-criteria-alist. The value = will be shown as SAVED.

In addition, setting =60enable-connection-local-variables=60 to nil early= in early-init.el has no effect, the variable is still set on load.
=
Both of this behavior violate what is documented in the docstring and htt= ps://www.gnu.org/software/emacs/manual/html=5Fnode/elisp/Standard-Propert= ies.html.

If you must, enable-conneciton-local-variables should be respected, and i= f you must, set the theme-value property on these connection-local variab= les instead of saved-value so custom-save-all will not save them.

On 4 Jun 2023 at 1:23 PM +0100, Jim= my Wong <wyuenho=40gmail.com>, wrote:
I=E2=80=99ll file a separate bug. You can close thi= s one. Thanks.
On 4 Jun 2023 at 1:21 PM +0100, Mic= hael Albinus <michael.albinus=40gmx.de>, wrote:
Jimmy Wong <wyuenho=40gmail.com> writes:

Hi,

Well, yes, I consider this a poorly conside= red =E2=80=9Cfeature=E2=80=9D, or arguably
a bug, for exactly the reason you said, they are local to connections
and machines, and thus highly variable.

Not really. They exist for the reason that a user can override the
default values offered by Tramp. This I would call a user option.

Tramp has a lot of further host specific data, which are all kept in
variables.

We can probably argue whether this is a bug= in tramp or a bug in
customize-save-variable tho (why on earth does the act of saving a
single variable value saves all customized values if a custom file
exists=3F)

I agree with the latter.

Best regards, Michael.
--647cc214_2a3a869f_436--