From: Jim Porter <jporterbugs@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>, Daniel Mendler <mail@daniel-mendler.de>
Cc: liuhui1610@gmail.com, arstoffel@gmail.com,
monnier@iro.umontreal.ca, 61283@debbugs.gnu.org
Subject: bug#61283: 29.0.60; pcomplete-completions-at-point loses text properties, breaking pcomplete-from-help annotations
Date: Wed, 17 May 2023 23:44:17 -0700 [thread overview]
Message-ID: <3aa0fc03-6d0c-2528-ac3a-f0a815439b15@gmail.com> (raw)
In-Reply-To: <83sfbuw639.fsf@gnu.org>
On 5/17/2023 10:39 PM, Eli Zaretskii wrote:
> Why do you think it will be safe for emacs-29?
>
> And why do we have to fix this in Emacs 29.1? This only affects
> Eshell, AFAIU, is that true?
It affects M-x shell for me too. Maybe I'm just doing something wrong
though. I tried this:
emacs -Q -f shell
ls -<TAB>
From that, I get completions like "--block-size=", which doesn't show
the annotation. With the annotation, it should be "--block-size=SIZE".
Currently, Pcomplete passes the annotation around by propertizing the
first character of the candidate string. That ends up not working, since
the completion code uses the characters in the buffer and concats the
suffix from Pcomplete. So then the pcomplete-annotation almost always
gets thrown out.
I think a safe (but incomplete) fix would be to put the annotation on
the *last* character of the candidate string. Then it usually wouldn't
get thrown out. It won't work in *every* case, but it would only fail in
rare edge cases.
next prev parent reply other threads:[~2023-05-18 6:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-05 0:23 bug#61283: 29.0.60; pcomplete-completions-at-point loses text properties, breaking pcomplete-from-help annotations Daniel Mendler
2023-05-16 1:49 ` Liu Hui
2023-05-16 6:19 ` Daniel Mendler
2023-05-16 10:30 ` Eli Zaretskii
2023-05-16 10:44 ` Daniel Mendler
2023-05-16 21:37 ` Gregory Heytings
2023-05-17 6:15 ` Daniel Mendler
2023-05-17 7:24 ` Daniel Mendler
2023-05-17 5:45 ` Jim Porter
2023-05-17 6:31 ` Daniel Mendler
2023-05-17 14:55 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-17 21:20 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-18 2:01 ` Daniel Mendler
2023-05-18 5:39 ` Eli Zaretskii
2023-05-18 6:44 ` Jim Porter [this message]
2023-05-18 6:58 ` Eli Zaretskii
2023-05-18 8:29 ` Daniel Mendler
2023-05-18 13:37 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-18 7:11 ` Jim Porter
2023-05-18 8:37 ` Daniel Mendler
2023-05-18 13:30 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-23 4:16 ` Jim Porter
2023-05-16 14:04 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-16 7:50 ` Gregory Heytings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3aa0fc03-6d0c-2528-ac3a-f0a815439b15@gmail.com \
--to=jporterbugs@gmail.com \
--cc=61283@debbugs.gnu.org \
--cc=arstoffel@gmail.com \
--cc=eliz@gnu.org \
--cc=liuhui1610@gmail.com \
--cc=mail@daniel-mendler.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).