From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#61006: 29.0.60; Wrong indentation in go-ts-mode Date: Wed, 25 Jan 2023 02:46:05 +0000 Message-ID: <3aLr20wUmwH_Z8sYXoG4FACIHNCCJlDFFAdFCUNNe5FTsaozqHRxHhZ6fwtVXlRZMmfA_7PDN_rE-YfxrhtEtq5SOMnd0S2LeMgCNGQlyco=@rjt.dev> References: <4e1f92dc54d94cf4860490c643b5fd565deb0e1a.camel@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_L8aJIY1cgEQDluMCGo3EZfwVY19Z3UfUDqghbM8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14202"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61006@debbugs.gnu.org To: sskostyaev@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 25 03:47:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKVos-0003ZO-9s for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Jan 2023 03:47:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pKVoW-0006yD-F6; Tue, 24 Jan 2023 21:47:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKVoU-0006x2-NU for bug-gnu-emacs@gnu.org; Tue, 24 Jan 2023 21:47:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pKVoU-0008Do-93 for bug-gnu-emacs@gnu.org; Tue, 24 Jan 2023 21:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pKVoT-0003XR-Qe for bug-gnu-emacs@gnu.org; Tue, 24 Jan 2023 21:47:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Jan 2023 02:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61006 X-GNU-PR-Package: emacs Original-Received: via spool by 61006-submit@debbugs.gnu.org id=B61006.167461479613562 (code B ref 61006); Wed, 25 Jan 2023 02:47:01 +0000 Original-Received: (at 61006) by debbugs.gnu.org; 25 Jan 2023 02:46:36 +0000 Original-Received: from localhost ([127.0.0.1]:57957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKVo4-0003Wg-2Z for submit@debbugs.gnu.org; Tue, 24 Jan 2023 21:46:36 -0500 Original-Received: from mail-4022.proton.ch ([185.70.40.22]:27825) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKVo0-0003WQ-Em for 61006@debbugs.gnu.org; Tue, 24 Jan 2023 21:46:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1674614786; x=1674873986; bh=iaWUCFjgMygZktTF/H1kOEF7i2lGJ22AyYu9Ruewhx8=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=USJeBfgIAQRCk/IJpFfv/5z5fdkVHRNvPxDiTLGJTFIxvHIotp6WlKwtP+2ne3oVo 5XvP+JqY5/20hlmrh2vxZdNNtrtFu/jpzO90mpMx31D34TbmPJKC6t4Oe4m5ngpRhA Y4ZHJCo9FHHsS5RObgynmTg6m9AYJBfTfZ5K7qwLCK0BNXLFvK/iJWuRmgWRALR5BN MPWmxg/COXbmIbZKGjl6x0/4askkzu48XFD1V/M0/Ibu0PHFVewH+jTaMLfwZ7nDsp 2Y8h2MwISE7/Bj5QDx4GJYjpLC6PZVkznaQkKh216+QLRliiA462ZcqPpipsHLPz2+ MTCVsUsR1bk3g== In-Reply-To: Feedback-ID: 44397038:user:proton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254091 Archived-At: This is a multi-part message in MIME format. --b1_L8aJIY1cgEQDluMCGo3EZfwVY19Z3UfUDqghbM8 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tuesday, January 24th, 2023 at 21:35, Randy Taylor wrote: >=20 > On Sunday, January 22nd, 2023 at 05:00, sskostyaev@gmail.com sskostyaev@g= mail.com wrote: >=20 > > Hi. Thank you all for great work. > > In go-ts-mode indentation breaks in function or method definition if > > arguments placed on separate lines like this: > > `func transform( s string, ) string {` > > This code should be indented like this: > > `func transform( s string, ) string {` >=20 >=20 > Thanks for the report. I've attached a patch that fixes this. >=20 > > Also `go-ts-mode-indent-offset' should be 8 by default. In go world the= re is gofmt which is a real standart for code indentation. It would be grea= t if emacs will provide the same indentation out of the box. >=20 >=20 > And addresses this. >=20 > > There is also other issue - sometimes go-ts-mode syntax highliting brea= ks when I actively use it with `lsp-mode`- refactorings, auto formatting et= c. But I can't reproduce it with`eglot`. >=20 >=20 > Seems like an `lsp-mode` problem then? I only use `eglot` and haven't not= iced anything amiss. Addendum to my last patch: added indentation support for interfaces as it w= as missing. Everything else is the same. --b1_L8aJIY1cgEQDluMCGo3EZfwVY19Z3UfUDqghbM8 Content-Type: text/x-patch; name=0001-Fix-go-ts-mode-indentation-and-set-indent-offset-to-.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-Fix-go-ts-mode-indentation-and-set-indent-offset-to-.patch RnJvbSBlZTcyZjNjZTlhZmE3MjNlY2NjYzE5OWVkMzk4NzE1ZWEwOTRkODE2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSYW5keSBUYXlsb3IgPGRldkByanQuZGV2PgpEYXRlOiBUdWUs IDI0IEphbiAyMDIzIDIxOjIwOjQ4IC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gRml4IGdvLXRzLW1v ZGUgaW5kZW50YXRpb24gYW5kIHNldCBpbmRlbnQgb2Zmc2V0IHRvIDgKIChCdWcjNjEwMDYpCgoq IGxpc3AvcHJvZ21vZGVzL2dvLXRzLW1vZGUuZWwgKGdvLXRzLW1vZGUtaW5kZW50LW9mZnNldCk6 IENoYW5nZSBpdAp0byA4LgooZ28tdHMtbW9kZS0taW5kZW50LXJ1bGVzKTogQWRkIGluZGVudGF0 aW9uIGZvciBwYXJhbWV0ZXJzIGFuZCBpbnRlcmZhY2VzLgotLS0KIGxpc3AvcHJvZ21vZGVzL2dv LXRzLW1vZGUuZWwgfCA0ICsrKy0KIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDEg ZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy9nby10cy1tb2RlLmVsIGIv bGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9kZS5lbAppbmRleCBkNTUyZTEzNjBlMC4uNWYzZTFlYTNl NjggMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL2dvLXRzLW1vZGUuZWwKKysrIGIvbGlzcC9w cm9nbW9kZXMvZ28tdHMtbW9kZS5lbApAQCAtMzgsNyArMzgsNyBAQAogKGRlY2xhcmUtZnVuY3Rp b24gdHJlZXNpdC1ub2RlLXR5cGUgInRyZWVzaXQuYyIpCiAoZGVjbGFyZS1mdW5jdGlvbiB0cmVl c2l0LXNlYXJjaC1zdWJ0cmVlICJ0cmVlc2l0LmMiKQogCi0oZGVmY3VzdG9tIGdvLXRzLW1vZGUt aW5kZW50LW9mZnNldCA0CisoZGVmY3VzdG9tIGdvLXRzLW1vZGUtaW5kZW50LW9mZnNldCA4CiAg ICJOdW1iZXIgb2Ygc3BhY2VzIGZvciBlYWNoIGluZGVudGF0aW9uIHN0ZXAgaW4gYGdvLXRzLW1v ZGUnLiIKICAgOnZlcnNpb24gIjI5LjEiCiAgIDp0eXBlICdpbnRlZ2VyCkBAIC03OCw4ICs3OCwx MCBAQCBnby10cy1tb2RlLS1pbmRlbnQtcnVsZXMKICAgICAgKChwYXJlbnQtaXMgImV4cHJlc3Np b25fc3dpdGNoX3N0YXRlbWVudCIpIHBhcmVudC1ib2wgMCkKICAgICAgKChwYXJlbnQtaXMgImZp ZWxkX2RlY2xhcmF0aW9uX2xpc3QiKSBwYXJlbnQtYm9sIGdvLXRzLW1vZGUtaW5kZW50LW9mZnNl dCkKICAgICAgKChwYXJlbnQtaXMgImltcG9ydF9zcGVjX2xpc3QiKSBwYXJlbnQtYm9sIGdvLXRz LW1vZGUtaW5kZW50LW9mZnNldCkKKyAgICAgKChwYXJlbnQtaXMgImludGVyZmFjZV90eXBlIikg cGFyZW50LWJvbCBnby10cy1tb2RlLWluZGVudC1vZmZzZXQpCiAgICAgICgocGFyZW50LWlzICJs YWJlbGVkX3N0YXRlbWVudCIpIHBhcmVudC1ib2wgZ28tdHMtbW9kZS1pbmRlbnQtb2Zmc2V0KQog ICAgICAoKHBhcmVudC1pcyAibGl0ZXJhbF92YWx1ZSIpIHBhcmVudC1ib2wgZ28tdHMtbW9kZS1p bmRlbnQtb2Zmc2V0KQorICAgICAoKHBhcmVudC1pcyAicGFyYW1ldGVyX2xpc3QiKSBwYXJlbnQt Ym9sIGdvLXRzLW1vZGUtaW5kZW50LW9mZnNldCkKICAgICAgKChwYXJlbnQtaXMgInR5cGVfc3Bl YyIpIHBhcmVudC1ib2wgZ28tdHMtbW9kZS1pbmRlbnQtb2Zmc2V0KQogICAgICAoKHBhcmVudC1p cyAidmFyX2RlY2xhcmF0aW9uIikgcGFyZW50LWJvbCBnby10cy1tb2RlLWluZGVudC1vZmZzZXQp CiAgICAgIChuby1ub2RlIHBhcmVudC1ib2wgMCkpKQotLSAKMi4zOS4xCgo= --b1_L8aJIY1cgEQDluMCGo3EZfwVY19Z3UfUDqghbM8--