From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#15047: 24.3.50; doc string of `find-listp-find-files' etc. Date: Fri, 29 Apr 2016 10:19:48 -0700 (PDT) Message-ID: <3a7790ce-afe5-42dc-b55c-9a1e31f8b30f@default> References: <87inz08rkv.fsf@gnus.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1461950503 23642 80.91.229.3 (29 Apr 2016 17:21:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 29 Apr 2016 17:21:43 +0000 (UTC) Cc: 15047@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 29 19:21:30 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1awC6c-00014y-0C for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Apr 2016 19:21:30 +0200 Original-Received: from localhost ([::1]:55615 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awC6Y-00086v-5S for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Apr 2016 13:21:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48157) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awC6P-0007sf-79 for bug-gnu-emacs@gnu.org; Fri, 29 Apr 2016 13:21:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1awC6D-0001av-HJ for bug-gnu-emacs@gnu.org; Fri, 29 Apr 2016 13:21:11 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43311) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awC6D-0001Zh-EB for bug-gnu-emacs@gnu.org; Fri, 29 Apr 2016 13:21:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1awC6A-0007fj-0v for bug-gnu-emacs@gnu.org; Fri, 29 Apr 2016 13:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Apr 2016 17:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15047 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 15047-submit@debbugs.gnu.org id=B15047.146195040229414 (code B ref 15047); Fri, 29 Apr 2016 17:21:01 +0000 Original-Received: (at 15047) by debbugs.gnu.org; 29 Apr 2016 17:20:02 +0000 Original-Received: from localhost ([127.0.0.1]:55648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awC5C-0007eM-Fj for submit@debbugs.gnu.org; Fri, 29 Apr 2016 13:20:02 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:19980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awC5B-0007dp-An for 15047@debbugs.gnu.org; Fri, 29 Apr 2016 13:20:01 -0400 Original-Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u3THJrLN003507 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 29 Apr 2016 17:19:54 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u3THJqlO008010 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 29 Apr 2016 17:19:53 GMT Original-Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u3THJq7Y026250; Fri, 29 Apr 2016 17:19:52 GMT In-Reply-To: <87inz08rkv.fsf@gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] X-Source-IP: userv0021.oracle.com [156.151.31.71] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:117220 Archived-At: > > The doc should distinguish between the files _within_ a directory, i.e.= , > > descending into its subdirectories recursively, and the files in a > > directory, i.e., not including in descendent directories. > > > > Pick any terminology you like, but please make it clear. > > > > 1. `find-listp-find-files': The doc of does not at all indicate that it > > in fact searches also subdirectories, recursively. >=20 > Fixed... >=20 > > 2. `find-lisp-find-files-internal': The doc says that > > "DIRECTORY-PREDICATE is used to decide...", but it does not say how, > > which is central to the meaning of DIRECTORY-PREDICATE. Just say that > > if DIRECTORY-PREDICATE returns non-nil then descend into subdirs etc. >=20 > It's a predicate. That's what predicates do. Have you looked at this doc and function? I had no complaint with what the doc string says about arg FILE-PREDICATE. It says that it is a predicate that files under DIRECTORY need to satisfy, for them to be found. Things are very different for DIRECTORY-PREDICATE. What is it? What is it applied to? If you look at the code you will see that it is applied to a directory, and if it succeeds the function is called recursively to look for files under that directory. That should be explained in the doc: what the predicate is applied to and what its effect is.