From: Drew Adams <drew.adams@oracle.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 15047@debbugs.gnu.org
Subject: bug#15047: 24.3.50; doc string of `find-listp-find-files' etc.
Date: Fri, 29 Apr 2016 10:19:48 -0700 (PDT) [thread overview]
Message-ID: <3a7790ce-afe5-42dc-b55c-9a1e31f8b30f@default> (raw)
In-Reply-To: <87inz08rkv.fsf@gnus.org>
> > The doc should distinguish between the files _within_ a directory, i.e.,
> > descending into its subdirectories recursively, and the files in a
> > directory, i.e., not including in descendent directories.
> >
> > Pick any terminology you like, but please make it clear.
> >
> > 1. `find-listp-find-files': The doc of does not at all indicate that it
> > in fact searches also subdirectories, recursively.
>
> Fixed...
>
> > 2. `find-lisp-find-files-internal': The doc says that
> > "DIRECTORY-PREDICATE is used to decide...", but it does not say how,
> > which is central to the meaning of DIRECTORY-PREDICATE. Just say that
> > if DIRECTORY-PREDICATE returns non-nil then descend into subdirs etc.
>
> It's a predicate. That's what predicates do.
Have you looked at this doc and function?
I had no complaint with what the doc string says about arg
FILE-PREDICATE. It says that it is a predicate that files
under DIRECTORY need to satisfy, for them to be found.
Things are very different for DIRECTORY-PREDICATE. What is
it? What is it applied to? If you look at the code you will
see that it is applied to a directory, and if it succeeds
the function is called recursively to look for files under
that directory.
That should be explained in the doc: what the predicate is
applied to and what its effect is.
next prev parent reply other threads:[~2016-04-29 17:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 22:06 bug#15047: 24.3.50; doc string of `find-listp-find-files' etc Drew Adams
2016-04-29 13:36 ` Lars Ingebrigtsen
2016-04-29 17:19 ` Drew Adams [this message]
2016-05-01 13:46 ` Michael Heerdegen
2016-05-01 14:28 ` Drew Adams
2016-05-01 15:12 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a7790ce-afe5-42dc-b55c-9a1e31f8b30f@default \
--to=drew.adams@oracle.com \
--cc=15047@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).