unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: 22019@debbugs.gnu.org
Subject: bug#22019: 25.0.50; Bad comment in `character-fold-to-regexp'
Date: Thu, 26 Nov 2015 15:03:36 -0800 (PST)	[thread overview]
Message-ID: <3a754c45-2dc0-403f-9396-cefca118454d@default> (raw)

This part of an explanatory comment is inadequate and inappropriate:

 ;; See commit message for a longer description.

What commit message?  The source code should contain the description.
If a VC commit message happens to also contain the description, so
much the better for it.  But that doesn't help a reader of the code.

This comment is intended to make clear what the design/intention is.
Readers of the source code deserve the additional design information
as much as maintainers who might bother to access the relevant commit.


In GNU Emacs 25.0.50.1 (i686-pc-mingw32)
 of 2015-11-12
Bzr revision: 6e5186e8a7ccfb9b8fb35b5f4f0371e4f4a68162
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/snapshot/trunk
 --enable-checking=yes,glyphs --enable-check-lisp-object-type
 --without-compress-install --with-wide-int 'CFLAGS=-O0 -ggdb3'
 LDFLAGS=-Lc:/Devel/emacs/lib 'CPPFLAGS=-DGC_MCHECK=1
 -Ic:/Devel/emacs/include''





             reply	other threads:[~2015-11-26 23:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-26 23:03 Drew Adams [this message]
2015-11-26 23:40 ` bug#22019: 25.0.50; Bad comment in `character-fold-to-regexp' Artur Malabarba
2015-11-27  6:38 ` Richard Stallman
2015-11-27  8:54   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3a754c45-2dc0-403f-9396-cefca118454d@default \
    --to=drew.adams@oracle.com \
    --cc=22019@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).