unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Sergey Vinokurov <serg.foo@gmail.com>
To: 53537@debbugs.gnu.org
Subject: bug#53537: Emacs 28 regression: fill-column is not always respected for the first line of commented block
Date: Wed, 26 Jan 2022 00:14:21 +0000	[thread overview]
Message-ID: <3a18005d-bbb4-c201-c60f-a583711cba37@gmail.com> (raw)

Hello,

The #45720 bug introduces edge case in treatment of fill-column for the 
first line of commented block. This is caught by haskell-mode tests 
(https://github.com/haskell/haskell-mode/blob/master/tests/haskell-mode-tests.el#L330) 
but is not limited to that mode.

I have managed to reproduce it using the following snippet:

(princ
  (with-temp-buffer
    (asm-mode)
    (dolist (line '("  ;; a b c"
                    "  ;; d e f"
                    "  ;; x y z"
                    "  ;; w"))
      (insert line "\n"))
    (goto-char (point-min))
    (end-of-line)
    (setf fill-column 10)
    (fill-paragraph nil)
    (buffer-string)))

The idea is that everything is already filled and nothing should happen 
when fill-column equals to 10.

On Emacs 27 I get the expected output (snippet above is in /tmp/test.el):

$ emacs --version
GNU Emacs 27.2.50
Copyright (C) 2021 Free Software Foundation, Inc.
GNU Emacs comes with ABSOLUTELY NO WARRANTY.
You may redistribute copies of GNU Emacs
under the terms of the GNU General Public License.
For more information about these matters, see the file named COPYING.
$ emacs -Q --batch -l /tmp/test.el
   ;; a b c
   ;; d e f
   ;; x y z
   ;; w

On Emacs 28 pretest I get:

$ emacs --version
GNU Emacs 28.0.91
Copyright (C) 2022 Free Software Foundation, Inc.
GNU Emacs comes with ABSOLUTELY NO WARRANTY.
You may redistribute copies of GNU Emacs
under the terms of the GNU General Public License.
For more information about these matters, see the file named COPYING.
$ emacs -Q --batch -l /tmp/test.el
   ;; a b c d
   ;; e f x
   ;; y z w

The first line is of length 11 which is in violation of requested 
fill-column equals 10.

Couldn't reproduce for emacs-lisp-mode and c-mode presumably because 
they override fill-paragraph-function so asm-mode is the simplest 
programming related mode I could find in vanilla Emacs. Other modes that 
don't do anything fancy with fill-paragraph-function (e.g. haskell-mode) 
should be susceptible to the issue as well.





             reply	other threads:[~2022-01-26  0:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-26  0:14 Sergey Vinokurov [this message]
2022-01-26 12:43 ` bug#53537: Emacs 28 regression: fill-column is not always respected for the first line of commented block Eli Zaretskii
2022-01-26 15:19   ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3a18005d-bbb4-c201-c60f-a583711cba37@gmail.com \
    --to=serg.foo@gmail.com \
    --cc=53537@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).