next-error accepts a prefix argument, but previous-error doesn't

next-error accepts a prefix argument, but previous-error doesn't

[Kevin Rodgers]

Here's a patch to allow the user to specify how many errors to move:

*** emacs-21.3/lisp/progmodes/compile.el.orig	Fri Jan 17 06:45:11 2003
--- emacs-21.3/lisp/progmodes/compile.el	Tue Aug 19 11:26:38 2003
***************
*** 1478,1489 ****
   			   (consp argp))))
   ;;;###autoload (define-key ctl-x-map "`" 'next-error)

! (defun previous-error ()
     "Visit previous compilation error message and corresponding source code.
- This operates on the output from the \\[compile] command."
-   (interactive)
-   (next-error -1))

   (defun first-error ()
     "Reparse the error message buffer and start at the first error.
   Visit corresponding source code.
--- 1478,1493 ----
   			   (consp argp))))
   ;;;###autoload (define-key ctl-x-map "`" 'next-error)

! (defun previous-error (argp)
     "Visit previous compilation error message and corresponding source code.

+ A prefix ARGP specifies how many error messages to move;
+ negative means move forward to next error messages.
+
+ This operates on the output from the \\[compile] and \\[grep] commands."
+   (interactive "P")
+   (next-error (- (prefix-numeric-value argp))))
+
   (defun first-error ()
     "Reparse the error message buffer and start at the first error.
   Visit corresponding source code.

-- 
Kevin Rodgers

Re: next-error accepts a prefix argument, but previous-error doesn't

[Juri Linkov]

Kevin Rodgers <ihs_4664@yahoo.com> writes:
> Here's a patch to allow the user to specify how many errors to move:
> [skipped...]
>
> ! (defun previous-error (argp)
>
> [...skipped]

You should change the argument argp of previous-error to be optional,
just as argument of next-error already is:

(defun next-error (&optional argp)

Thanks.
-- 
http://www.jurta.org/emacs/

Re: next-error accepts a prefix argument, but previous-error doesn't

[Kevin Rodgers]

Juri Linkov <juri@jurta.org> wrote:
> Kevin Rodgers <ihs_4664@yahoo.com> writes:
> > Here's a patch to allow the user to specify how many errors to move:
> > [skipped...]
> >
> > ! (defun previous-error (argp)
> >
> > [...skipped]
> 
> You should change the argument argp of previous-error to be optional,
> just as argument of next-error already is:
> 
> (defun next-error (&optional argp)

Definitely.

It would also be nice if just `C-u' as a prefix argument for previous-error
had a special meaning, like it does for next-error.  I'd like it to reparse
the error messages and move to the last error, but that is a bigger change
and harder to implement.  The difficulty is that compilation-next-error-locus's
MOVE and REPARSE arguments are not orthogonal:

  (compile-reinitialize-errors reparse nil (and (not reparse) (max 0 move)))

-- 
Kevin Rodgers

__________________________________
Do you Yahoo!?
The New Yahoo! Search - Faster. Easier. Bingo.
http://search.yahoo.com

Re: next-error accepts a prefix argument, but previous-error doesn't

[Juri Linkov]

Kevin Rodgers <ihs_4664@yahoo.com> writes:
> Juri Linkov <juri@jurta.org> wrote:
> > You should change the argument argp of previous-error to be optional,
> > just as argument of next-error already is:
> > 
> > (defun next-error (&optional argp)
> 
> Definitely.
> 
> It would also be nice if just `C-u' as a prefix argument for
> previous-error had a special meaning, like it does for next-error.
> I'd like it to reparse the error messages and move to the last
> error, but that is a bigger change and harder to implement.  The
> difficulty is that compilation-next-error-locus's MOVE and REPARSE
> arguments are not orthogonal:
> 
> (compile-reinitialize-errors reparse nil (and (not reparse) (max 0 move)))

I think moving to the last error is hardly needed.  But still lacking
feature is the moving point to the next or previous file.  There are
already implemented functions compilation-next-file and
compilation-previous-file, but they work only in the compilation
buffer.  There should be possibility to call them globally
from any buffer.

I propose to use `C-u' argument of next-error and previous-error to
move point to the next or previous file.  The existing meaning of
reparsing the error messages can be reassigned to the value 0 of this
argument (invoked by typing `M-0' or `C-0').  And, of course, to add
also your suggested moving by a specified amount of errors to the
previous-error function.

-- 
http://www.jurta.org/emacs/