From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#49978: 28.0.50; grep-highlight-matches auto-detection broken on macOS [PATCH] Date: Tue, 10 Aug 2021 15:39:04 +0200 Message-ID: <3E02EB6C-A3F9-482B-AEF3-50D68DAFAA0A@acm.org> References: <6D6B9A78-50EC-4AEC-80AA-EB12C608EB48@acm.org> <83tujxfn7q.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38488"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 49978@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 10 15:40:29 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mDRzZ-0009pP-0f for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 10 Aug 2021 15:40:29 +0200 Original-Received: from localhost ([::1]:36080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDRzX-0006cW-9J for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 10 Aug 2021 09:40:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42356) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDRz8-0006cO-PL for bug-gnu-emacs@gnu.org; Tue, 10 Aug 2021 09:40:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47214) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mDRz8-00037q-J0 for bug-gnu-emacs@gnu.org; Tue, 10 Aug 2021 09:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mDRz8-0006mK-6q for bug-gnu-emacs@gnu.org; Tue, 10 Aug 2021 09:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Aug 2021 13:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49978 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49978-submit@debbugs.gnu.org id=B49978.162860275425990 (code B ref 49978); Tue, 10 Aug 2021 13:40:02 +0000 Original-Received: (at 49978) by debbugs.gnu.org; 10 Aug 2021 13:39:14 +0000 Original-Received: from localhost ([127.0.0.1]:58760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDRyL-0006l8-Pv for submit@debbugs.gnu.org; Tue, 10 Aug 2021 09:39:14 -0400 Original-Received: from mail235c50.megamailservers.eu ([91.136.10.245]:37010 helo=mail56c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDRyH-0006kv-RH for 49978@debbugs.gnu.org; Tue, 10 Aug 2021 09:39:12 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1628602747; bh=VA4bjuGptcpQRegoo5vjo8hocZxJblLu09SRxmJ6ta4=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=VwPbXLIBWpTUOyoJGeAbCTP+mE1gLx5Gzm950csDRu9wmRwl9yJjyPyUB4cuHYaXO n4DI7V6VFJ9LDMOdfzkVtfy0F0Kd/TqoWqCr5Py4r8kHR9Egf+pTYxiT57nZEhhXjL 2IbayM/kInbpQtMAqSM5MuhtXv+5IzxAO8dyCRs0= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail56c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 17ADd5Yv023063; Tue, 10 Aug 2021 13:39:07 +0000 In-Reply-To: <83tujxfn7q.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F15.6112817B.004C, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=F5gpiZpN c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=7juiuxWHQv7IaK6hktsA:9 a=PIRxba_xLfsokdVT:21 a=gt-EmsutlMfiVp--:21 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211490 Archived-At: 10 aug. 2021 kl. 15.23 skrev Eli Zaretskii : > Although perhaps we should strengthen the > search string to be sure we don't hit some false positive: "--color" > sounds a bit too general, no? Or do you think it's good enough even > if "--help" causes a non-zero exit code? I honestly don't know. The patch works here (obviously) but = strengthening it using a regexp to avoid matching "--colorise", say, = probably won't hurt. Not that it's very likely that this would ever make = a difference, but if you think that it's better safe then sorry then = I'll do that. For the record, on this Mac I get: $ grep --help usage: grep [-abcDEFGHhIiJLlmnOoqRSsUVvwxZ] [-A num] [-B num] [-C[num]] [-e pattern] [-f file] [--binary-files=3Dvalue] [--color=3Dwhen] [--context[=3Dnum]] [--directories=3Daction] [--label] = [--line-buffered] [--null] [pattern] [file ...] $ grep --version grep (BSD grep) 2.5.1-FreeBSD The exit status is probably a red herring; we do not seem to gain any = useful information from it.