From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Shigeru Fukaya Newsgroups: gmane.emacs.bugs Subject: bug#17814: 24.3.91; better string manipulation in subr-x Date: Sat, 21 Jun 2014 13:07:27 +0900 Message-ID: <3CCF8D06508F70shigeru.fukaya@gmail.com> References: <38CF8BF2232E16shigeru.fukaya@gmail.com> <39CF8CAB123C5Fshigeru.fukaya@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1403323709 29822 80.91.229.3 (21 Jun 2014 04:08:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 21 Jun 2014 04:08:29 +0000 (UTC) Cc: 17814@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 21 06:08:22 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WyCbF-0002bu-44 for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Jun 2014 06:08:21 +0200 Original-Received: from localhost ([::1]:43696 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WyCbE-0005n4-F4 for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Jun 2014 00:08:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54652) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WyCb4-0005m2-39 for bug-gnu-emacs@gnu.org; Sat, 21 Jun 2014 00:08:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WyCaw-0005el-Jb for bug-gnu-emacs@gnu.org; Sat, 21 Jun 2014 00:08:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35954) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WyCaw-0005eT-GM for bug-gnu-emacs@gnu.org; Sat, 21 Jun 2014 00:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WyCav-0002Nm-TS for bug-gnu-emacs@gnu.org; Sat, 21 Jun 2014 00:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Shigeru Fukaya Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Jun 2014 04:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17814 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17814-submit@debbugs.gnu.org id=B17814.14033236589127 (code B ref 17814); Sat, 21 Jun 2014 04:08:01 +0000 Original-Received: (at 17814) by debbugs.gnu.org; 21 Jun 2014 04:07:38 +0000 Original-Received: from localhost ([127.0.0.1]:55337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WyCaX-0002N8-SV for submit@debbugs.gnu.org; Sat, 21 Jun 2014 00:07:38 -0400 Original-Received: from mail-pb0-f48.google.com ([209.85.160.48]:55134) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WyCaV-0002Mq-IV for 17814@debbugs.gnu.org; Sat, 21 Jun 2014 00:07:36 -0400 Original-Received: by mail-pb0-f48.google.com with SMTP id rq2so3776188pbb.7 for <17814@debbugs.gnu.org>; Fri, 20 Jun 2014 21:07:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:mime-version:content-type :content-transfer-encoding:in-reply-to:references:message-id; bh=DTVjFk25lArhIoOk7nbdid5eQrDhk8CnYOu3cor/FJw=; b=mfwKsdtztg7wyMuZ2E9ixJn/Yks9vP/M1YcGNtmiLA3urpAroZbDzAqELt9Ng7imVk mmcJXA5+r5ym4ZSqtZ7reDQuQslEun3wgpVhM3rTCAUIcCExE3+7trrjfceGxiuhfXHi NCKM+Wd18UMD5fNmjsLZqoWwwIbcq62sWFOCkF6A6hW79omKpmL/cq/rcP0s9SP5gq1o 1D9dmcfl80KhIwQE6V0DXEYKtv4ojrb6L4UhmquSIXHfO/PMvWT/0Xo5bf4bO8lct3g3 3DCd+u5GCypt471gseU8qYRICgoCe0YYeVZ6u0hTKBAAFY+9j3wwjJgJyWqtwkrMnEO6 eFRw== X-Received: by 10.66.150.228 with SMTP id ul4mr10173099pab.16.1403323649506; Fri, 20 Jun 2014 21:07:29 -0700 (PDT) Original-Received: from gmail.com (115x125x38x6.ap115.ftth.ucom.ne.jp. [115.125.38.6]) by mx.google.com with ESMTPSA id cj1sm53073465pac.40.2014.06.20.21.07.27 for (version=TLSv1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 20 Jun 2014 21:07:28 -0700 (PDT) X-Mailer: HidemaruMail 6.24 (WinNT,602) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:90625 Archived-At: >The above string-match will fail on a string that has a newline, and the >subsequent code will use whatever was the old match-data, resulting in >broken behavior. "." in "\\`[\s\t\n\r]*\\(.*?\\)[\s\t\n\r]*\\'" must be "\\(.\\|\n\\)", sorry. >Other than that, I don't have any opinion on such changes (I've never >heard anyone complain about code size or cpu-time of any of those >functions, so I think it largely doesn't matter either way). Using string-trim-to-right and string-trim-to-left creates unnecessary temporary string if both sides need triming may matter, then? Anyway, I think I'm just sending a small proposal. I don't care much if you throw it away. Thank you for spending your time. Regards, Shigeru t