From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#65726: 29.1.50; Crash in regexp engine Date: Tue, 5 Sep 2023 14:23:19 +0200 Message-ID: <3A0AC9E2-A420-47B6-870A-69C53FCAEF71@gmail.com> References: <8e1b4e50-0430-3eb3-e486-60def1e4821f@gmx.at> <83fs3u5e7u.fsf@gnu.org> <835y4q5apw.fsf@gnu.org> <776370AB-662F-4C0A-95BF-97DEA4F18F54@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23968"; mail-complaints-to="usenet@ciao.gmane.io" Cc: martin rudalics , Eli Zaretskii , 65726@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 05 14:24:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qdV6R-00062r-T2 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 Sep 2023 14:24:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdV6B-00078e-Me; Tue, 05 Sep 2023 08:24:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdV6A-00078V-3j for bug-gnu-emacs@gnu.org; Tue, 05 Sep 2023 08:24:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdV69-0001CG-RS for bug-gnu-emacs@gnu.org; Tue, 05 Sep 2023 08:24:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qdV69-0007Qk-Tx for bug-gnu-emacs@gnu.org; Tue, 05 Sep 2023 08:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Sep 2023 12:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65726 X-GNU-PR-Package: emacs Original-Received: via spool by 65726-submit@debbugs.gnu.org id=B65726.169391661028507 (code B ref 65726); Tue, 05 Sep 2023 12:24:01 +0000 Original-Received: (at 65726) by debbugs.gnu.org; 5 Sep 2023 12:23:30 +0000 Original-Received: from localhost ([127.0.0.1]:54793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdV5e-0007Pi-6u for submit@debbugs.gnu.org; Tue, 05 Sep 2023 08:23:30 -0400 Original-Received: from mail-lj1-x22e.google.com ([2a00:1450:4864:20::22e]:61551) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdV5b-0007PU-Uj for 65726@debbugs.gnu.org; Tue, 05 Sep 2023 08:23:28 -0400 Original-Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2b9c907bc68so37136161fa.2 for <65726@debbugs.gnu.org>; Tue, 05 Sep 2023 05:23:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693916601; x=1694521401; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=WCE0OWSqr8wi8+AQRISIhw7QlJJNlTcMd/5aa2SToK4=; b=MABFQllAlL37ZgLB/qLJNUpAX4jItC+k7WG8TAFw8SC0RjNDAu7VvkHVzoVETpTnrP lZTx6VA4Qymc88/pcTAzfyGQSsib7KWFnfEhXsfGC53j39/t/9V9ktPzQVzp75QwAUnL IShX6XWLGlDZGijLvjEhUs2/6MGKOg5fN876McxwRvw3Z5MRx3PTHOoZRW+JHyG6UTcP up2TmEjk4JdmyfBkIGRlSXBc4hT3qgez55VvIDRKZBIz0KMTD/Uew1nS9mtIIKoQO/cY g9HD3AHPMYARxg8NUJEuOSr7+H1tQZREEMY0xXIe6nlWy1h4OwKl8GkR3Z+r3P8RXnbI hqOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693916601; x=1694521401; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=WCE0OWSqr8wi8+AQRISIhw7QlJJNlTcMd/5aa2SToK4=; b=CK7BDxcJx/dpnc/eQ1fzazrjv4IwcwaMyr/1TRji+FADDs/TAIBdm5uoUUttFeGvZe PwW5+tY765IAY8i4fcV4jiWXId75YXnTar5tHVvjcK59SKUgnkRlwpwz8/ZkO7vPnUis 8ODqtDICVNiJeOeKs/vf3kTuEq1FmGk3XQ1pBFYKK2yeaD1HGOSTRIOteLji5cLaKBpb 2YwxZ9Q/uz7q1OWUKKK9h6QoCeybDKOEJDmQL4LtO1rrHXeF2FHyx8hOpNyZ1U7qWPBx G/2MgQDsBzl9WNG6ejLtk4c8CWX6q6/eZ5zhSxJBPXCfzrD3JDtg6BmwHJ8XktL+ViBk i2aA== X-Gm-Message-State: AOJu0YwLnJbRyAusTKP+1brMnRXQLt0sqXLxCrT453zJ2xBbjwOI8Blz X7428MKsDViklDjCDzcdzEQ= X-Google-Smtp-Source: AGHT+IEqr87UsDdBnZFfAPcx3aFl1i7aioXFlafM9R3VJykshw0hpVmW8LAw3aNlplDQ8Av10psynA== X-Received: by 2002:a2e:9691:0:b0:2bc:d33e:ccc5 with SMTP id q17-20020a2e9691000000b002bcd33eccc5mr10106765lji.41.1693916601077; Tue, 05 Sep 2023 05:23:21 -0700 (PDT) Original-Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id a26-20020a2e861a000000b002b9f0fb5f20sm2912326lji.72.2023.09.05.05.23.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Sep 2023 05:23:20 -0700 (PDT) In-Reply-To: <776370AB-662F-4C0A-95BF-97DEA4F18F54@gmail.com> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269348 Archived-At: Thank you for fixing it, but now regex-emacs-tests fail with a regexp = stack overflow. It seems that by fixing this bug, we've unfixed the one = that the broken code was supposed to fix. And we should probably include a regression test for this bug as well. = The previously mentioned (string-match (rx (* "a") (* (* "b"))) "a") might suffice, but extending it to (string-match (rx (* "a") (* (or "c" (* "b")))) "a") is safer in case the regexp compiler decides to simplify (* (* X)) -> (* = X).