unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Nikolay Kudryavtsev <nikolay.kudryavtsev@gmail.com>
To: Nicolas Petton <nicolas@petton.fr>, 19452@debbugs.gnu.org
Subject: bug#19452: 24.4; sql-connect fails in first invocation: "Attempt to set a constant symbol: nil"
Date: Sun, 31 Jul 2016 15:50:48 +0300	[thread overview]
Message-ID: <39ce25ad-73f3-0ff9-91bf-d7beceb0c1c2@gmail.com> (raw)
In-Reply-To: <87twfccu36.fsf@petton.fr>

[-- Attachment #1: Type: text/plain, Size: 92 bytes --]

Here's the same patch made from the current master.

-- 
Best Regards,
Nikolay Kudryavtsev


[-- Attachment #2: 19452.patch --]
[-- Type: text/plain, Size: 1444 bytes --]

diff --git lisp/progmodes/sql.el lisp/progmodes/sql.el
index a11d456..9a7b746 100644
*** lisp/progmodes/sql.el
--- lisp/progmodes/sql.el
***************
*** 4040,4045 ****
--- 4040,4051 ----
            (if connect-set
                ;; Set the desired parameters
                (let (param-var login-params set-params rem-params)
+                 ;; Set the parameters and start the interactive session
+                 (mapc
+                  (lambda (vv)
+                    (set-default (car vv) (eval (cadr vv))))
+                  (cdr connect-set))
+                 (setq-default sql-connection connection)

                  ;; :sqli-login params variable
                  (setq param-var
***************
*** 4069,4081 ****
                             (unless (member token set-params)
                               (if plist (cons token plist) token)))))

-                 ;; Set the parameters and start the interactive session
-                 (mapc
-                  (lambda (vv)
-                      (set-default (car vv) (eval (cadr vv))))
-                  (cdr connect-set))
-                 (setq-default sql-connection connection)
-
                  ;; Start the SQLi session with revised list of login parameters
                  (eval `(let ((,param-var ',rem-params))
                           (sql-product-interactive ',sql-product ',new-name))))
--- 4075,4080 ----

  parent reply	other threads:[~2016-07-31 12:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-27  6:45 bug#19452: 24.4; sql-connect fails in first invocation: "Attempt to set a constant symbol: nil" JuanLeon Lahoz
2016-07-25 20:12 ` Nikolay Kudryavtsev
2016-07-25 20:56   ` Nicolas Petton
2016-07-26 13:19     ` Nikolay Kudryavtsev
2016-07-26 15:11       ` Nicolas Petton
2016-07-26 15:38         ` Eli Zaretskii
2016-07-26 16:41           ` Nicolas Petton
2016-07-31 12:50         ` Nikolay Kudryavtsev [this message]
2016-11-29 21:01 ` bug#19452: status? root
2016-12-02  9:55   ` Eli Zaretskii
2016-12-13 11:06     ` root

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39ce25ad-73f3-0ff9-91bf-d7beceb0c1c2@gmail.com \
    --to=nikolay.kudryavtsev@gmail.com \
    --cc=19452@debbugs.gnu.org \
    --cc=nicolas@petton.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).