From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#24745: 25.1.50; whitespace.el: fix beginning/end of buffer checks Date: Wed, 26 Oct 2016 01:45:34 +0300 Message-ID: <39a8c955-928a-1551-3943-b8ccfda38eca@yandex.ru> References: <87pomv6w1h.fsf@sc3d.org> <83402aab-73d0-eeae-1df1-c717caf198ba@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1477435604 17631 195.159.176.226 (25 Oct 2016 22:46:44 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 25 Oct 2016 22:46:44 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Thunderbird/50.0 Cc: 24745@debbugs.gnu.org To: Reuben Thomas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 26 00:46:40 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bzATy-0000da-S7 for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Oct 2016 00:46:11 +0200 Original-Received: from localhost ([::1]:58594 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzAU1-0002QD-45 for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Oct 2016 18:46:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38530) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzATt-0002Ps-Dm for bug-gnu-emacs@gnu.org; Tue, 25 Oct 2016 18:46:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzATq-0002XY-B0 for bug-gnu-emacs@gnu.org; Tue, 25 Oct 2016 18:46:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41429) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bzATq-0002XU-7j for bug-gnu-emacs@gnu.org; Tue, 25 Oct 2016 18:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bzATq-0003ra-1o for bug-gnu-emacs@gnu.org; Tue, 25 Oct 2016 18:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Oct 2016 22:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24745 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24745-submit@debbugs.gnu.org id=B24745.147743554514829 (code B ref 24745); Tue, 25 Oct 2016 22:46:02 +0000 Original-Received: (at 24745) by debbugs.gnu.org; 25 Oct 2016 22:45:45 +0000 Original-Received: from localhost ([127.0.0.1]:56828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bzATY-0003r6-RP for submit@debbugs.gnu.org; Tue, 25 Oct 2016 18:45:45 -0400 Original-Received: from mail-wm0-f66.google.com ([74.125.82.66]:39112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bzATW-0003qt-V0 for 24745@debbugs.gnu.org; Tue, 25 Oct 2016 18:45:43 -0400 Original-Received: by mail-wm0-f66.google.com with SMTP id m83so2223875wmc.6 for <24745@debbugs.gnu.org>; Tue, 25 Oct 2016 15:45:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=uzjnlfovZNyjF/BAueAN4T5/byaR8apPnWnv3Y9yuWw=; b=IWAABG9fowUyuHUgTsDBntiiZ0aS/bN6WJwktiEdortnDOFfBWF5q3Si1Ncr2oryLB Ci2a+VAj/OmGCniNRYy/CBHHev+LxA5jJnsTh3N0T0I/X5BANQvQNcKIegwsNe7QEMaJ CY3LZfBJVlcWjokrxlkeXU0eoUQ1eWMz6gQ8NAstKkVB+vp33V8NB6QndR/hqsgbB0Qy WfJOiOJNBNmj2i0SEn0HeszgHPRu0TXUBiIWetU5O6bBJvMrZP41zEUISmWjVXPe1j6y Sbi1/mIfOYwwaIMMg350NS3eJ9XNACvAIz8VvAY8f65U+9Gx/G2nNoc0m4bUvYaT7lFh Q2vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uzjnlfovZNyjF/BAueAN4T5/byaR8apPnWnv3Y9yuWw=; b=TO5woD4dN1Tt1whdf4HnD7cdQgjf7r2eoONBCyvcYMwIsNvItL50xyHDKp86sd/Nx9 zXES6fxEVnJxyDoPaGO3mDbLiCo0HZ7upghXVyjGaxyLi9yFqWTZTeqwff90is8wXw9f jc/RllJcivL5GyeEv1TuPftNO4U7Aov44VCREdgj8lA4miQpaLTpuRP7G4ja1xhJSpkY 4v0ilie/BZiUU9s94w4F4CnEQhw/dJgtQpKJ1EANJDBlX7kr1Wc2RphzqzDHUMQ9BniV hCOjd23Cbvx4Q4UV8KDePz5CGWgS6jOn0UUujOzh/0rBxBMPAMejU+HT6E4x+zdsAla3 SZsA== X-Gm-Message-State: ABUngvcCsvPKa6Vs7xCa/T04C/Sqkukrp3X0/K18y1UtZVj0HoA5sl6cwu9MfGlwf17isA== X-Received: by 10.194.153.228 with SMTP id vj4mr614559wjb.204.1477435537198; Tue, 25 Oct 2016 15:45:37 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id jx8sm27440516wjc.2.2016.10.25.15.45.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Oct 2016 15:45:36 -0700 (PDT) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125020 Archived-At: On 25.10.2016 21:44, Reuben Thomas wrote: > I should check some context: my understanding is that inline > documentation in .el files is mainly useful for high-level documentation > for standalone packages. Packages that form part of Emacs should be > documented in the manual (as whitespace.el is); details of functions and > variables should be in docstrings (as is the case for whitespace.el). > The docstrings of customizable options are readable in the customize > interface. Maybe you're right. I'd leave at least "to change behavior, do M-x customize-group whitespace", though. Maybe someone else would like to weigh in. > ​Apologies. As far as I could see, the main things that were wrong were > the summary lines and the lack of function names (or equivalent) in the > detailed log. I have rewritten all of them. You're close, but: - Sentences should start with a capital letter. - The function names are usually reflowed in a different way (you can put several of them in parentheses, but each such groups only spans one line). Try copying the message from the first patch to a ChangeLog file, and press M-q to see that in action. - The messages should references this bug report. - The file should be consistently referred to as lisp/whitespace.el. You can automate the adherence to most of these rules by first entering the messages in a local-only ChangeLog file, using 'C-x 4 a'. Also see "Generating ChangeLog entries" in CONTRIBUTE. > I have rebased the patch series against master and attach the new version. Thanks. Do you have commit access?