From: Jim Porter <jporterbugs@gmail.com>
To: 56896@debbugs.gnu.org
Subject: bug#56896: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark
Date: Tue, 2 Aug 2022 12:13:44 -0700 [thread overview]
Message-ID: <39a51230-2a0f-4eb7-a811-e4509a826f5d@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 986 bytes --]
Currently, the bookmark fringe icon is a circle. However, Emacs already
uses a circle to represent breakpoints (as do a lot of other IDEs).
These are usually a different color, but I think it would be nice if the
bookmark fringe icon were a different shape too. This would help
colorblind users, since (depending on their Emacs theme and what kind of
colorblindness they have), it might be hard to distinguish the bookmark
icon from the breakpoint icon.
It would help make the purpose of the indicator more obvious to users
who don't directly use bookmarks. Some packages (including the built-in
org-capture package) set bookmarks automatically, and a user might not
realize that the dot indicates a bookmark, as opposed to some other thing.
Attached are some screenshots showing before/after, plus a patch for
this. I converted the string definition of the bitmap to a vector of
(binary) numbers, since then a reader can see the shape of the icon if
they look carefully.
[-- Attachment #2: 0001-Make-the-bookmark-fringe-icon-look-like-a-bookmark.patch --]
[-- Type: text/plain, Size: 922 bytes --]
From 0671b44808a07237a1c183e80c7ba713255c9ee8 Mon Sep 17 00:00:00 2001
From: Jim Porter <jporterbugs@gmail.com>
Date: Tue, 2 Aug 2022 11:40:43 -0700
Subject: [PATCH] Make the bookmark fringe icon look like a bookmark
* lisp/bookmark.el (bookmark-fringe-mark): Change the bitmap to look
like a bookmark.
---
lisp/bookmark.el | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/lisp/bookmark.el b/lisp/bookmark.el
index 30a03e0431..53da501316 100644
--- a/lisp/bookmark.el
+++ b/lisp/bookmark.el
@@ -483,7 +483,14 @@ bookmark-history
"The history list for bookmark functions.")
(define-fringe-bitmap 'bookmark-fringe-mark
- "\x3c\x7e\xff\xff\xff\xff\x7e\x3c")
+ [#b01111110
+ #b01111110
+ #b01111110
+ #b01111110
+ #b01111110
+ #b01111110
+ #b01100110
+ #b01000010])
(defun bookmark--set-fringe-mark ()
"Apply a colorized overlay to the bookmarked location.
--
2.25.1
[-- Attachment #3: before.png --]
[-- Type: image/png, Size: 2884 bytes --]
[-- Attachment #4: after.png --]
[-- Type: image/png, Size: 2876 bytes --]
next reply other threads:[~2022-08-02 19:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 19:13 Jim Porter [this message]
2022-08-02 19:18 ` bug#56896: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark Eli Zaretskii
2022-08-02 20:05 ` Jim Porter
2022-08-03 2:28 ` Eli Zaretskii
2022-08-04 3:24 ` Jim Porter
2022-08-04 6:53 ` Eli Zaretskii
2022-08-04 6:57 ` Lars Ingebrigtsen
2022-08-05 4:41 ` Jim Porter
2022-08-13 21:59 ` bug#56896: 29.0.50; [PATCHv3] " Jim Porter
2022-08-15 6:44 ` Lars Ingebrigtsen
2022-08-16 4:17 ` Jim Porter
2022-08-21 16:23 ` Juri Linkov
2022-08-02 20:10 ` bug#56896: 29.0.50; [PATCH] " Drew Adams
2022-08-03 2:23 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-03 2:42 ` Jim Porter
2022-08-03 4:31 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39a51230-2a0f-4eb7-a811-e4509a826f5d@gmail.com \
--to=jporterbugs@gmail.com \
--cc=56896@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).