From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Newsgroups: gmane.emacs.bugs Subject: bug#53071: 28.0.90; Emacs 28 regression: incorrect code generation for complex pcase forms? Date: Wed, 12 Jan 2022 03:19:42 +0100 Message-ID: <39D132B5-6B44-41F0-A618-6A68BFB5FEBF@gmail.com> References: Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.40.0.1.81\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2256"; mail-complaints-to="usenet@ciao.gmane.io" To: 53071@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 12 03:20:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7TFJ-0000P0-G2 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Jan 2022 03:20:17 +0100 Original-Received: from localhost ([::1]:48078 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7TFH-0005mF-UN for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Jan 2022 21:20:15 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51262) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7TF4-0005m4-7J for bug-gnu-emacs@gnu.org; Tue, 11 Jan 2022 21:20:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34774) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n7TF3-0002HO-Uf for bug-gnu-emacs@gnu.org; Tue, 11 Jan 2022 21:20:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n7TF3-00048V-RB for bug-gnu-emacs@gnu.org; Tue, 11 Jan 2022 21:20:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jan 2022 02:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53071 X-GNU-PR-Package: emacs Original-Received: via spool by 53071-submit@debbugs.gnu.org id=B53071.164195399215870 (code B ref 53071); Wed, 12 Jan 2022 02:20:01 +0000 Original-Received: (at 53071) by debbugs.gnu.org; 12 Jan 2022 02:19:52 +0000 Original-Received: from localhost ([127.0.0.1]:55910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7TEt-00047u-NE for submit@debbugs.gnu.org; Tue, 11 Jan 2022 21:19:51 -0500 Original-Received: from mail-wr1-f48.google.com ([209.85.221.48]:46054) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7TEs-00047d-3i for 53071@debbugs.gnu.org; Tue, 11 Jan 2022 21:19:50 -0500 Original-Received: by mail-wr1-f48.google.com with SMTP id q8so1496467wra.12 for <53071@debbugs.gnu.org>; Tue, 11 Jan 2022 18:19:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:content-transfer-encoding:mime-version:subject:date:references :to:in-reply-to:message-id; bh=u+5/prJkqs7Emm5dl3YfH1LUBZTv5XSusxAqJmymthM=; b=mFIOubfdIZH9EgFmEdWupVRbZFPPWbm+YTNbt+Enx2dDZb0AL7EygPu8ZCnneHMgTL DrGc6s3+5NdREvXymolPeyUJ3zS6qzsxO3BUvmTu46X8wfRWPgvXe3I4ZA9R1/z5/Dih BfT4qUAUwIlnw8ktYuCKGxy9BJF3vHAz8ajW5BAZd3EqdT52EHx5EaiuE1iICFzOo0yC l/Si9l2clptWeOyxeLiFI7NWjSa2wg99C9toKeNJJN2/Tsd5Ui9UMcuzPcB1EIoVUFZY 4hfsogKFe4ekF2IlMnoe9/vWLOZPtCLw53rurasc2+LISYyo5dMGvJ/vYSX5g68FJibv SS/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:date:references:to:in-reply-to:message-id; bh=u+5/prJkqs7Emm5dl3YfH1LUBZTv5XSusxAqJmymthM=; b=vPWvTvep6SCj62nRJ92svhN8FPhIEp5UVdpDz9FbH3TuXl6lbTEWTG61wUYKKuy5iR 8dJA7rKcVaNfDoHDXL+bzISLzW78IeIyAwrrFVLAM21W6iEixZ8HvOqKw/XOsbOgftqI RuyL0RBWikbNEQ7pFqKtUK16hliStNwgL9BRkTVN7agBJcpgzv7ll+vgPqJgP7t8/ChZ GVTNoTDJ7sRPEON4IuDPWCxTSXu8kd7X4wx4BJPMntmHOlWGmMzgImE783VtuFBSxwdl qljDFRCjEWap4Qb+UKGsnJS/1tPLY4I9DT2XbPk3SOfcL8/Q9wkaLVQ/nvfk2dHXGd9P tlzA== X-Gm-Message-State: AOAM532zx9G9yLweKKAxN6kx6iUCO+k4kQrRXqdQvwhSJXeyOP1NNXdE wbdkKUCQn+ARzw+UxL+OmbvYe+T17JY= X-Google-Smtp-Source: ABdhPJwFOC/HoNEdFvrABpfSy0H20O6cvMitCi+jCY5sj58OZBUIHTmtRY7Dau5UHBdBTc6UV5ry5g== X-Received: by 2002:adf:ab59:: with SMTP id r25mr6302660wrc.321.1641953983821; Tue, 11 Jan 2022 18:19:43 -0800 (PST) Original-Received: from smtpclient.apple ([2a02:2455:2a4:dc00:e1c4:132:bb2:acf9]) by smtp.gmail.com with ESMTPSA id i8sm13831000wry.108.2022.01.11.18.19.43 for <53071@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Jan 2022 18:19:43 -0800 (PST) In-Reply-To: X-Mailer: Apple Mail (2.3693.40.0.1.81) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223975 Archived-At: > Am 07.01.2022 um 10:36 schrieb Philipp Stephani = : >=20 >=20 > I hit the following subtle Edebug regression in Emacs 28: >=20 > Create a file /tmp/pcase-edebug.el with these contents: >=20 > $ cat /tmp/pcase-edebug.el=20 > ;; -*- lexical-binding: t; -*- > (require 'rx) > (defun f (a) > (pcase a > ((rx bos (let q (opt (let r nonl)) (let a nonl))) > (message "%s" a)) > ((rx bos eos) > (message "%s" a)))) >=20 > Visit the file in Emacs: >=20 > $ emacs -Q -l rx /tmp/pcase-edebug.el >=20 > Move point into the `f' function and instrument it using C-u C-M-x. > Then, byte-compile `f' using M-: (byte-compile 'f). > In Emacs 28, this will generate the following warnings: >=20 > Warning: Unused lexical variable `q' > Warning: Unused lexical variable `r' > Warning: reference to free variable =E2=80=98a=E2=80=99 >=20 > The first two are expected, the third one is not. > Indeed, M-: (f "ab") and stepping through the code will signal an = error: >=20 > Symbol's value as variable is void: a 'git bisect' claims that the following commit is the culprit: commit 1362a9fec4dff341a84c881ac17dbf1ee2cf82fd Author: Mattias Engdeg=C3=A5rd Date: Fri Mar 5 20:21:01 2021 +0100 Make lambda-lifting work again =20