From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andrew Moore Newsgroups: gmane.emacs.bugs Subject: bug#24957: 26.0.50; DARWIN_OS_CASE_SENSITIVE_FIXME typos (PATCH) Date: Wed, 16 Nov 2016 17:29:12 -0500 Message-ID: <39BFCECE-1083-4FF2-A3F1-5E8DC10646F1@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1479335902 5287 195.159.176.226 (16 Nov 2016 22:38:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 16 Nov 2016 22:38:22 +0000 (UTC) To: 24957@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 16 23:38:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c78qM-0008Rr-S4 for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Nov 2016 23:38:15 +0100 Original-Received: from localhost ([::1]:55475 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c78qM-0006Ti-Lz for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Nov 2016 17:38:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42250) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c78qF-0006Td-Tb for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2016 17:38:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c78qA-0005HS-Tm for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2016 17:38:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44536) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c78qA-0005HK-QB for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2016 17:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c78qA-00034p-K7 for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2016 17:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrew Moore Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Nov 2016 22:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 24957 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.147933584711771 (code B ref -1); Wed, 16 Nov 2016 22:38:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 16 Nov 2016 22:37:27 +0000 Original-Received: from localhost ([127.0.0.1]:59935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c78pa-00033m-LB for submit@debbugs.gnu.org; Wed, 16 Nov 2016 17:37:26 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:47541) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c78hr-0002rA-8E for submit@debbugs.gnu.org; Wed, 16 Nov 2016 17:29:27 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c78hk-0007MI-R5 for submit@debbugs.gnu.org; Wed, 16 Nov 2016 17:29:22 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:41992) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c78hk-0007MA-Mk for submit@debbugs.gnu.org; Wed, 16 Nov 2016 17:29:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38489) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c78hj-0005gu-3r for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2016 17:29:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c78hf-0007Cu-T8 for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2016 17:29:19 -0500 Original-Received: from mail-yb0-x244.google.com ([2607:f8b0:4002:c09::244]:33045) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c78hf-0007B5-ML for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2016 17:29:15 -0500 Original-Received: by mail-yb0-x244.google.com with SMTP id v78so5362879ybe.0 for ; Wed, 16 Nov 2016 14:29:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:content-transfer-encoding:subject:message-id:date:to :mime-version; bh=RPsyQAVE+ak66Qq6XAogWONHUt4cNyqQQ2tICK9+INQ=; b=NpZXBzzxIIKnlTxeHMtLYE/uByavPu6DqB2IPurLvAEB/nxHoar67eWOKzliTJ7ntl QQPIvsctpNi+XWC9mF1kJ7hdIR9kJnCRv1Px3BJRS97urP9Xo5nRxg0Tr5MrgAzlzjef PDF/z/WUP7Gkq/J538zFz1nOZxyI+gBmYg++Eb7Vll5WHSsZvWTX1ysUn8UEyTYIIk+x g+E8Va95yWveiH3NQjrPKsEAcwKZti/Xivs5YXblRGr54jWPs9q7PlgD4jTG3Tnl+J92 kB2/9gWqsRQWYVl3vkB8gEB+vfZEHiTnppJYzmrIVBqMVz6Dd475x7mt41wLUbr21HwX vS7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:content-transfer-encoding:subject :message-id:date:to:mime-version; bh=RPsyQAVE+ak66Qq6XAogWONHUt4cNyqQQ2tICK9+INQ=; b=bhDByFXBydGcdfNpDoZNz09W9c5Q7yEfxQxzzNAnIPoMBcm4lZZEeA6vzGbX4vPBsY rfWr3T3S2rg2WGmjXby00B2SrLDmnjj9W93Pz3SdSa1sR2P4OcTuL/zYZYaQ+nQO/rNh PCxqXSUhF4IfLqeCw2wqIQ2owzO4iWSbZU3twelq4oGChxfsHKTxLuRy7XDGKAp7e1Kf rxn9NFmRi5XveNzjGsJ9TjkJ0PMN80izG0O8MQaYcdD26+Ky1XxK3OCE+3njxU1kMBhm WQ3bIr3QlpmJMaOcwkRKrb4byImvwQ0jEuBIE4HSIEeXVJ69TZw2MjSBwAAUjh6RxwYG cB/A== X-Gm-Message-State: ABUngvcBkE3UnjZ9yiur6bOObkqri8vNZAv9asXRH62vHCbA4UTTpShGyRgNMMPl3P5uRQ== X-Received: by 10.37.230.201 with SMTP id d192mr3244487ybh.84.1479335353759; Wed, 16 Nov 2016 14:29:13 -0800 (PST) Original-Received: from vesta.slewsys.org (c-24-125-236-131.hsd1.ga.comcast.net. [24.125.236.131]) by smtp.gmail.com with ESMTPSA id q186sm4177ywb.2.2016.11.16.14.29.13 for (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 16 Nov 2016 14:29:13 -0800 (PST) X-Mailer: Apple Mail (2.3124) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Mailman-Approved-At: Wed, 16 Nov 2016 17:37:25 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125772 Archived-At: Following commit 8b48e937af801e11e2d1844d60b6e585ce09dcea ("Simplify case-insensitivity checks on Mac OS X"), Emacs fails to compile under = darwin due to typos. Here's a patch: diff --git a/src/fileio.c b/src/fileio.c index 70799eb..f741a78 100644 --- a/src/fileio.c +++ b/src/fileio.c @@ -2282,7 +2282,7 @@ file_name_case_insensitive_p (const char = *filename) { /* This is based on developer.apple.com's getattrlist man page. = */ struct attrlist alist =3D {.volattr =3D ATTR_VOL_CAPABILITIES}; - struct vol_capabilities_attr_t vcaps; + /* struct */ vol_capabilities_attr_t vcaps; if (getattrlist (filename, &alist, &vcaps, sizeof vcaps, 0) =3D=3D = 0) { if (vcaps.valid[VOL_CAPABILITIES_FORMAT] & = VOL_CAP_FMT_CASE_SENSITIVE) @@ -2295,7 +2295,7 @@ file_name_case_insensitive_p (const char = *filename) /* The following is based on = http://lists.apple.com/archives/darwin-dev/2007/Apr/msg00010.html. */ struct attrlist alist; - unsigned char buffer[sizeof (vol_capabilities_attr_t) sizeof = (size_t)]; + unsigned char buffer[sizeof (vol_capabilities_attr_t) + sizeof = (size_t)]; memset (&alist, 0, sizeof (alist)); alist.volattr =3D ATTR_VOL_CAPABILITIES; In GNU Emacs 26.0.50.3 (x86_64-apple-darwin15.6.0, NS appkit-1404.47 = Version 10.11.6 (Build 15G1108)) of 2016-11-16 built on vesta.slewsys.org Repository revision: dc4b8a0c329a9d9e56e6be63cb4a0f59a952b07f Windowing system distributor 'Apple', version 10.3.1404 Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. /opt/src/programming/emacs/emacs mwheel-scroll: End of buffer [4 times] Compilation exited abnormally with code 2 Configured using: 'configure --prefix=3D/opt --with-ns CC=3D/usr/bin/clang CXX=3D/usr/bin/clang++' Configured features: JPEG RSVG IMAGEMAGICK DBUS NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS Important settings: value of $LC_ALL: en_US.UTF-8 value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: shell-dirtrack-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message subr-x puny seq byte-opt gv bytecomp byte-compile cl-extra help-mode cconv cl-loaddefs pcase cl-lib dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils compile shell pcomplete comint ansi-color ring time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind kqueue cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 215600 6717) (symbols 48 20559 0) (miscs 40 52 123) (strings 32 20332 6483) (string-bytes 1 663313) (vectors 16 35782) (vector-slots 8 676057 7085) (floats 8 186 173) (intervals 56 582 0) (buffers 976 13))