From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#62333: 30.0.50; Issue with tree-sitter syntax tree during certain changes Date: Sat, 25 Mar 2023 16:18:12 +0200 Message-ID: <398721ad-79b0-3f6d-97b3-4902d9bfbe39@yandex.ru> References: <87fs9yur7r.fsf@gmail.com> <2fd8f2b8-d9c4-c825-a789-f2d42324859f@yandex.ru> <09539C5E-23DA-4B00-A3F6-873A41D6A2CE@gmail.com> <83h6uc549z.fsf@gnu.org> <665745A2-FDC8-45DE-BFF5-2F688FC85431@gmail.com> <491b788f-c3c3-4877-daa0-f515be9f3a17@yandex.ru> <83sfduelab.fsf@gnu.org> <8FC25A01-6934-43BB-899C-CA5926BEA3CF@gmail.com> <83jzz5c8ml.fsf@gnu.org> <83edpdc6sn.fsf@gnu.org> <1ca302bf-99dc-7f9e-8544-063064a1cb21@yandex.ru> <831qlcdisi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29204"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Cc: wkirschbaum@gmail.com, casouri@gmail.com, 62333@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 25 15:19:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pg4jq-0007Kn-Re for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Mar 2023 15:19:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pg4jX-0001k2-QP; Sat, 25 Mar 2023 10:19:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pg4jW-0001jr-ML for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 10:19:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pg4jW-0002vX-Ed for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 10:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pg4jW-0008H9-9w for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 10:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Mar 2023 14:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62333 X-GNU-PR-Package: emacs Original-Received: via spool by 62333-submit@debbugs.gnu.org id=B62333.167975390331750 (code B ref 62333); Sat, 25 Mar 2023 14:19:02 +0000 Original-Received: (at 62333) by debbugs.gnu.org; 25 Mar 2023 14:18:23 +0000 Original-Received: from localhost ([127.0.0.1]:43180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg4is-0008G2-O8 for submit@debbugs.gnu.org; Sat, 25 Mar 2023 10:18:23 -0400 Original-Received: from mail-wm1-f45.google.com ([209.85.128.45]:36661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg4ir-0008Fp-5L for 62333@debbugs.gnu.org; Sat, 25 Mar 2023 10:18:21 -0400 Original-Received: by mail-wm1-f45.google.com with SMTP id j18-20020a05600c1c1200b003ee5157346cso4717024wms.1 for <62333@debbugs.gnu.org>; Sat, 25 Mar 2023 07:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679753895; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=jfq/XHSDFteeuKBALXukhAvy3IS3sVXtOdmzWFU2VZ0=; b=TFX89oLO2epzZ1ZFjN/jrUlRmBM70Io8vLDQz/tcA4aDP+qsA4si4JDRw/AvtT7pqC QQTseFGo0o93ZxAuRS//CFSo1jkzbEY1EcNVrIi6kt7eUOwywFgH5xO72id0DHWr73hO POokoYGTCH5fMv+l8HSWQDrAhiSzNTQ/s+VHqOtmsLzSJbfnByjsNPCpMIuu2jbWPZe5 mfaomSAgCY0FrsSm98PhnXV9HH1I1C1QucxS9HmAXylcbuVuwOPaEJ2PHm6EUss8WSis a/OSwjfwDGrvqRQu2w6a2vijeW7B4r1QX34aZ/AptPbJonRaNbRAQx/qfFDtJCn/4cJ3 P04Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679753895; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jfq/XHSDFteeuKBALXukhAvy3IS3sVXtOdmzWFU2VZ0=; b=7YuErgVJQAZHvJDNfCv0oxGutDLT8aR1hts9YkYJpGe84C3GhMYTjC+QTSJTuAW/J8 rw7uhC44ssjNTHx10uV1fTp0coV0S4ZJbdbpoFRL+OT/N6RcJP72hlelGKbn7rzLovgO n3ndFwRxcuvsIse23B3t25Ol98X33abcbr+aCxWD1qvAUVsRdNHLa0qOSZ46Gbc71kJE jIDYpvdzr7iB/10U0dGOACyRlwHU/OJtj7oy/+Cy29Us5Nz+L2un0vy3xB8pw7NN4m0e J/Efivj8k1f9ZITG+AS3PWAT2l8TPRz951n0qqUKsX/99k6/u3acLuoa9ak6o1kh+KLc 3/ag== X-Gm-Message-State: AO0yUKWMskQSAq2ubwzHLGfiyS5LtL0kocI20bE06GECaYadvNr8VfpC xnEaCTiyK7zdH2tS7RSsssw= X-Google-Smtp-Source: AK7set9vXctj9n1WKj3na8DKMJRy5+AOaaXzlyH6MC8bukqgthasJbPZ469EjmkziRU2pNh/25awnw== X-Received: by 2002:a1c:6a19:0:b0:3e2:201a:5bcc with SMTP id f25-20020a1c6a19000000b003e2201a5bccmr4900688wmc.33.1679753895313; Sat, 25 Mar 2023 07:18:15 -0700 (PDT) Original-Received: from [192.168.0.2] ([85.132.229.92]) by smtp.googlemail.com with ESMTPSA id o9-20020a05600c510900b003ed793d9de0sm14278658wms.1.2023.03.25.07.18.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Mar 2023 07:18:14 -0700 (PDT) Content-Language: en-US In-Reply-To: <831qlcdisi.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258580 Archived-At: On 25/03/2023 16:09, Eli Zaretskii wrote: >> Date: Sat, 25 Mar 2023 15:44:18 +0200 >> Cc: wkirschbaum@gmail.com, casouri@gmail.com, 62333@debbugs.gnu.org >> From: Dmitry Gutov >> >>> If that's the only reason, then tree-sitter based modes could widen >>> back in their sexp-moving functions, since they use the parse data for >>> this, right? >> >> Not necessarily: it doesn't know the purpose for which the narrowing was >> applied. Could be for a mixed-major-mode thing, or some other purpose. > > mixed-major-mode shouldn't be a problem. Why wouldn't it? >> Long lines? > > Easy to test, and the call to widen will do nothing anyway in that > case. Okay. Because of locked narrowing, I guess. >> Do we recall the exact design idea why tree-sitter visibility is limited >> by the narrowing bounds? > > For the same reason: because the buffer is inaccessible outside the > restriction, and tree-sitter wants to access the buffer text. > >> Because if we wanted to widen in all similar situations, we might as >> well make it not obey the narrowing at all. > > It is impossible to not obey narrowing, not in Emacs. I told that and > explained that many times already, including simple examples of what > trouble this could cause to even the most innocent Lisp code. I hoped > that by now this should no longer be brought forward. Okay. But do you advocate all uses of tree-sitter to (widen) first?